You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 

3903 lines
106 KiB

  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "context"
  8. "crypto/tls"
  9. "errors"
  10. "flag"
  11. "fmt"
  12. "io"
  13. "io/ioutil"
  14. "log"
  15. "net"
  16. "net/http"
  17. "net/http/httptest"
  18. "os"
  19. "os/exec"
  20. "reflect"
  21. "runtime"
  22. "strconv"
  23. "strings"
  24. "sync"
  25. "sync/atomic"
  26. "testing"
  27. "time"
  28. "golang.org/x/net/http2/hpack"
  29. )
  30. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  31. func stderrv() io.Writer {
  32. if *stderrVerbose {
  33. return os.Stderr
  34. }
  35. return ioutil.Discard
  36. }
  37. type serverTester struct {
  38. cc net.Conn // client conn
  39. t testing.TB
  40. ts *httptest.Server
  41. fr *Framer
  42. serverLogBuf bytes.Buffer // logger for httptest.Server
  43. logFilter []string // substrings to filter out
  44. scMu sync.Mutex // guards sc
  45. sc *serverConn
  46. hpackDec *hpack.Decoder
  47. decodedHeaders [][2]string
  48. // If http2debug!=2, then we capture Frame debug logs that will be written
  49. // to t.Log after a test fails. The read and write logs use separate locks
  50. // and buffers so we don't accidentally introduce synchronization between
  51. // the read and write goroutines, which may hide data races.
  52. frameReadLogMu sync.Mutex
  53. frameReadLogBuf bytes.Buffer
  54. frameWriteLogMu sync.Mutex
  55. frameWriteLogBuf bytes.Buffer
  56. // writing headers:
  57. headerBuf bytes.Buffer
  58. hpackEnc *hpack.Encoder
  59. }
  60. func init() {
  61. testHookOnPanicMu = new(sync.Mutex)
  62. goAwayTimeout = 25 * time.Millisecond
  63. }
  64. func resetHooks() {
  65. testHookOnPanicMu.Lock()
  66. testHookOnPanic = nil
  67. testHookOnPanicMu.Unlock()
  68. }
  69. type serverTesterOpt string
  70. var optOnlyServer = serverTesterOpt("only_server")
  71. var optQuiet = serverTesterOpt("quiet_logging")
  72. var optFramerReuseFrames = serverTesterOpt("frame_reuse_frames")
  73. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  74. resetHooks()
  75. ts := httptest.NewUnstartedServer(handler)
  76. tlsConfig := &tls.Config{
  77. InsecureSkipVerify: true,
  78. NextProtos: []string{NextProtoTLS},
  79. }
  80. var onlyServer, quiet, framerReuseFrames bool
  81. h2server := new(Server)
  82. for _, opt := range opts {
  83. switch v := opt.(type) {
  84. case func(*tls.Config):
  85. v(tlsConfig)
  86. case func(*httptest.Server):
  87. v(ts)
  88. case func(*Server):
  89. v(h2server)
  90. case serverTesterOpt:
  91. switch v {
  92. case optOnlyServer:
  93. onlyServer = true
  94. case optQuiet:
  95. quiet = true
  96. case optFramerReuseFrames:
  97. framerReuseFrames = true
  98. }
  99. case func(net.Conn, http.ConnState):
  100. ts.Config.ConnState = v
  101. default:
  102. t.Fatalf("unknown newServerTester option type %T", v)
  103. }
  104. }
  105. ConfigureServer(ts.Config, h2server)
  106. st := &serverTester{
  107. t: t,
  108. ts: ts,
  109. }
  110. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  111. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  112. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  113. if quiet {
  114. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  115. } else {
  116. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, &st.serverLogBuf), "", log.LstdFlags)
  117. }
  118. ts.StartTLS()
  119. if VerboseLogs {
  120. t.Logf("Running test server at: %s", ts.URL)
  121. }
  122. testHookGetServerConn = func(v *serverConn) {
  123. st.scMu.Lock()
  124. defer st.scMu.Unlock()
  125. st.sc = v
  126. }
  127. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  128. if !onlyServer {
  129. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  130. if err != nil {
  131. t.Fatal(err)
  132. }
  133. st.cc = cc
  134. st.fr = NewFramer(cc, cc)
  135. if framerReuseFrames {
  136. st.fr.SetReuseFrames()
  137. }
  138. if !logFrameReads && !logFrameWrites {
  139. st.fr.debugReadLoggerf = func(m string, v ...interface{}) {
  140. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  141. st.frameReadLogMu.Lock()
  142. fmt.Fprintf(&st.frameReadLogBuf, m, v...)
  143. st.frameReadLogMu.Unlock()
  144. }
  145. st.fr.debugWriteLoggerf = func(m string, v ...interface{}) {
  146. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  147. st.frameWriteLogMu.Lock()
  148. fmt.Fprintf(&st.frameWriteLogBuf, m, v...)
  149. st.frameWriteLogMu.Unlock()
  150. }
  151. st.fr.logReads = true
  152. st.fr.logWrites = true
  153. }
  154. }
  155. return st
  156. }
  157. func (st *serverTester) closeConn() {
  158. st.scMu.Lock()
  159. defer st.scMu.Unlock()
  160. st.sc.conn.Close()
  161. }
  162. func (st *serverTester) addLogFilter(phrase string) {
  163. st.logFilter = append(st.logFilter, phrase)
  164. }
  165. func (st *serverTester) stream(id uint32) *stream {
  166. ch := make(chan *stream, 1)
  167. st.sc.serveMsgCh <- func(int) {
  168. ch <- st.sc.streams[id]
  169. }
  170. return <-ch
  171. }
  172. func (st *serverTester) streamState(id uint32) streamState {
  173. ch := make(chan streamState, 1)
  174. st.sc.serveMsgCh <- func(int) {
  175. state, _ := st.sc.state(id)
  176. ch <- state
  177. }
  178. return <-ch
  179. }
  180. // loopNum reports how many times this conn's select loop has gone around.
  181. func (st *serverTester) loopNum() int {
  182. lastc := make(chan int, 1)
  183. st.sc.serveMsgCh <- func(loopNum int) {
  184. lastc <- loopNum
  185. }
  186. return <-lastc
  187. }
  188. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  189. // The heuristic is that the server connection's serve loop must schedule
  190. // 50 times in a row without any channel sends or receives occurring.
  191. func (st *serverTester) awaitIdle() {
  192. remain := 50
  193. last := st.loopNum()
  194. for remain > 0 {
  195. n := st.loopNum()
  196. if n == last+1 {
  197. remain--
  198. } else {
  199. remain = 50
  200. }
  201. last = n
  202. }
  203. }
  204. func (st *serverTester) Close() {
  205. if st.t.Failed() {
  206. st.frameReadLogMu.Lock()
  207. if st.frameReadLogBuf.Len() > 0 {
  208. st.t.Logf("Framer read log:\n%s", st.frameReadLogBuf.String())
  209. }
  210. st.frameReadLogMu.Unlock()
  211. st.frameWriteLogMu.Lock()
  212. if st.frameWriteLogBuf.Len() > 0 {
  213. st.t.Logf("Framer write log:\n%s", st.frameWriteLogBuf.String())
  214. }
  215. st.frameWriteLogMu.Unlock()
  216. // If we failed already (and are likely in a Fatal,
  217. // unwindowing), force close the connection, so the
  218. // httptest.Server doesn't wait forever for the conn
  219. // to close.
  220. if st.cc != nil {
  221. st.cc.Close()
  222. }
  223. }
  224. st.ts.Close()
  225. if st.cc != nil {
  226. st.cc.Close()
  227. }
  228. log.SetOutput(os.Stderr)
  229. }
  230. // greet initiates the client's HTTP/2 connection into a state where
  231. // frames may be sent.
  232. func (st *serverTester) greet() {
  233. st.greetAndCheckSettings(func(Setting) error { return nil })
  234. }
  235. func (st *serverTester) greetAndCheckSettings(checkSetting func(s Setting) error) {
  236. st.writePreface()
  237. st.writeInitialSettings()
  238. st.wantSettings().ForeachSetting(checkSetting)
  239. st.writeSettingsAck()
  240. // The initial WINDOW_UPDATE and SETTINGS ACK can come in any order.
  241. var gotSettingsAck bool
  242. var gotWindowUpdate bool
  243. for i := 0; i < 2; i++ {
  244. f, err := st.readFrame()
  245. if err != nil {
  246. st.t.Fatal(err)
  247. }
  248. switch f := f.(type) {
  249. case *SettingsFrame:
  250. if !f.Header().Flags.Has(FlagSettingsAck) {
  251. st.t.Fatal("Settings Frame didn't have ACK set")
  252. }
  253. gotSettingsAck = true
  254. case *WindowUpdateFrame:
  255. if f.FrameHeader.StreamID != 0 {
  256. st.t.Fatalf("WindowUpdate StreamID = %d; want 0", f.FrameHeader.StreamID)
  257. }
  258. incr := uint32((&Server{}).initialConnRecvWindowSize() - initialWindowSize)
  259. if f.Increment != incr {
  260. st.t.Fatalf("WindowUpdate increment = %d; want %d", f.Increment, incr)
  261. }
  262. gotWindowUpdate = true
  263. default:
  264. st.t.Fatalf("Wanting a settings ACK or window update, received a %T", f)
  265. }
  266. }
  267. if !gotSettingsAck {
  268. st.t.Fatalf("Didn't get a settings ACK")
  269. }
  270. if !gotWindowUpdate {
  271. st.t.Fatalf("Didn't get a window update")
  272. }
  273. }
  274. func (st *serverTester) writePreface() {
  275. n, err := st.cc.Write(clientPreface)
  276. if err != nil {
  277. st.t.Fatalf("Error writing client preface: %v", err)
  278. }
  279. if n != len(clientPreface) {
  280. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  281. }
  282. }
  283. func (st *serverTester) writeInitialSettings() {
  284. if err := st.fr.WriteSettings(); err != nil {
  285. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  286. }
  287. }
  288. func (st *serverTester) writeSettingsAck() {
  289. if err := st.fr.WriteSettingsAck(); err != nil {
  290. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  291. }
  292. }
  293. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  294. if err := st.fr.WriteHeaders(p); err != nil {
  295. st.t.Fatalf("Error writing HEADERS: %v", err)
  296. }
  297. }
  298. func (st *serverTester) writePriority(id uint32, p PriorityParam) {
  299. if err := st.fr.WritePriority(id, p); err != nil {
  300. st.t.Fatalf("Error writing PRIORITY: %v", err)
  301. }
  302. }
  303. func (st *serverTester) encodeHeaderField(k, v string) {
  304. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  305. if err != nil {
  306. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  307. }
  308. }
  309. // encodeHeaderRaw is the magic-free version of encodeHeader.
  310. // It takes 0 or more (k, v) pairs and encodes them.
  311. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  312. if len(headers)%2 == 1 {
  313. panic("odd number of kv args")
  314. }
  315. st.headerBuf.Reset()
  316. for len(headers) > 0 {
  317. k, v := headers[0], headers[1]
  318. st.encodeHeaderField(k, v)
  319. headers = headers[2:]
  320. }
  321. return st.headerBuf.Bytes()
  322. }
  323. // encodeHeader encodes headers and returns their HPACK bytes. headers
  324. // must contain an even number of key/value pairs. There may be
  325. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  326. // :scheme headers default to GET, / and https. The :authority header
  327. // defaults to st.ts.Listener.Addr().
  328. func (st *serverTester) encodeHeader(headers ...string) []byte {
  329. if len(headers)%2 == 1 {
  330. panic("odd number of kv args")
  331. }
  332. st.headerBuf.Reset()
  333. defaultAuthority := st.ts.Listener.Addr().String()
  334. if len(headers) == 0 {
  335. // Fast path, mostly for benchmarks, so test code doesn't pollute
  336. // profiles when we're looking to improve server allocations.
  337. st.encodeHeaderField(":method", "GET")
  338. st.encodeHeaderField(":scheme", "https")
  339. st.encodeHeaderField(":authority", defaultAuthority)
  340. st.encodeHeaderField(":path", "/")
  341. return st.headerBuf.Bytes()
  342. }
  343. if len(headers) == 2 && headers[0] == ":method" {
  344. // Another fast path for benchmarks.
  345. st.encodeHeaderField(":method", headers[1])
  346. st.encodeHeaderField(":scheme", "https")
  347. st.encodeHeaderField(":authority", defaultAuthority)
  348. st.encodeHeaderField(":path", "/")
  349. return st.headerBuf.Bytes()
  350. }
  351. pseudoCount := map[string]int{}
  352. keys := []string{":method", ":scheme", ":authority", ":path"}
  353. vals := map[string][]string{
  354. ":method": {"GET"},
  355. ":scheme": {"https"},
  356. ":authority": {defaultAuthority},
  357. ":path": {"/"},
  358. }
  359. for len(headers) > 0 {
  360. k, v := headers[0], headers[1]
  361. headers = headers[2:]
  362. if _, ok := vals[k]; !ok {
  363. keys = append(keys, k)
  364. }
  365. if strings.HasPrefix(k, ":") {
  366. pseudoCount[k]++
  367. if pseudoCount[k] == 1 {
  368. vals[k] = []string{v}
  369. } else {
  370. // Allows testing of invalid headers w/ dup pseudo fields.
  371. vals[k] = append(vals[k], v)
  372. }
  373. } else {
  374. vals[k] = append(vals[k], v)
  375. }
  376. }
  377. for _, k := range keys {
  378. for _, v := range vals[k] {
  379. st.encodeHeaderField(k, v)
  380. }
  381. }
  382. return st.headerBuf.Bytes()
  383. }
  384. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  385. func (st *serverTester) bodylessReq1(headers ...string) {
  386. st.writeHeaders(HeadersFrameParam{
  387. StreamID: 1, // clients send odd numbers
  388. BlockFragment: st.encodeHeader(headers...),
  389. EndStream: true,
  390. EndHeaders: true,
  391. })
  392. }
  393. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  394. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  395. st.t.Fatalf("Error writing DATA: %v", err)
  396. }
  397. }
  398. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  399. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  400. st.t.Fatalf("Error writing DATA: %v", err)
  401. }
  402. }
  403. func readFrameTimeout(fr *Framer, wait time.Duration) (Frame, error) {
  404. ch := make(chan interface{}, 1)
  405. go func() {
  406. fr, err := fr.ReadFrame()
  407. if err != nil {
  408. ch <- err
  409. } else {
  410. ch <- fr
  411. }
  412. }()
  413. t := time.NewTimer(wait)
  414. select {
  415. case v := <-ch:
  416. t.Stop()
  417. if fr, ok := v.(Frame); ok {
  418. return fr, nil
  419. }
  420. return nil, v.(error)
  421. case <-t.C:
  422. return nil, errors.New("timeout waiting for frame")
  423. }
  424. }
  425. func (st *serverTester) readFrame() (Frame, error) {
  426. return readFrameTimeout(st.fr, 2*time.Second)
  427. }
  428. func (st *serverTester) wantHeaders() *HeadersFrame {
  429. f, err := st.readFrame()
  430. if err != nil {
  431. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  432. }
  433. hf, ok := f.(*HeadersFrame)
  434. if !ok {
  435. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  436. }
  437. return hf
  438. }
  439. func (st *serverTester) wantContinuation() *ContinuationFrame {
  440. f, err := st.readFrame()
  441. if err != nil {
  442. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  443. }
  444. cf, ok := f.(*ContinuationFrame)
  445. if !ok {
  446. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  447. }
  448. return cf
  449. }
  450. func (st *serverTester) wantData() *DataFrame {
  451. f, err := st.readFrame()
  452. if err != nil {
  453. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  454. }
  455. df, ok := f.(*DataFrame)
  456. if !ok {
  457. st.t.Fatalf("got a %T; want *DataFrame", f)
  458. }
  459. return df
  460. }
  461. func (st *serverTester) wantSettings() *SettingsFrame {
  462. f, err := st.readFrame()
  463. if err != nil {
  464. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  465. }
  466. sf, ok := f.(*SettingsFrame)
  467. if !ok {
  468. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  469. }
  470. return sf
  471. }
  472. func (st *serverTester) wantPing() *PingFrame {
  473. f, err := st.readFrame()
  474. if err != nil {
  475. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  476. }
  477. pf, ok := f.(*PingFrame)
  478. if !ok {
  479. st.t.Fatalf("got a %T; want *PingFrame", f)
  480. }
  481. return pf
  482. }
  483. func (st *serverTester) wantGoAway() *GoAwayFrame {
  484. f, err := st.readFrame()
  485. if err != nil {
  486. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  487. }
  488. gf, ok := f.(*GoAwayFrame)
  489. if !ok {
  490. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  491. }
  492. return gf
  493. }
  494. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  495. f, err := st.readFrame()
  496. if err != nil {
  497. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  498. }
  499. rs, ok := f.(*RSTStreamFrame)
  500. if !ok {
  501. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  502. }
  503. if rs.FrameHeader.StreamID != streamID {
  504. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  505. }
  506. if rs.ErrCode != errCode {
  507. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  508. }
  509. }
  510. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  511. f, err := st.readFrame()
  512. if err != nil {
  513. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  514. }
  515. wu, ok := f.(*WindowUpdateFrame)
  516. if !ok {
  517. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  518. }
  519. if wu.FrameHeader.StreamID != streamID {
  520. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  521. }
  522. if wu.Increment != incr {
  523. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  524. }
  525. }
  526. func (st *serverTester) wantSettingsAck() {
  527. f, err := st.readFrame()
  528. if err != nil {
  529. st.t.Fatal(err)
  530. }
  531. sf, ok := f.(*SettingsFrame)
  532. if !ok {
  533. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  534. }
  535. if !sf.Header().Flags.Has(FlagSettingsAck) {
  536. st.t.Fatal("Settings Frame didn't have ACK set")
  537. }
  538. }
  539. func (st *serverTester) wantPushPromise() *PushPromiseFrame {
  540. f, err := st.readFrame()
  541. if err != nil {
  542. st.t.Fatal(err)
  543. }
  544. ppf, ok := f.(*PushPromiseFrame)
  545. if !ok {
  546. st.t.Fatalf("Wanted PushPromise, received %T", ppf)
  547. }
  548. return ppf
  549. }
  550. func TestServer(t *testing.T) {
  551. gotReq := make(chan bool, 1)
  552. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  553. w.Header().Set("Foo", "Bar")
  554. gotReq <- true
  555. })
  556. defer st.Close()
  557. covers("3.5", `
  558. The server connection preface consists of a potentially empty
  559. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  560. server sends in the HTTP/2 connection.
  561. `)
  562. st.greet()
  563. st.writeHeaders(HeadersFrameParam{
  564. StreamID: 1, // clients send odd numbers
  565. BlockFragment: st.encodeHeader(),
  566. EndStream: true, // no DATA frames
  567. EndHeaders: true,
  568. })
  569. select {
  570. case <-gotReq:
  571. case <-time.After(2 * time.Second):
  572. t.Error("timeout waiting for request")
  573. }
  574. }
  575. func TestServer_Request_Get(t *testing.T) {
  576. testServerRequest(t, func(st *serverTester) {
  577. st.writeHeaders(HeadersFrameParam{
  578. StreamID: 1, // clients send odd numbers
  579. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  580. EndStream: true, // no DATA frames
  581. EndHeaders: true,
  582. })
  583. }, func(r *http.Request) {
  584. if r.Method != "GET" {
  585. t.Errorf("Method = %q; want GET", r.Method)
  586. }
  587. if r.URL.Path != "/" {
  588. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  589. }
  590. if r.ContentLength != 0 {
  591. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  592. }
  593. if r.Close {
  594. t.Error("Close = true; want false")
  595. }
  596. if !strings.Contains(r.RemoteAddr, ":") {
  597. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  598. }
  599. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  600. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  601. }
  602. wantHeader := http.Header{
  603. "Foo-Bar": []string{"some-value"},
  604. }
  605. if !reflect.DeepEqual(r.Header, wantHeader) {
  606. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  607. }
  608. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  609. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  610. }
  611. })
  612. }
  613. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  614. testServerRequest(t, func(st *serverTester) {
  615. st.writeHeaders(HeadersFrameParam{
  616. StreamID: 1, // clients send odd numbers
  617. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  618. EndStream: true, // no DATA frames
  619. EndHeaders: true,
  620. })
  621. }, func(r *http.Request) {
  622. if r.RequestURI != "/%2f/" {
  623. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  624. }
  625. if r.URL.Path != "///" {
  626. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  627. }
  628. })
  629. }
  630. // TODO: add a test with EndStream=true on the HEADERS but setting a
  631. // Content-Length anyway. Should we just omit it and force it to
  632. // zero?
  633. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  634. testServerRequest(t, func(st *serverTester) {
  635. st.writeHeaders(HeadersFrameParam{
  636. StreamID: 1, // clients send odd numbers
  637. BlockFragment: st.encodeHeader(":method", "POST"),
  638. EndStream: true,
  639. EndHeaders: true,
  640. })
  641. }, func(r *http.Request) {
  642. if r.Method != "POST" {
  643. t.Errorf("Method = %q; want POST", r.Method)
  644. }
  645. if r.ContentLength != 0 {
  646. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  647. }
  648. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  649. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  650. }
  651. })
  652. }
  653. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  654. testBodyContents(t, -1, "", func(st *serverTester) {
  655. st.writeHeaders(HeadersFrameParam{
  656. StreamID: 1, // clients send odd numbers
  657. BlockFragment: st.encodeHeader(":method", "POST"),
  658. EndStream: false, // to say DATA frames are coming
  659. EndHeaders: true,
  660. })
  661. st.writeData(1, true, nil) // just kidding. empty body.
  662. })
  663. }
  664. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  665. const content = "Some content"
  666. testBodyContents(t, -1, content, func(st *serverTester) {
  667. st.writeHeaders(HeadersFrameParam{
  668. StreamID: 1, // clients send odd numbers
  669. BlockFragment: st.encodeHeader(":method", "POST"),
  670. EndStream: false, // to say DATA frames are coming
  671. EndHeaders: true,
  672. })
  673. st.writeData(1, true, []byte(content))
  674. })
  675. }
  676. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  677. const content = "Some content"
  678. testBodyContents(t, -1, content, func(st *serverTester) {
  679. st.writeHeaders(HeadersFrameParam{
  680. StreamID: 1, // clients send odd numbers
  681. BlockFragment: st.encodeHeader(":method", "POST"),
  682. EndStream: false, // to say DATA frames are coming
  683. EndHeaders: true,
  684. })
  685. st.writeData(1, false, []byte(content[:5]))
  686. st.writeData(1, true, []byte(content[5:]))
  687. })
  688. }
  689. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  690. const content = "Some content"
  691. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  692. st.writeHeaders(HeadersFrameParam{
  693. StreamID: 1, // clients send odd numbers
  694. BlockFragment: st.encodeHeader(
  695. ":method", "POST",
  696. "content-length", strconv.Itoa(len(content)),
  697. ),
  698. EndStream: false, // to say DATA frames are coming
  699. EndHeaders: true,
  700. })
  701. st.writeData(1, true, []byte(content))
  702. })
  703. }
  704. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  705. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  706. func(st *serverTester) {
  707. st.writeHeaders(HeadersFrameParam{
  708. StreamID: 1, // clients send odd numbers
  709. BlockFragment: st.encodeHeader(
  710. ":method", "POST",
  711. "content-length", "3",
  712. ),
  713. EndStream: false, // to say DATA frames are coming
  714. EndHeaders: true,
  715. })
  716. st.writeData(1, true, []byte("12"))
  717. })
  718. }
  719. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  720. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  721. func(st *serverTester) {
  722. st.writeHeaders(HeadersFrameParam{
  723. StreamID: 1, // clients send odd numbers
  724. BlockFragment: st.encodeHeader(
  725. ":method", "POST",
  726. "content-length", "4",
  727. ),
  728. EndStream: false, // to say DATA frames are coming
  729. EndHeaders: true,
  730. })
  731. st.writeData(1, true, []byte("12345"))
  732. })
  733. }
  734. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  735. testServerRequest(t, write, func(r *http.Request) {
  736. if r.Method != "POST" {
  737. t.Errorf("Method = %q; want POST", r.Method)
  738. }
  739. if r.ContentLength != wantContentLength {
  740. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  741. }
  742. all, err := ioutil.ReadAll(r.Body)
  743. if err != nil {
  744. t.Fatal(err)
  745. }
  746. if string(all) != wantBody {
  747. t.Errorf("Read = %q; want %q", all, wantBody)
  748. }
  749. if err := r.Body.Close(); err != nil {
  750. t.Fatalf("Close: %v", err)
  751. }
  752. })
  753. }
  754. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  755. testServerRequest(t, write, func(r *http.Request) {
  756. if r.Method != "POST" {
  757. t.Errorf("Method = %q; want POST", r.Method)
  758. }
  759. if r.ContentLength != wantContentLength {
  760. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  761. }
  762. all, err := ioutil.ReadAll(r.Body)
  763. if err == nil {
  764. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  765. wantReadError, all)
  766. }
  767. if !strings.Contains(err.Error(), wantReadError) {
  768. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  769. }
  770. if err := r.Body.Close(); err != nil {
  771. t.Fatalf("Close: %v", err)
  772. }
  773. })
  774. }
  775. // Using a Host header, instead of :authority
  776. func TestServer_Request_Get_Host(t *testing.T) {
  777. const host = "example.com"
  778. testServerRequest(t, func(st *serverTester) {
  779. st.writeHeaders(HeadersFrameParam{
  780. StreamID: 1, // clients send odd numbers
  781. BlockFragment: st.encodeHeader(":authority", "", "host", host),
  782. EndStream: true,
  783. EndHeaders: true,
  784. })
  785. }, func(r *http.Request) {
  786. if r.Host != host {
  787. t.Errorf("Host = %q; want %q", r.Host, host)
  788. }
  789. })
  790. }
  791. // Using an :authority pseudo-header, instead of Host
  792. func TestServer_Request_Get_Authority(t *testing.T) {
  793. const host = "example.com"
  794. testServerRequest(t, func(st *serverTester) {
  795. st.writeHeaders(HeadersFrameParam{
  796. StreamID: 1, // clients send odd numbers
  797. BlockFragment: st.encodeHeader(":authority", host),
  798. EndStream: true,
  799. EndHeaders: true,
  800. })
  801. }, func(r *http.Request) {
  802. if r.Host != host {
  803. t.Errorf("Host = %q; want %q", r.Host, host)
  804. }
  805. })
  806. }
  807. func TestServer_Request_WithContinuation(t *testing.T) {
  808. wantHeader := http.Header{
  809. "Foo-One": []string{"value-one"},
  810. "Foo-Two": []string{"value-two"},
  811. "Foo-Three": []string{"value-three"},
  812. }
  813. testServerRequest(t, func(st *serverTester) {
  814. fullHeaders := st.encodeHeader(
  815. "foo-one", "value-one",
  816. "foo-two", "value-two",
  817. "foo-three", "value-three",
  818. )
  819. remain := fullHeaders
  820. chunks := 0
  821. for len(remain) > 0 {
  822. const maxChunkSize = 5
  823. chunk := remain
  824. if len(chunk) > maxChunkSize {
  825. chunk = chunk[:maxChunkSize]
  826. }
  827. remain = remain[len(chunk):]
  828. if chunks == 0 {
  829. st.writeHeaders(HeadersFrameParam{
  830. StreamID: 1, // clients send odd numbers
  831. BlockFragment: chunk,
  832. EndStream: true, // no DATA frames
  833. EndHeaders: false, // we'll have continuation frames
  834. })
  835. } else {
  836. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  837. if err != nil {
  838. t.Fatal(err)
  839. }
  840. }
  841. chunks++
  842. }
  843. if chunks < 2 {
  844. t.Fatal("too few chunks")
  845. }
  846. }, func(r *http.Request) {
  847. if !reflect.DeepEqual(r.Header, wantHeader) {
  848. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  849. }
  850. })
  851. }
  852. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  853. func TestServer_Request_CookieConcat(t *testing.T) {
  854. const host = "example.com"
  855. testServerRequest(t, func(st *serverTester) {
  856. st.bodylessReq1(
  857. ":authority", host,
  858. "cookie", "a=b",
  859. "cookie", "c=d",
  860. "cookie", "e=f",
  861. )
  862. }, func(r *http.Request) {
  863. const want = "a=b; c=d; e=f"
  864. if got := r.Header.Get("Cookie"); got != want {
  865. t.Errorf("Cookie = %q; want %q", got, want)
  866. }
  867. })
  868. }
  869. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  870. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  871. }
  872. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  873. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  874. }
  875. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  876. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  877. }
  878. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  879. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  880. }
  881. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  882. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  883. }
  884. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  885. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  886. }
  887. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  888. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  889. }
  890. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  891. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  892. }
  893. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  894. // 8.1.2.3 Request Pseudo-Header Fields
  895. // "All HTTP/2 requests MUST include exactly one valid value" ...
  896. testRejectRequest(t, func(st *serverTester) {
  897. st.addLogFilter("duplicate pseudo-header")
  898. st.bodylessReq1(":method", "GET", ":method", "POST")
  899. })
  900. }
  901. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  902. // 8.1.2.3 Request Pseudo-Header Fields
  903. // "All pseudo-header fields MUST appear in the header block
  904. // before regular header fields. Any request or response that
  905. // contains a pseudo-header field that appears in a header
  906. // block after a regular header field MUST be treated as
  907. // malformed (Section 8.1.2.6)."
  908. testRejectRequest(t, func(st *serverTester) {
  909. st.addLogFilter("pseudo-header after regular header")
  910. var buf bytes.Buffer
  911. enc := hpack.NewEncoder(&buf)
  912. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  913. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  914. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  915. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  916. st.writeHeaders(HeadersFrameParam{
  917. StreamID: 1, // clients send odd numbers
  918. BlockFragment: buf.Bytes(),
  919. EndStream: true,
  920. EndHeaders: true,
  921. })
  922. })
  923. }
  924. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  925. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  926. }
  927. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  928. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  929. }
  930. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  931. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  932. }
  933. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  934. testRejectRequest(t, func(st *serverTester) {
  935. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  936. st.bodylessReq1(":unknown_thing", "")
  937. })
  938. }
  939. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  940. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  941. t.Error("server request made it to handler; should've been rejected")
  942. })
  943. defer st.Close()
  944. st.greet()
  945. send(st)
  946. st.wantRSTStream(1, ErrCodeProtocol)
  947. }
  948. func testRejectRequestWithProtocolError(t *testing.T, send func(*serverTester)) {
  949. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  950. t.Error("server request made it to handler; should've been rejected")
  951. }, optQuiet)
  952. defer st.Close()
  953. st.greet()
  954. send(st)
  955. gf := st.wantGoAway()
  956. if gf.ErrCode != ErrCodeProtocol {
  957. t.Errorf("err code = %v; want %v", gf.ErrCode, ErrCodeProtocol)
  958. }
  959. }
  960. // Section 5.1, on idle connections: "Receiving any frame other than
  961. // HEADERS or PRIORITY on a stream in this state MUST be treated as a
  962. // connection error (Section 5.4.1) of type PROTOCOL_ERROR."
  963. func TestRejectFrameOnIdle_WindowUpdate(t *testing.T) {
  964. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  965. st.fr.WriteWindowUpdate(123, 456)
  966. })
  967. }
  968. func TestRejectFrameOnIdle_Data(t *testing.T) {
  969. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  970. st.fr.WriteData(123, true, nil)
  971. })
  972. }
  973. func TestRejectFrameOnIdle_RSTStream(t *testing.T) {
  974. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  975. st.fr.WriteRSTStream(123, ErrCodeCancel)
  976. })
  977. }
  978. func TestServer_Request_Connect(t *testing.T) {
  979. testServerRequest(t, func(st *serverTester) {
  980. st.writeHeaders(HeadersFrameParam{
  981. StreamID: 1,
  982. BlockFragment: st.encodeHeaderRaw(
  983. ":method", "CONNECT",
  984. ":authority", "example.com:123",
  985. ),
  986. EndStream: true,
  987. EndHeaders: true,
  988. })
  989. }, func(r *http.Request) {
  990. if g, w := r.Method, "CONNECT"; g != w {
  991. t.Errorf("Method = %q; want %q", g, w)
  992. }
  993. if g, w := r.RequestURI, "example.com:123"; g != w {
  994. t.Errorf("RequestURI = %q; want %q", g, w)
  995. }
  996. if g, w := r.URL.Host, "example.com:123"; g != w {
  997. t.Errorf("URL.Host = %q; want %q", g, w)
  998. }
  999. })
  1000. }
  1001. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  1002. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1003. st.writeHeaders(HeadersFrameParam{
  1004. StreamID: 1,
  1005. BlockFragment: st.encodeHeaderRaw(
  1006. ":method", "CONNECT",
  1007. ":authority", "example.com:123",
  1008. ":path", "/bogus",
  1009. ),
  1010. EndStream: true,
  1011. EndHeaders: true,
  1012. })
  1013. })
  1014. }
  1015. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  1016. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1017. st.writeHeaders(HeadersFrameParam{
  1018. StreamID: 1,
  1019. BlockFragment: st.encodeHeaderRaw(
  1020. ":method", "CONNECT",
  1021. ":authority", "example.com:123",
  1022. ":scheme", "https",
  1023. ),
  1024. EndStream: true,
  1025. EndHeaders: true,
  1026. })
  1027. })
  1028. }
  1029. func TestServer_Ping(t *testing.T) {
  1030. st := newServerTester(t, nil)
  1031. defer st.Close()
  1032. st.greet()
  1033. // Server should ignore this one, since it has ACK set.
  1034. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  1035. if err := st.fr.WritePing(true, ackPingData); err != nil {
  1036. t.Fatal(err)
  1037. }
  1038. // But the server should reply to this one, since ACK is false.
  1039. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  1040. if err := st.fr.WritePing(false, pingData); err != nil {
  1041. t.Fatal(err)
  1042. }
  1043. pf := st.wantPing()
  1044. if !pf.Flags.Has(FlagPingAck) {
  1045. t.Error("response ping doesn't have ACK set")
  1046. }
  1047. if pf.Data != pingData {
  1048. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  1049. }
  1050. }
  1051. func TestServer_RejectsLargeFrames(t *testing.T) {
  1052. if runtime.GOOS == "windows" {
  1053. t.Skip("see golang.org/issue/13434")
  1054. }
  1055. st := newServerTester(t, nil)
  1056. defer st.Close()
  1057. st.greet()
  1058. // Write too large of a frame (too large by one byte)
  1059. // We ignore the return value because it's expected that the server
  1060. // will only read the first 9 bytes (the headre) and then disconnect.
  1061. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  1062. gf := st.wantGoAway()
  1063. if gf.ErrCode != ErrCodeFrameSize {
  1064. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  1065. }
  1066. if st.serverLogBuf.Len() != 0 {
  1067. // Previously we spun here for a bit until the GOAWAY disconnect
  1068. // timer fired, logging while we fired.
  1069. t.Errorf("unexpected server output: %.500s\n", st.serverLogBuf.Bytes())
  1070. }
  1071. }
  1072. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  1073. puppet := newHandlerPuppet()
  1074. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1075. puppet.act(w, r)
  1076. })
  1077. defer st.Close()
  1078. defer puppet.done()
  1079. st.greet()
  1080. st.writeHeaders(HeadersFrameParam{
  1081. StreamID: 1, // clients send odd numbers
  1082. BlockFragment: st.encodeHeader(":method", "POST"),
  1083. EndStream: false, // data coming
  1084. EndHeaders: true,
  1085. })
  1086. st.writeData(1, false, []byte("abcdef"))
  1087. puppet.do(readBodyHandler(t, "abc"))
  1088. st.wantWindowUpdate(0, 3)
  1089. st.wantWindowUpdate(1, 3)
  1090. puppet.do(readBodyHandler(t, "def"))
  1091. st.wantWindowUpdate(0, 3)
  1092. st.wantWindowUpdate(1, 3)
  1093. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  1094. puppet.do(readBodyHandler(t, "ghi"))
  1095. puppet.do(readBodyHandler(t, "jkl"))
  1096. st.wantWindowUpdate(0, 3)
  1097. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  1098. }
  1099. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  1100. // See golang.org/issue/16556
  1101. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  1102. puppet := newHandlerPuppet()
  1103. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1104. puppet.act(w, r)
  1105. })
  1106. defer st.Close()
  1107. defer puppet.done()
  1108. st.greet()
  1109. st.writeHeaders(HeadersFrameParam{
  1110. StreamID: 1,
  1111. BlockFragment: st.encodeHeader(":method", "POST"),
  1112. EndStream: false,
  1113. EndHeaders: true,
  1114. })
  1115. st.writeDataPadded(1, false, []byte("abcdef"), []byte{0, 0, 0, 0})
  1116. // Expect to immediately get our 5 bytes of padding back for
  1117. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1118. st.wantWindowUpdate(0, 5)
  1119. st.wantWindowUpdate(1, 5)
  1120. puppet.do(readBodyHandler(t, "abc"))
  1121. st.wantWindowUpdate(0, 3)
  1122. st.wantWindowUpdate(1, 3)
  1123. puppet.do(readBodyHandler(t, "def"))
  1124. st.wantWindowUpdate(0, 3)
  1125. st.wantWindowUpdate(1, 3)
  1126. }
  1127. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1128. st := newServerTester(t, nil)
  1129. defer st.Close()
  1130. st.greet()
  1131. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1132. t.Fatal(err)
  1133. }
  1134. gf := st.wantGoAway()
  1135. if gf.ErrCode != ErrCodeFlowControl {
  1136. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1137. }
  1138. if gf.LastStreamID != 0 {
  1139. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1140. }
  1141. }
  1142. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1143. inHandler := make(chan bool)
  1144. blockHandler := make(chan bool)
  1145. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1146. inHandler <- true
  1147. <-blockHandler
  1148. })
  1149. defer st.Close()
  1150. defer close(blockHandler)
  1151. st.greet()
  1152. st.writeHeaders(HeadersFrameParam{
  1153. StreamID: 1,
  1154. BlockFragment: st.encodeHeader(":method", "POST"),
  1155. EndStream: false, // keep it open
  1156. EndHeaders: true,
  1157. })
  1158. <-inHandler
  1159. // Send a bogus window update:
  1160. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1161. t.Fatal(err)
  1162. }
  1163. st.wantRSTStream(1, ErrCodeFlowControl)
  1164. }
  1165. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1166. // then runs fn once in the handler, and verifies that the error returned from
  1167. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1168. func testServerPostUnblock(t *testing.T,
  1169. handler func(http.ResponseWriter, *http.Request) error,
  1170. fn func(*serverTester),
  1171. checkErr func(error),
  1172. otherHeaders ...string) {
  1173. inHandler := make(chan bool)
  1174. errc := make(chan error, 1)
  1175. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1176. inHandler <- true
  1177. errc <- handler(w, r)
  1178. })
  1179. defer st.Close()
  1180. st.greet()
  1181. st.writeHeaders(HeadersFrameParam{
  1182. StreamID: 1,
  1183. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1184. EndStream: false, // keep it open
  1185. EndHeaders: true,
  1186. })
  1187. <-inHandler
  1188. fn(st)
  1189. select {
  1190. case err := <-errc:
  1191. if checkErr != nil {
  1192. checkErr(err)
  1193. }
  1194. case <-time.After(5 * time.Second):
  1195. t.Fatal("timeout waiting for Handler to return")
  1196. }
  1197. }
  1198. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1199. testServerPostUnblock(t,
  1200. func(w http.ResponseWriter, r *http.Request) (err error) {
  1201. _, err = r.Body.Read(make([]byte, 1))
  1202. return
  1203. },
  1204. func(st *serverTester) {
  1205. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1206. t.Fatal(err)
  1207. }
  1208. },
  1209. func(err error) {
  1210. want := StreamError{StreamID: 0x1, Code: 0x8}
  1211. if !reflect.DeepEqual(err, want) {
  1212. t.Errorf("Read error = %v; want %v", err, want)
  1213. }
  1214. },
  1215. )
  1216. }
  1217. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1218. // Run this test a bunch, because it doesn't always
  1219. // deadlock. But with a bunch, it did.
  1220. n := 50
  1221. if testing.Short() {
  1222. n = 5
  1223. }
  1224. for i := 0; i < n; i++ {
  1225. testServer_RSTStream_Unblocks_Header_Write(t)
  1226. }
  1227. }
  1228. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1229. inHandler := make(chan bool, 1)
  1230. unblockHandler := make(chan bool, 1)
  1231. headerWritten := make(chan bool, 1)
  1232. wroteRST := make(chan bool, 1)
  1233. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1234. inHandler <- true
  1235. <-wroteRST
  1236. w.Header().Set("foo", "bar")
  1237. w.WriteHeader(200)
  1238. w.(http.Flusher).Flush()
  1239. headerWritten <- true
  1240. <-unblockHandler
  1241. })
  1242. defer st.Close()
  1243. st.greet()
  1244. st.writeHeaders(HeadersFrameParam{
  1245. StreamID: 1,
  1246. BlockFragment: st.encodeHeader(":method", "POST"),
  1247. EndStream: false, // keep it open
  1248. EndHeaders: true,
  1249. })
  1250. <-inHandler
  1251. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1252. t.Fatal(err)
  1253. }
  1254. wroteRST <- true
  1255. st.awaitIdle()
  1256. select {
  1257. case <-headerWritten:
  1258. case <-time.After(2 * time.Second):
  1259. t.Error("timeout waiting for header write")
  1260. }
  1261. unblockHandler <- true
  1262. }
  1263. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1264. testServerPostUnblock(t,
  1265. func(w http.ResponseWriter, r *http.Request) (err error) {
  1266. _, err = r.Body.Read(make([]byte, 1))
  1267. return
  1268. },
  1269. func(st *serverTester) { st.cc.Close() },
  1270. func(err error) {
  1271. if err == nil {
  1272. t.Error("unexpected nil error from Request.Body.Read")
  1273. }
  1274. },
  1275. )
  1276. }
  1277. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1278. <-w.(http.CloseNotifier).CloseNotify()
  1279. return nil
  1280. }
  1281. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1282. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1283. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1284. t.Fatal(err)
  1285. }
  1286. }, nil)
  1287. }
  1288. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1289. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1290. }
  1291. // that CloseNotify unblocks after a stream error due to the client's
  1292. // problem that's unrelated to them explicitly canceling it (which is
  1293. // TestServer_CloseNotify_After_RSTStream above)
  1294. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1295. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1296. // data longer than declared Content-Length => stream error
  1297. st.writeData(1, true, []byte("1234"))
  1298. }, nil, "content-length", "3")
  1299. }
  1300. func TestServer_StateTransitions(t *testing.T) {
  1301. var st *serverTester
  1302. inHandler := make(chan bool)
  1303. writeData := make(chan bool)
  1304. leaveHandler := make(chan bool)
  1305. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1306. inHandler <- true
  1307. if st.stream(1) == nil {
  1308. t.Errorf("nil stream 1 in handler")
  1309. }
  1310. if got, want := st.streamState(1), stateOpen; got != want {
  1311. t.Errorf("in handler, state is %v; want %v", got, want)
  1312. }
  1313. writeData <- true
  1314. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1315. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1316. }
  1317. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1318. t.Errorf("in handler, state is %v; want %v", got, want)
  1319. }
  1320. <-leaveHandler
  1321. })
  1322. st.greet()
  1323. if st.stream(1) != nil {
  1324. t.Fatal("stream 1 should be empty")
  1325. }
  1326. if got := st.streamState(1); got != stateIdle {
  1327. t.Fatalf("stream 1 should be idle; got %v", got)
  1328. }
  1329. st.writeHeaders(HeadersFrameParam{
  1330. StreamID: 1,
  1331. BlockFragment: st.encodeHeader(":method", "POST"),
  1332. EndStream: false, // keep it open
  1333. EndHeaders: true,
  1334. })
  1335. <-inHandler
  1336. <-writeData
  1337. st.writeData(1, true, nil)
  1338. leaveHandler <- true
  1339. hf := st.wantHeaders()
  1340. if !hf.StreamEnded() {
  1341. t.Fatal("expected END_STREAM flag")
  1342. }
  1343. if got, want := st.streamState(1), stateClosed; got != want {
  1344. t.Errorf("at end, state is %v; want %v", got, want)
  1345. }
  1346. if st.stream(1) != nil {
  1347. t.Fatal("at end, stream 1 should be gone")
  1348. }
  1349. }
  1350. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1351. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1352. testServerRejectsConn(t, func(st *serverTester) {
  1353. st.writeHeaders(HeadersFrameParam{
  1354. StreamID: 1,
  1355. BlockFragment: st.encodeHeader(),
  1356. EndStream: true,
  1357. EndHeaders: false,
  1358. })
  1359. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1360. StreamID: 3, // different stream.
  1361. BlockFragment: st.encodeHeader(),
  1362. EndStream: true,
  1363. EndHeaders: true,
  1364. })
  1365. })
  1366. }
  1367. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1368. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1369. testServerRejectsConn(t, func(st *serverTester) {
  1370. st.writeHeaders(HeadersFrameParam{
  1371. StreamID: 1,
  1372. BlockFragment: st.encodeHeader(),
  1373. EndStream: true,
  1374. EndHeaders: false,
  1375. })
  1376. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1377. t.Fatal(err)
  1378. }
  1379. })
  1380. }
  1381. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1382. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1383. testServerRejectsConn(t, func(st *serverTester) {
  1384. st.writeHeaders(HeadersFrameParam{
  1385. StreamID: 1,
  1386. BlockFragment: st.encodeHeader(),
  1387. EndStream: true,
  1388. EndHeaders: true,
  1389. })
  1390. st.wantHeaders()
  1391. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1392. t.Fatal(err)
  1393. }
  1394. })
  1395. }
  1396. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1397. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1398. testServerRejectsConn(t, func(st *serverTester) {
  1399. st.writeHeaders(HeadersFrameParam{
  1400. StreamID: 1,
  1401. BlockFragment: st.encodeHeader(),
  1402. EndStream: true,
  1403. EndHeaders: false,
  1404. })
  1405. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1406. t.Fatal(err)
  1407. }
  1408. })
  1409. }
  1410. // No HEADERS on stream 0.
  1411. func TestServer_Rejects_Headers0(t *testing.T) {
  1412. testServerRejectsConn(t, func(st *serverTester) {
  1413. st.fr.AllowIllegalWrites = true
  1414. st.writeHeaders(HeadersFrameParam{
  1415. StreamID: 0,
  1416. BlockFragment: st.encodeHeader(),
  1417. EndStream: true,
  1418. EndHeaders: true,
  1419. })
  1420. })
  1421. }
  1422. // No CONTINUATION on stream 0.
  1423. func TestServer_Rejects_Continuation0(t *testing.T) {
  1424. testServerRejectsConn(t, func(st *serverTester) {
  1425. st.fr.AllowIllegalWrites = true
  1426. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1427. t.Fatal(err)
  1428. }
  1429. })
  1430. }
  1431. // No PRIORITY on stream 0.
  1432. func TestServer_Rejects_Priority0(t *testing.T) {
  1433. testServerRejectsConn(t, func(st *serverTester) {
  1434. st.fr.AllowIllegalWrites = true
  1435. st.writePriority(0, PriorityParam{StreamDep: 1})
  1436. })
  1437. }
  1438. // No HEADERS frame with a self-dependence.
  1439. func TestServer_Rejects_HeadersSelfDependence(t *testing.T) {
  1440. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1441. st.fr.AllowIllegalWrites = true
  1442. st.writeHeaders(HeadersFrameParam{
  1443. StreamID: 1,
  1444. BlockFragment: st.encodeHeader(),
  1445. EndStream: true,
  1446. EndHeaders: true,
  1447. Priority: PriorityParam{StreamDep: 1},
  1448. })
  1449. })
  1450. }
  1451. // No PRIORTY frame with a self-dependence.
  1452. func TestServer_Rejects_PrioritySelfDependence(t *testing.T) {
  1453. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1454. st.fr.AllowIllegalWrites = true
  1455. st.writePriority(1, PriorityParam{StreamDep: 1})
  1456. })
  1457. }
  1458. func TestServer_Rejects_PushPromise(t *testing.T) {
  1459. testServerRejectsConn(t, func(st *serverTester) {
  1460. pp := PushPromiseParam{
  1461. StreamID: 1,
  1462. PromiseID: 3,
  1463. }
  1464. if err := st.fr.WritePushPromise(pp); err != nil {
  1465. t.Fatal(err)
  1466. }
  1467. })
  1468. }
  1469. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1470. // frame and a server close after the client does something
  1471. // deserving a CONNECTION_ERROR.
  1472. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1473. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1474. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1475. defer st.Close()
  1476. st.greet()
  1477. writeReq(st)
  1478. st.wantGoAway()
  1479. errc := make(chan error, 1)
  1480. go func() {
  1481. fr, err := st.fr.ReadFrame()
  1482. if err == nil {
  1483. err = fmt.Errorf("got frame of type %T", fr)
  1484. }
  1485. errc <- err
  1486. }()
  1487. select {
  1488. case err := <-errc:
  1489. if err != io.EOF {
  1490. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1491. }
  1492. case <-time.After(2 * time.Second):
  1493. t.Error("timeout waiting for disconnect")
  1494. }
  1495. }
  1496. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1497. // error code after a client sends a bogus request.
  1498. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1499. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1500. defer st.Close()
  1501. st.greet()
  1502. writeReq(st)
  1503. st.wantRSTStream(1, code)
  1504. }
  1505. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1506. // write a single request with writeReq, and then verify that the
  1507. // *http.Request is built correctly in checkReq.
  1508. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1509. gotReq := make(chan bool, 1)
  1510. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1511. if r.Body == nil {
  1512. t.Fatal("nil Body")
  1513. }
  1514. checkReq(r)
  1515. gotReq <- true
  1516. })
  1517. defer st.Close()
  1518. st.greet()
  1519. writeReq(st)
  1520. select {
  1521. case <-gotReq:
  1522. case <-time.After(2 * time.Second):
  1523. t.Error("timeout waiting for request")
  1524. }
  1525. }
  1526. func getSlash(st *serverTester) { st.bodylessReq1() }
  1527. func TestServer_Response_NoData(t *testing.T) {
  1528. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1529. // Nothing.
  1530. return nil
  1531. }, func(st *serverTester) {
  1532. getSlash(st)
  1533. hf := st.wantHeaders()
  1534. if !hf.StreamEnded() {
  1535. t.Fatal("want END_STREAM flag")
  1536. }
  1537. if !hf.HeadersEnded() {
  1538. t.Fatal("want END_HEADERS flag")
  1539. }
  1540. })
  1541. }
  1542. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1543. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1544. w.Header().Set("Foo-Bar", "some-value")
  1545. return nil
  1546. }, func(st *serverTester) {
  1547. getSlash(st)
  1548. hf := st.wantHeaders()
  1549. if !hf.StreamEnded() {
  1550. t.Fatal("want END_STREAM flag")
  1551. }
  1552. if !hf.HeadersEnded() {
  1553. t.Fatal("want END_HEADERS flag")
  1554. }
  1555. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1556. wanth := [][2]string{
  1557. {":status", "200"},
  1558. {"foo-bar", "some-value"},
  1559. {"content-length", "0"},
  1560. }
  1561. if !reflect.DeepEqual(goth, wanth) {
  1562. t.Errorf("Got headers %v; want %v", goth, wanth)
  1563. }
  1564. })
  1565. }
  1566. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1567. const msg = "<html>this is HTML."
  1568. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1569. w.Header().Set("Content-Type", "foo/bar")
  1570. io.WriteString(w, msg)
  1571. return nil
  1572. }, func(st *serverTester) {
  1573. getSlash(st)
  1574. hf := st.wantHeaders()
  1575. if hf.StreamEnded() {
  1576. t.Fatal("don't want END_STREAM, expecting data")
  1577. }
  1578. if !hf.HeadersEnded() {
  1579. t.Fatal("want END_HEADERS flag")
  1580. }
  1581. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1582. wanth := [][2]string{
  1583. {":status", "200"},
  1584. {"content-type", "foo/bar"},
  1585. {"content-length", strconv.Itoa(len(msg))},
  1586. }
  1587. if !reflect.DeepEqual(goth, wanth) {
  1588. t.Errorf("Got headers %v; want %v", goth, wanth)
  1589. }
  1590. df := st.wantData()
  1591. if !df.StreamEnded() {
  1592. t.Error("expected DATA to have END_STREAM flag")
  1593. }
  1594. if got := string(df.Data()); got != msg {
  1595. t.Errorf("got DATA %q; want %q", got, msg)
  1596. }
  1597. })
  1598. }
  1599. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1600. const msg = "hi"
  1601. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1602. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1603. io.WriteString(w, msg)
  1604. return nil
  1605. }, func(st *serverTester) {
  1606. getSlash(st)
  1607. hf := st.wantHeaders()
  1608. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1609. wanth := [][2]string{
  1610. {":status", "200"},
  1611. {"content-type", "text/plain; charset=utf-8"},
  1612. {"content-length", strconv.Itoa(len(msg))},
  1613. }
  1614. if !reflect.DeepEqual(goth, wanth) {
  1615. t.Errorf("Got headers %v; want %v", goth, wanth)
  1616. }
  1617. })
  1618. }
  1619. // Header accessed only after the initial write.
  1620. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1621. const msg = "<html>this is HTML."
  1622. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1623. io.WriteString(w, msg)
  1624. w.Header().Set("foo", "should be ignored")
  1625. return nil
  1626. }, func(st *serverTester) {
  1627. getSlash(st)
  1628. hf := st.wantHeaders()
  1629. if hf.StreamEnded() {
  1630. t.Fatal("unexpected END_STREAM")
  1631. }
  1632. if !hf.HeadersEnded() {
  1633. t.Fatal("want END_HEADERS flag")
  1634. }
  1635. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1636. wanth := [][2]string{
  1637. {":status", "200"},
  1638. {"content-type", "text/html; charset=utf-8"},
  1639. {"content-length", strconv.Itoa(len(msg))},
  1640. }
  1641. if !reflect.DeepEqual(goth, wanth) {
  1642. t.Errorf("Got headers %v; want %v", goth, wanth)
  1643. }
  1644. })
  1645. }
  1646. // Header accessed before the initial write and later mutated.
  1647. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1648. const msg = "<html>this is HTML."
  1649. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1650. w.Header().Set("foo", "proper value")
  1651. io.WriteString(w, msg)
  1652. w.Header().Set("foo", "should be ignored")
  1653. return nil
  1654. }, func(st *serverTester) {
  1655. getSlash(st)
  1656. hf := st.wantHeaders()
  1657. if hf.StreamEnded() {
  1658. t.Fatal("unexpected END_STREAM")
  1659. }
  1660. if !hf.HeadersEnded() {
  1661. t.Fatal("want END_HEADERS flag")
  1662. }
  1663. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1664. wanth := [][2]string{
  1665. {":status", "200"},
  1666. {"foo", "proper value"},
  1667. {"content-type", "text/html; charset=utf-8"},
  1668. {"content-length", strconv.Itoa(len(msg))},
  1669. }
  1670. if !reflect.DeepEqual(goth, wanth) {
  1671. t.Errorf("Got headers %v; want %v", goth, wanth)
  1672. }
  1673. })
  1674. }
  1675. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1676. const msg = "<html>this is HTML."
  1677. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1678. io.WriteString(w, msg)
  1679. return nil
  1680. }, func(st *serverTester) {
  1681. getSlash(st)
  1682. hf := st.wantHeaders()
  1683. if hf.StreamEnded() {
  1684. t.Fatal("don't want END_STREAM, expecting data")
  1685. }
  1686. if !hf.HeadersEnded() {
  1687. t.Fatal("want END_HEADERS flag")
  1688. }
  1689. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1690. wanth := [][2]string{
  1691. {":status", "200"},
  1692. {"content-type", "text/html; charset=utf-8"},
  1693. {"content-length", strconv.Itoa(len(msg))},
  1694. }
  1695. if !reflect.DeepEqual(goth, wanth) {
  1696. t.Errorf("Got headers %v; want %v", goth, wanth)
  1697. }
  1698. df := st.wantData()
  1699. if !df.StreamEnded() {
  1700. t.Error("expected DATA to have END_STREAM flag")
  1701. }
  1702. if got := string(df.Data()); got != msg {
  1703. t.Errorf("got DATA %q; want %q", got, msg)
  1704. }
  1705. })
  1706. }
  1707. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1708. const msg = "<html>this is HTML"
  1709. const msg2 = ", and this is the next chunk"
  1710. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1711. io.WriteString(w, msg)
  1712. w.(http.Flusher).Flush()
  1713. io.WriteString(w, msg2)
  1714. return nil
  1715. }, func(st *serverTester) {
  1716. getSlash(st)
  1717. hf := st.wantHeaders()
  1718. if hf.StreamEnded() {
  1719. t.Fatal("unexpected END_STREAM flag")
  1720. }
  1721. if !hf.HeadersEnded() {
  1722. t.Fatal("want END_HEADERS flag")
  1723. }
  1724. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1725. wanth := [][2]string{
  1726. {":status", "200"},
  1727. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1728. // and no content-length
  1729. }
  1730. if !reflect.DeepEqual(goth, wanth) {
  1731. t.Errorf("Got headers %v; want %v", goth, wanth)
  1732. }
  1733. {
  1734. df := st.wantData()
  1735. if df.StreamEnded() {
  1736. t.Error("unexpected END_STREAM flag")
  1737. }
  1738. if got := string(df.Data()); got != msg {
  1739. t.Errorf("got DATA %q; want %q", got, msg)
  1740. }
  1741. }
  1742. {
  1743. df := st.wantData()
  1744. if !df.StreamEnded() {
  1745. t.Error("wanted END_STREAM flag on last data chunk")
  1746. }
  1747. if got := string(df.Data()); got != msg2 {
  1748. t.Errorf("got DATA %q; want %q", got, msg2)
  1749. }
  1750. }
  1751. })
  1752. }
  1753. func TestServer_Response_LargeWrite(t *testing.T) {
  1754. const size = 1 << 20
  1755. const maxFrameSize = 16 << 10
  1756. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1757. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1758. if err != nil {
  1759. return fmt.Errorf("Write error: %v", err)
  1760. }
  1761. if n != size {
  1762. return fmt.Errorf("wrong size %d from Write", n)
  1763. }
  1764. return nil
  1765. }, func(st *serverTester) {
  1766. if err := st.fr.WriteSettings(
  1767. Setting{SettingInitialWindowSize, 0},
  1768. Setting{SettingMaxFrameSize, maxFrameSize},
  1769. ); err != nil {
  1770. t.Fatal(err)
  1771. }
  1772. st.wantSettingsAck()
  1773. getSlash(st) // make the single request
  1774. // Give the handler quota to write:
  1775. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1776. t.Fatal(err)
  1777. }
  1778. // Give the handler quota to write to connection-level
  1779. // window as well
  1780. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1781. t.Fatal(err)
  1782. }
  1783. hf := st.wantHeaders()
  1784. if hf.StreamEnded() {
  1785. t.Fatal("unexpected END_STREAM flag")
  1786. }
  1787. if !hf.HeadersEnded() {
  1788. t.Fatal("want END_HEADERS flag")
  1789. }
  1790. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1791. wanth := [][2]string{
  1792. {":status", "200"},
  1793. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1794. // and no content-length
  1795. }
  1796. if !reflect.DeepEqual(goth, wanth) {
  1797. t.Errorf("Got headers %v; want %v", goth, wanth)
  1798. }
  1799. var bytes, frames int
  1800. for {
  1801. df := st.wantData()
  1802. bytes += len(df.Data())
  1803. frames++
  1804. for _, b := range df.Data() {
  1805. if b != 'a' {
  1806. t.Fatal("non-'a' byte seen in DATA")
  1807. }
  1808. }
  1809. if df.StreamEnded() {
  1810. break
  1811. }
  1812. }
  1813. if bytes != size {
  1814. t.Errorf("Got %d bytes; want %d", bytes, size)
  1815. }
  1816. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1817. t.Errorf("Got %d frames; want %d", frames, size)
  1818. }
  1819. })
  1820. }
  1821. // Test that the handler can't write more than the client allows
  1822. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1823. // Make these reads. Before each read, the client adds exactly enough
  1824. // flow-control to satisfy the read. Numbers chosen arbitrarily.
  1825. reads := []int{123, 1, 13, 127}
  1826. size := 0
  1827. for _, n := range reads {
  1828. size += n
  1829. }
  1830. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1831. w.(http.Flusher).Flush()
  1832. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1833. if err != nil {
  1834. return fmt.Errorf("Write error: %v", err)
  1835. }
  1836. if n != size {
  1837. return fmt.Errorf("wrong size %d from Write", n)
  1838. }
  1839. return nil
  1840. }, func(st *serverTester) {
  1841. // Set the window size to something explicit for this test.
  1842. // It's also how much initial data we expect.
  1843. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, uint32(reads[0])}); err != nil {
  1844. t.Fatal(err)
  1845. }
  1846. st.wantSettingsAck()
  1847. getSlash(st) // make the single request
  1848. hf := st.wantHeaders()
  1849. if hf.StreamEnded() {
  1850. t.Fatal("unexpected END_STREAM flag")
  1851. }
  1852. if !hf.HeadersEnded() {
  1853. t.Fatal("want END_HEADERS flag")
  1854. }
  1855. df := st.wantData()
  1856. if got := len(df.Data()); got != reads[0] {
  1857. t.Fatalf("Initial window size = %d but got DATA with %d bytes", reads[0], got)
  1858. }
  1859. for _, quota := range reads[1:] {
  1860. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1861. t.Fatal(err)
  1862. }
  1863. df := st.wantData()
  1864. if int(quota) != len(df.Data()) {
  1865. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1866. }
  1867. }
  1868. })
  1869. }
  1870. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1871. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1872. const size = 1 << 20
  1873. const maxFrameSize = 16 << 10
  1874. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1875. w.(http.Flusher).Flush()
  1876. errc := make(chan error, 1)
  1877. go func() {
  1878. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1879. errc <- err
  1880. }()
  1881. select {
  1882. case err := <-errc:
  1883. if err == nil {
  1884. return errors.New("unexpected nil error from Write in handler")
  1885. }
  1886. return nil
  1887. case <-time.After(2 * time.Second):
  1888. return errors.New("timeout waiting for Write in handler")
  1889. }
  1890. }, func(st *serverTester) {
  1891. if err := st.fr.WriteSettings(
  1892. Setting{SettingInitialWindowSize, 0},
  1893. Setting{SettingMaxFrameSize, maxFrameSize},
  1894. ); err != nil {
  1895. t.Fatal(err)
  1896. }
  1897. st.wantSettingsAck()
  1898. getSlash(st) // make the single request
  1899. hf := st.wantHeaders()
  1900. if hf.StreamEnded() {
  1901. t.Fatal("unexpected END_STREAM flag")
  1902. }
  1903. if !hf.HeadersEnded() {
  1904. t.Fatal("want END_HEADERS flag")
  1905. }
  1906. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1907. t.Fatal(err)
  1908. }
  1909. })
  1910. }
  1911. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1912. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1913. w.(http.Flusher).Flush()
  1914. // Nothing; send empty DATA
  1915. return nil
  1916. }, func(st *serverTester) {
  1917. // Handler gets no data quota:
  1918. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1919. t.Fatal(err)
  1920. }
  1921. st.wantSettingsAck()
  1922. getSlash(st) // make the single request
  1923. hf := st.wantHeaders()
  1924. if hf.StreamEnded() {
  1925. t.Fatal("unexpected END_STREAM flag")
  1926. }
  1927. if !hf.HeadersEnded() {
  1928. t.Fatal("want END_HEADERS flag")
  1929. }
  1930. df := st.wantData()
  1931. if got := len(df.Data()); got != 0 {
  1932. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1933. }
  1934. if !df.StreamEnded() {
  1935. t.Fatal("DATA didn't have END_STREAM")
  1936. }
  1937. })
  1938. }
  1939. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1940. const msg = "foo"
  1941. const reply = "bar"
  1942. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1943. if v := r.Header.Get("Expect"); v != "" {
  1944. t.Errorf("Expect header = %q; want empty", v)
  1945. }
  1946. buf := make([]byte, len(msg))
  1947. // This read should trigger the 100-continue being sent.
  1948. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1949. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1950. }
  1951. _, err := io.WriteString(w, reply)
  1952. return err
  1953. }, func(st *serverTester) {
  1954. st.writeHeaders(HeadersFrameParam{
  1955. StreamID: 1, // clients send odd numbers
  1956. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1957. EndStream: false,
  1958. EndHeaders: true,
  1959. })
  1960. hf := st.wantHeaders()
  1961. if hf.StreamEnded() {
  1962. t.Fatal("unexpected END_STREAM flag")
  1963. }
  1964. if !hf.HeadersEnded() {
  1965. t.Fatal("want END_HEADERS flag")
  1966. }
  1967. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1968. wanth := [][2]string{
  1969. {":status", "100"},
  1970. }
  1971. if !reflect.DeepEqual(goth, wanth) {
  1972. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1973. }
  1974. // Okay, they sent status 100, so we can send our
  1975. // gigantic and/or sensitive "foo" payload now.
  1976. st.writeData(1, true, []byte(msg))
  1977. st.wantWindowUpdate(0, uint32(len(msg)))
  1978. hf = st.wantHeaders()
  1979. if hf.StreamEnded() {
  1980. t.Fatal("expected data to follow")
  1981. }
  1982. if !hf.HeadersEnded() {
  1983. t.Fatal("want END_HEADERS flag")
  1984. }
  1985. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1986. wanth = [][2]string{
  1987. {":status", "200"},
  1988. {"content-type", "text/plain; charset=utf-8"},
  1989. {"content-length", strconv.Itoa(len(reply))},
  1990. }
  1991. if !reflect.DeepEqual(goth, wanth) {
  1992. t.Errorf("Got headers %v; want %v", goth, wanth)
  1993. }
  1994. df := st.wantData()
  1995. if string(df.Data()) != reply {
  1996. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1997. }
  1998. if !df.StreamEnded() {
  1999. t.Errorf("expect data stream end")
  2000. }
  2001. })
  2002. }
  2003. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  2004. errc := make(chan error, 1)
  2005. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2006. p := []byte("some data.\n")
  2007. for {
  2008. _, err := w.Write(p)
  2009. if err != nil {
  2010. errc <- err
  2011. return nil
  2012. }
  2013. }
  2014. }, func(st *serverTester) {
  2015. st.writeHeaders(HeadersFrameParam{
  2016. StreamID: 1,
  2017. BlockFragment: st.encodeHeader(),
  2018. EndStream: false,
  2019. EndHeaders: true,
  2020. })
  2021. hf := st.wantHeaders()
  2022. if hf.StreamEnded() {
  2023. t.Fatal("unexpected END_STREAM flag")
  2024. }
  2025. if !hf.HeadersEnded() {
  2026. t.Fatal("want END_HEADERS flag")
  2027. }
  2028. // Close the connection and wait for the handler to (hopefully) notice.
  2029. st.cc.Close()
  2030. select {
  2031. case <-errc:
  2032. case <-time.After(5 * time.Second):
  2033. t.Error("timeout")
  2034. }
  2035. })
  2036. }
  2037. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  2038. const testPath = "/some/path"
  2039. inHandler := make(chan uint32)
  2040. leaveHandler := make(chan bool)
  2041. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2042. id := w.(*responseWriter).rws.stream.id
  2043. inHandler <- id
  2044. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  2045. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  2046. }
  2047. <-leaveHandler
  2048. })
  2049. defer st.Close()
  2050. st.greet()
  2051. nextStreamID := uint32(1)
  2052. streamID := func() uint32 {
  2053. defer func() { nextStreamID += 2 }()
  2054. return nextStreamID
  2055. }
  2056. sendReq := func(id uint32, headers ...string) {
  2057. st.writeHeaders(HeadersFrameParam{
  2058. StreamID: id,
  2059. BlockFragment: st.encodeHeader(headers...),
  2060. EndStream: true,
  2061. EndHeaders: true,
  2062. })
  2063. }
  2064. for i := 0; i < defaultMaxStreams; i++ {
  2065. sendReq(streamID())
  2066. <-inHandler
  2067. }
  2068. defer func() {
  2069. for i := 0; i < defaultMaxStreams; i++ {
  2070. leaveHandler <- true
  2071. }
  2072. }()
  2073. // And this one should cross the limit:
  2074. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  2075. // even if we're rejecting it)
  2076. rejectID := streamID()
  2077. headerBlock := st.encodeHeader(":path", testPath)
  2078. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  2079. st.writeHeaders(HeadersFrameParam{
  2080. StreamID: rejectID,
  2081. BlockFragment: frag1,
  2082. EndStream: true,
  2083. EndHeaders: false, // CONTINUATION coming
  2084. })
  2085. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  2086. t.Fatal(err)
  2087. }
  2088. st.wantRSTStream(rejectID, ErrCodeProtocol)
  2089. // But let a handler finish:
  2090. leaveHandler <- true
  2091. st.wantHeaders()
  2092. // And now another stream should be able to start:
  2093. goodID := streamID()
  2094. sendReq(goodID, ":path", testPath)
  2095. select {
  2096. case got := <-inHandler:
  2097. if got != goodID {
  2098. t.Errorf("Got stream %d; want %d", got, goodID)
  2099. }
  2100. case <-time.After(3 * time.Second):
  2101. t.Error("timeout waiting for handler")
  2102. }
  2103. }
  2104. // So many response headers that the server needs to use CONTINUATION frames:
  2105. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  2106. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2107. h := w.Header()
  2108. for i := 0; i < 5000; i++ {
  2109. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  2110. }
  2111. return nil
  2112. }, func(st *serverTester) {
  2113. getSlash(st)
  2114. hf := st.wantHeaders()
  2115. if hf.HeadersEnded() {
  2116. t.Fatal("got unwanted END_HEADERS flag")
  2117. }
  2118. n := 0
  2119. for {
  2120. n++
  2121. cf := st.wantContinuation()
  2122. if cf.HeadersEnded() {
  2123. break
  2124. }
  2125. }
  2126. if n < 5 {
  2127. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  2128. }
  2129. })
  2130. }
  2131. // This previously crashed (reported by Mathieu Lonjaret as observed
  2132. // while using Camlistore) because we got a DATA frame from the client
  2133. // after the handler exited and our logic at the time was wrong,
  2134. // keeping a stream in the map in stateClosed, which tickled an
  2135. // invariant check later when we tried to remove that stream (via
  2136. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  2137. // ended.
  2138. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2139. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2140. // nothing
  2141. return nil
  2142. }, func(st *serverTester) {
  2143. st.writeHeaders(HeadersFrameParam{
  2144. StreamID: 1,
  2145. BlockFragment: st.encodeHeader(),
  2146. EndStream: false, // DATA is coming
  2147. EndHeaders: true,
  2148. })
  2149. hf := st.wantHeaders()
  2150. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2151. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2152. }
  2153. // Sent when the a Handler closes while a client has
  2154. // indicated it's still sending DATA:
  2155. st.wantRSTStream(1, ErrCodeNo)
  2156. // Now the handler has ended, so it's ended its
  2157. // stream, but the client hasn't closed its side
  2158. // (stateClosedLocal). So send more data and verify
  2159. // it doesn't crash with an internal invariant panic, like
  2160. // it did before.
  2161. st.writeData(1, true, []byte("foo"))
  2162. // Get our flow control bytes back, since the handler didn't get them.
  2163. st.wantWindowUpdate(0, uint32(len("foo")))
  2164. // Sent after a peer sends data anyway (admittedly the
  2165. // previous RST_STREAM might've still been in-flight),
  2166. // but they'll get the more friendly 'cancel' code
  2167. // first.
  2168. st.wantRSTStream(1, ErrCodeStreamClosed)
  2169. // Set up a bunch of machinery to record the panic we saw
  2170. // previously.
  2171. var (
  2172. panMu sync.Mutex
  2173. panicVal interface{}
  2174. )
  2175. testHookOnPanicMu.Lock()
  2176. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2177. panMu.Lock()
  2178. panicVal = pv
  2179. panMu.Unlock()
  2180. return true
  2181. }
  2182. testHookOnPanicMu.Unlock()
  2183. // Now force the serve loop to end, via closing the connection.
  2184. st.cc.Close()
  2185. select {
  2186. case <-st.sc.doneServing:
  2187. // Loop has exited.
  2188. panMu.Lock()
  2189. got := panicVal
  2190. panMu.Unlock()
  2191. if got != nil {
  2192. t.Errorf("Got panic: %v", got)
  2193. }
  2194. case <-time.After(5 * time.Second):
  2195. t.Error("timeout")
  2196. }
  2197. })
  2198. }
  2199. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2200. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2201. func testRejectTLS(t *testing.T, max uint16) {
  2202. st := newServerTester(t, nil, func(c *tls.Config) {
  2203. c.MaxVersion = max
  2204. })
  2205. defer st.Close()
  2206. gf := st.wantGoAway()
  2207. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2208. t.Errorf("Got error code %v; want %v", got, want)
  2209. }
  2210. }
  2211. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2212. st := newServerTester(t, nil, func(c *tls.Config) {
  2213. // All TLS 1.3 ciphers are good. Test with TLS 1.2.
  2214. c.MaxVersion = tls.VersionTLS12
  2215. // Only list bad ones:
  2216. c.CipherSuites = []uint16{
  2217. tls.TLS_RSA_WITH_RC4_128_SHA,
  2218. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2219. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2220. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2221. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2222. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2223. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2224. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2225. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2226. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2227. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2228. cipher_TLS_RSA_WITH_AES_128_CBC_SHA256,
  2229. }
  2230. })
  2231. defer st.Close()
  2232. gf := st.wantGoAway()
  2233. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2234. t.Errorf("Got error code %v; want %v", got, want)
  2235. }
  2236. }
  2237. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2238. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2239. st := newServerTester(t, nil, func(c *tls.Config) {
  2240. // Have the client only support the one required by the spec.
  2241. c.CipherSuites = []uint16{requiredSuite}
  2242. }, func(ts *httptest.Server) {
  2243. var srv *http.Server = ts.Config
  2244. // Have the server configured with no specific cipher suites.
  2245. // This tests that Go's defaults include the required one.
  2246. srv.TLSConfig = nil
  2247. })
  2248. defer st.Close()
  2249. st.greet()
  2250. }
  2251. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2252. if f.Name == "date" {
  2253. return
  2254. }
  2255. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2256. }
  2257. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2258. st.decodedHeaders = nil
  2259. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2260. st.t.Fatalf("hpack decoding error: %v", err)
  2261. }
  2262. if err := st.hpackDec.Close(); err != nil {
  2263. st.t.Fatalf("hpack decoding error: %v", err)
  2264. }
  2265. return st.decodedHeaders
  2266. }
  2267. // testServerResponse sets up an idle HTTP/2 connection. The client function should
  2268. // write a single request that must be handled by the handler. This waits up to 5s
  2269. // for client to return, then up to an additional 2s for the handler to return.
  2270. func testServerResponse(t testing.TB,
  2271. handler func(http.ResponseWriter, *http.Request) error,
  2272. client func(*serverTester),
  2273. ) {
  2274. errc := make(chan error, 1)
  2275. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2276. if r.Body == nil {
  2277. t.Fatal("nil Body")
  2278. }
  2279. errc <- handler(w, r)
  2280. })
  2281. defer st.Close()
  2282. donec := make(chan bool)
  2283. go func() {
  2284. defer close(donec)
  2285. st.greet()
  2286. client(st)
  2287. }()
  2288. select {
  2289. case <-donec:
  2290. case <-time.After(5 * time.Second):
  2291. t.Fatal("timeout in client")
  2292. }
  2293. select {
  2294. case err := <-errc:
  2295. if err != nil {
  2296. t.Fatalf("Error in handler: %v", err)
  2297. }
  2298. case <-time.After(2 * time.Second):
  2299. t.Fatal("timeout in handler")
  2300. }
  2301. }
  2302. // readBodyHandler returns an http Handler func that reads len(want)
  2303. // bytes from r.Body and fails t if the contents read were not
  2304. // the value of want.
  2305. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2306. return func(w http.ResponseWriter, r *http.Request) {
  2307. buf := make([]byte, len(want))
  2308. _, err := io.ReadFull(r.Body, buf)
  2309. if err != nil {
  2310. t.Error(err)
  2311. return
  2312. }
  2313. if string(buf) != want {
  2314. t.Errorf("read %q; want %q", buf, want)
  2315. }
  2316. }
  2317. }
  2318. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2319. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2320. // http://sourceforge.net/p/curl/bugs/1472/
  2321. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2322. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2323. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2324. if runtime.GOOS != "linux" {
  2325. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2326. }
  2327. if testing.Short() {
  2328. t.Skip("skipping curl test in short mode")
  2329. }
  2330. requireCurl(t)
  2331. var gotConn int32
  2332. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2333. const msg = "Hello from curl!\n"
  2334. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2335. w.Header().Set("Foo", "Bar")
  2336. w.Header().Set("Client-Proto", r.Proto)
  2337. io.WriteString(w, msg)
  2338. }))
  2339. ConfigureServer(ts.Config, &Server{
  2340. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2341. })
  2342. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2343. ts.StartTLS()
  2344. defer ts.Close()
  2345. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2346. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2347. defer kill(container)
  2348. resc := make(chan interface{}, 1)
  2349. go func() {
  2350. res, err := dockerLogs(container)
  2351. if err != nil {
  2352. resc <- err
  2353. } else {
  2354. resc <- res
  2355. }
  2356. }()
  2357. select {
  2358. case res := <-resc:
  2359. if err, ok := res.(error); ok {
  2360. t.Fatal(err)
  2361. }
  2362. body := string(res.([]byte))
  2363. // Search for both "key: value" and "key:value", since curl changed their format
  2364. // Our Dockerfile contains the latest version (no space), but just in case people
  2365. // didn't rebuild, check both.
  2366. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2367. t.Errorf("didn't see foo: Bar header")
  2368. t.Logf("Got: %s", body)
  2369. }
  2370. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2371. t.Errorf("didn't see client-proto: HTTP/2 header")
  2372. t.Logf("Got: %s", res)
  2373. }
  2374. if !strings.Contains(string(res.([]byte)), msg) {
  2375. t.Errorf("didn't see %q content", msg)
  2376. t.Logf("Got: %s", res)
  2377. }
  2378. case <-time.After(3 * time.Second):
  2379. t.Errorf("timeout waiting for curl")
  2380. }
  2381. if atomic.LoadInt32(&gotConn) == 0 {
  2382. t.Error("never saw an http2 connection")
  2383. }
  2384. }
  2385. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2386. func TestServerWithH2Load(t *testing.T) {
  2387. if !*doh2load {
  2388. t.Skip("Skipping without --h2load flag.")
  2389. }
  2390. if runtime.GOOS != "linux" {
  2391. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2392. }
  2393. requireH2load(t)
  2394. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2395. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2396. io.WriteString(w, msg)
  2397. w.(http.Flusher).Flush()
  2398. io.WriteString(w, msg)
  2399. }))
  2400. ts.StartTLS()
  2401. defer ts.Close()
  2402. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2403. "-n100000", "-c100", "-m100", ts.URL)
  2404. cmd.Stdout = os.Stdout
  2405. cmd.Stderr = os.Stderr
  2406. if err := cmd.Run(); err != nil {
  2407. t.Fatal(err)
  2408. }
  2409. }
  2410. // Issue 12843
  2411. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2412. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2413. defer st.Close()
  2414. // shake hands
  2415. frameSize := defaultMaxReadFrameSize
  2416. var advHeaderListSize *uint32
  2417. st.greetAndCheckSettings(func(s Setting) error {
  2418. switch s.ID {
  2419. case SettingMaxFrameSize:
  2420. if s.Val < minMaxFrameSize {
  2421. frameSize = minMaxFrameSize
  2422. } else if s.Val > maxFrameSize {
  2423. frameSize = maxFrameSize
  2424. } else {
  2425. frameSize = int(s.Val)
  2426. }
  2427. case SettingMaxHeaderListSize:
  2428. advHeaderListSize = &s.Val
  2429. }
  2430. return nil
  2431. })
  2432. if advHeaderListSize == nil {
  2433. t.Errorf("server didn't advertise a max header list size")
  2434. } else if *advHeaderListSize == 0 {
  2435. t.Errorf("server advertised a max header list size of 0")
  2436. }
  2437. st.encodeHeaderField(":method", "GET")
  2438. st.encodeHeaderField(":path", "/")
  2439. st.encodeHeaderField(":scheme", "https")
  2440. cookie := strings.Repeat("*", 4058)
  2441. st.encodeHeaderField("cookie", cookie)
  2442. st.writeHeaders(HeadersFrameParam{
  2443. StreamID: 1,
  2444. BlockFragment: st.headerBuf.Bytes(),
  2445. EndStream: true,
  2446. EndHeaders: false,
  2447. })
  2448. // Capture the short encoding of a duplicate ~4K cookie, now
  2449. // that we've already sent it once.
  2450. st.headerBuf.Reset()
  2451. st.encodeHeaderField("cookie", cookie)
  2452. // Now send 1MB of it.
  2453. const size = 1 << 20
  2454. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2455. for len(b) > 0 {
  2456. chunk := b
  2457. if len(chunk) > frameSize {
  2458. chunk = chunk[:frameSize]
  2459. }
  2460. b = b[len(chunk):]
  2461. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2462. }
  2463. h := st.wantHeaders()
  2464. if !h.HeadersEnded() {
  2465. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2466. }
  2467. headers := st.decodeHeader(h.HeaderBlockFragment())
  2468. want := [][2]string{
  2469. {":status", "431"},
  2470. {"content-type", "text/html; charset=utf-8"},
  2471. {"content-length", "63"},
  2472. }
  2473. if !reflect.DeepEqual(headers, want) {
  2474. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2475. }
  2476. }
  2477. func TestCompressionErrorOnWrite(t *testing.T) {
  2478. const maxStrLen = 8 << 10
  2479. var serverConfig *http.Server
  2480. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2481. // No response body.
  2482. }, func(ts *httptest.Server) {
  2483. serverConfig = ts.Config
  2484. serverConfig.MaxHeaderBytes = maxStrLen
  2485. })
  2486. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2487. defer st.Close()
  2488. st.greet()
  2489. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2490. // Crank this up, now that we have a conn connected with the
  2491. // hpack.Decoder's max string length set has been initialized
  2492. // from the earlier low ~8K value. We want this higher so don't
  2493. // hit the max header list size. We only want to test hitting
  2494. // the max string size.
  2495. serverConfig.MaxHeaderBytes = 1 << 20
  2496. // First a request with a header that's exactly the max allowed size
  2497. // for the hpack compression. It's still too long for the header list
  2498. // size, so we'll get the 431 error, but that keeps the compression
  2499. // context still valid.
  2500. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2501. st.writeHeaders(HeadersFrameParam{
  2502. StreamID: 1,
  2503. BlockFragment: hbf,
  2504. EndStream: true,
  2505. EndHeaders: true,
  2506. })
  2507. h := st.wantHeaders()
  2508. if !h.HeadersEnded() {
  2509. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2510. }
  2511. headers := st.decodeHeader(h.HeaderBlockFragment())
  2512. want := [][2]string{
  2513. {":status", "431"},
  2514. {"content-type", "text/html; charset=utf-8"},
  2515. {"content-length", "63"},
  2516. }
  2517. if !reflect.DeepEqual(headers, want) {
  2518. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2519. }
  2520. df := st.wantData()
  2521. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2522. t.Errorf("Unexpected data body: %q", df.Data())
  2523. }
  2524. if !df.StreamEnded() {
  2525. t.Fatalf("expect data stream end")
  2526. }
  2527. // And now send one that's just one byte too big.
  2528. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2529. st.writeHeaders(HeadersFrameParam{
  2530. StreamID: 3,
  2531. BlockFragment: hbf,
  2532. EndStream: true,
  2533. EndHeaders: true,
  2534. })
  2535. ga := st.wantGoAway()
  2536. if ga.ErrCode != ErrCodeCompression {
  2537. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2538. }
  2539. }
  2540. func TestCompressionErrorOnClose(t *testing.T) {
  2541. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2542. // No response body.
  2543. })
  2544. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2545. defer st.Close()
  2546. st.greet()
  2547. hbf := st.encodeHeader("foo", "bar")
  2548. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2549. st.writeHeaders(HeadersFrameParam{
  2550. StreamID: 1,
  2551. BlockFragment: hbf,
  2552. EndStream: true,
  2553. EndHeaders: true,
  2554. })
  2555. ga := st.wantGoAway()
  2556. if ga.ErrCode != ErrCodeCompression {
  2557. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2558. }
  2559. }
  2560. // test that a server handler can read trailers from a client
  2561. func TestServerReadsTrailers(t *testing.T) {
  2562. const testBody = "some test body"
  2563. writeReq := func(st *serverTester) {
  2564. st.writeHeaders(HeadersFrameParam{
  2565. StreamID: 1, // clients send odd numbers
  2566. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2567. EndStream: false,
  2568. EndHeaders: true,
  2569. })
  2570. st.writeData(1, false, []byte(testBody))
  2571. st.writeHeaders(HeadersFrameParam{
  2572. StreamID: 1, // clients send odd numbers
  2573. BlockFragment: st.encodeHeaderRaw(
  2574. "foo", "foov",
  2575. "bar", "barv",
  2576. "baz", "bazv",
  2577. "surprise", "wasn't declared; shouldn't show up",
  2578. ),
  2579. EndStream: true,
  2580. EndHeaders: true,
  2581. })
  2582. }
  2583. checkReq := func(r *http.Request) {
  2584. wantTrailer := http.Header{
  2585. "Foo": nil,
  2586. "Bar": nil,
  2587. "Baz": nil,
  2588. }
  2589. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2590. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2591. }
  2592. slurp, err := ioutil.ReadAll(r.Body)
  2593. if string(slurp) != testBody {
  2594. t.Errorf("read body %q; want %q", slurp, testBody)
  2595. }
  2596. if err != nil {
  2597. t.Fatalf("Body slurp: %v", err)
  2598. }
  2599. wantTrailerAfter := http.Header{
  2600. "Foo": {"foov"},
  2601. "Bar": {"barv"},
  2602. "Baz": {"bazv"},
  2603. }
  2604. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2605. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2606. }
  2607. }
  2608. testServerRequest(t, writeReq, checkReq)
  2609. }
  2610. // test that a server handler can send trailers
  2611. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2612. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2613. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2614. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2615. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2616. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2617. w.Header().Add("Trailer", "Server-Trailer-C")
  2618. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2619. // Regular headers:
  2620. w.Header().Set("Foo", "Bar")
  2621. w.Header().Set("Content-Length", "5") // len("Hello")
  2622. io.WriteString(w, "Hello")
  2623. if withFlush {
  2624. w.(http.Flusher).Flush()
  2625. }
  2626. w.Header().Set("Server-Trailer-A", "valuea")
  2627. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2628. // After a flush, random keys like Server-Surprise shouldn't show up:
  2629. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2630. // But we do permit promoting keys to trailers after a
  2631. // flush if they start with the magic
  2632. // otherwise-invalid "Trailer:" prefix:
  2633. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2634. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2635. w.Header().Set("Trailer:Range", "invalid")
  2636. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2637. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 7230 4.1.2")
  2638. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 7230 4.1.2")
  2639. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 7230 4.1.2")
  2640. return nil
  2641. }, func(st *serverTester) {
  2642. getSlash(st)
  2643. hf := st.wantHeaders()
  2644. if hf.StreamEnded() {
  2645. t.Fatal("response HEADERS had END_STREAM")
  2646. }
  2647. if !hf.HeadersEnded() {
  2648. t.Fatal("response HEADERS didn't have END_HEADERS")
  2649. }
  2650. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2651. wanth := [][2]string{
  2652. {":status", "200"},
  2653. {"foo", "Bar"},
  2654. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2655. {"trailer", "Server-Trailer-C"},
  2656. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2657. {"content-type", "text/plain; charset=utf-8"},
  2658. {"content-length", "5"},
  2659. }
  2660. if !reflect.DeepEqual(goth, wanth) {
  2661. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2662. }
  2663. df := st.wantData()
  2664. if string(df.Data()) != "Hello" {
  2665. t.Fatalf("Client read %q; want Hello", df.Data())
  2666. }
  2667. if df.StreamEnded() {
  2668. t.Fatalf("data frame had STREAM_ENDED")
  2669. }
  2670. tf := st.wantHeaders() // for the trailers
  2671. if !tf.StreamEnded() {
  2672. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2673. }
  2674. if !tf.HeadersEnded() {
  2675. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2676. }
  2677. wanth = [][2]string{
  2678. {"post-header-trailer", "hi1"},
  2679. {"post-header-trailer2", "hi2"},
  2680. {"server-trailer-a", "valuea"},
  2681. {"server-trailer-c", "valuec"},
  2682. }
  2683. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2684. if !reflect.DeepEqual(goth, wanth) {
  2685. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2686. }
  2687. })
  2688. }
  2689. // validate transmitted header field names & values
  2690. // golang.org/issue/14048
  2691. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2692. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2693. w.Header().Add("OK1", "x")
  2694. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2695. w.Header().Add("Bad1\x00", "x") // null in key
  2696. w.Header().Add("Bad2", "x\x00y") // null in value
  2697. return nil
  2698. }, func(st *serverTester) {
  2699. getSlash(st)
  2700. hf := st.wantHeaders()
  2701. if !hf.StreamEnded() {
  2702. t.Error("response HEADERS lacked END_STREAM")
  2703. }
  2704. if !hf.HeadersEnded() {
  2705. t.Fatal("response HEADERS didn't have END_HEADERS")
  2706. }
  2707. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2708. wanth := [][2]string{
  2709. {":status", "200"},
  2710. {"ok1", "x"},
  2711. {"content-length", "0"},
  2712. }
  2713. if !reflect.DeepEqual(goth, wanth) {
  2714. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2715. }
  2716. })
  2717. }
  2718. func BenchmarkServerGets(b *testing.B) {
  2719. defer disableGoroutineTracking()()
  2720. b.ReportAllocs()
  2721. const msg = "Hello, world"
  2722. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2723. io.WriteString(w, msg)
  2724. })
  2725. defer st.Close()
  2726. st.greet()
  2727. // Give the server quota to reply. (plus it has the 64KB)
  2728. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2729. b.Fatal(err)
  2730. }
  2731. for i := 0; i < b.N; i++ {
  2732. id := 1 + uint32(i)*2
  2733. st.writeHeaders(HeadersFrameParam{
  2734. StreamID: id,
  2735. BlockFragment: st.encodeHeader(),
  2736. EndStream: true,
  2737. EndHeaders: true,
  2738. })
  2739. st.wantHeaders()
  2740. df := st.wantData()
  2741. if !df.StreamEnded() {
  2742. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2743. }
  2744. }
  2745. }
  2746. func BenchmarkServerPosts(b *testing.B) {
  2747. defer disableGoroutineTracking()()
  2748. b.ReportAllocs()
  2749. const msg = "Hello, world"
  2750. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2751. // Consume the (empty) body from th peer before replying, otherwise
  2752. // the server will sometimes (depending on scheduling) send the peer a
  2753. // a RST_STREAM with the CANCEL error code.
  2754. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2755. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2756. }
  2757. io.WriteString(w, msg)
  2758. })
  2759. defer st.Close()
  2760. st.greet()
  2761. // Give the server quota to reply. (plus it has the 64KB)
  2762. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2763. b.Fatal(err)
  2764. }
  2765. for i := 0; i < b.N; i++ {
  2766. id := 1 + uint32(i)*2
  2767. st.writeHeaders(HeadersFrameParam{
  2768. StreamID: id,
  2769. BlockFragment: st.encodeHeader(":method", "POST"),
  2770. EndStream: false,
  2771. EndHeaders: true,
  2772. })
  2773. st.writeData(id, true, nil)
  2774. st.wantHeaders()
  2775. df := st.wantData()
  2776. if !df.StreamEnded() {
  2777. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2778. }
  2779. }
  2780. }
  2781. // Send a stream of messages from server to client in separate data frames.
  2782. // Brings up performance issues seen in long streams.
  2783. // Created to show problem in go issue #18502
  2784. func BenchmarkServerToClientStreamDefaultOptions(b *testing.B) {
  2785. benchmarkServerToClientStream(b)
  2786. }
  2787. // Justification for Change-Id: Iad93420ef6c3918f54249d867098f1dadfa324d8
  2788. // Expect to see memory/alloc reduction by opting in to Frame reuse with the Framer.
  2789. func BenchmarkServerToClientStreamReuseFrames(b *testing.B) {
  2790. benchmarkServerToClientStream(b, optFramerReuseFrames)
  2791. }
  2792. func benchmarkServerToClientStream(b *testing.B, newServerOpts ...interface{}) {
  2793. defer disableGoroutineTracking()()
  2794. b.ReportAllocs()
  2795. const msgLen = 1
  2796. // default window size
  2797. const windowSize = 1<<16 - 1
  2798. // next message to send from the server and for the client to expect
  2799. nextMsg := func(i int) []byte {
  2800. msg := make([]byte, msgLen)
  2801. msg[0] = byte(i)
  2802. if len(msg) != msgLen {
  2803. panic("invalid test setup msg length")
  2804. }
  2805. return msg
  2806. }
  2807. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2808. // Consume the (empty) body from th peer before replying, otherwise
  2809. // the server will sometimes (depending on scheduling) send the peer a
  2810. // a RST_STREAM with the CANCEL error code.
  2811. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2812. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2813. }
  2814. for i := 0; i < b.N; i += 1 {
  2815. w.Write(nextMsg(i))
  2816. w.(http.Flusher).Flush()
  2817. }
  2818. }, newServerOpts...)
  2819. defer st.Close()
  2820. st.greet()
  2821. const id = uint32(1)
  2822. st.writeHeaders(HeadersFrameParam{
  2823. StreamID: id,
  2824. BlockFragment: st.encodeHeader(":method", "POST"),
  2825. EndStream: false,
  2826. EndHeaders: true,
  2827. })
  2828. st.writeData(id, true, nil)
  2829. st.wantHeaders()
  2830. var pendingWindowUpdate = uint32(0)
  2831. for i := 0; i < b.N; i += 1 {
  2832. expected := nextMsg(i)
  2833. df := st.wantData()
  2834. if bytes.Compare(expected, df.data) != 0 {
  2835. b.Fatalf("Bad message received; want %v; got %v", expected, df.data)
  2836. }
  2837. // try to send infrequent but large window updates so they don't overwhelm the test
  2838. pendingWindowUpdate += uint32(len(df.data))
  2839. if pendingWindowUpdate >= windowSize/2 {
  2840. if err := st.fr.WriteWindowUpdate(0, pendingWindowUpdate); err != nil {
  2841. b.Fatal(err)
  2842. }
  2843. if err := st.fr.WriteWindowUpdate(id, pendingWindowUpdate); err != nil {
  2844. b.Fatal(err)
  2845. }
  2846. pendingWindowUpdate = 0
  2847. }
  2848. }
  2849. df := st.wantData()
  2850. if !df.StreamEnded() {
  2851. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2852. }
  2853. }
  2854. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2855. // Verify we don't hang.
  2856. func TestIssue53(t *testing.T) {
  2857. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2858. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2859. s := &http.Server{
  2860. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2861. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2862. w.Write([]byte("hello"))
  2863. }),
  2864. }
  2865. s2 := &Server{
  2866. MaxReadFrameSize: 1 << 16,
  2867. PermitProhibitedCipherSuites: true,
  2868. }
  2869. c := &issue53Conn{[]byte(data), false, false}
  2870. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2871. if !c.closed {
  2872. t.Fatal("connection is not closed")
  2873. }
  2874. }
  2875. type issue53Conn struct {
  2876. data []byte
  2877. closed bool
  2878. written bool
  2879. }
  2880. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2881. if len(c.data) == 0 {
  2882. return 0, io.EOF
  2883. }
  2884. n = copy(b, c.data)
  2885. c.data = c.data[n:]
  2886. return
  2887. }
  2888. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2889. c.written = true
  2890. return len(b), nil
  2891. }
  2892. func (c *issue53Conn) Close() error {
  2893. c.closed = true
  2894. return nil
  2895. }
  2896. func (c *issue53Conn) LocalAddr() net.Addr {
  2897. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2898. }
  2899. func (c *issue53Conn) RemoteAddr() net.Addr {
  2900. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2901. }
  2902. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2903. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2904. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2905. // golang.org/issue/12895
  2906. func TestConfigureServer(t *testing.T) {
  2907. tests := []struct {
  2908. name string
  2909. tlsConfig *tls.Config
  2910. wantErr string
  2911. }{
  2912. {
  2913. name: "empty server",
  2914. },
  2915. {
  2916. name: "just the required cipher suite",
  2917. tlsConfig: &tls.Config{
  2918. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2919. },
  2920. },
  2921. {
  2922. name: "just the alternative required cipher suite",
  2923. tlsConfig: &tls.Config{
  2924. CipherSuites: []uint16{tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256},
  2925. },
  2926. },
  2927. {
  2928. name: "missing required cipher suite",
  2929. tlsConfig: &tls.Config{
  2930. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2931. },
  2932. wantErr: "is missing an HTTP/2-required AES_128_GCM_SHA256 cipher.",
  2933. },
  2934. {
  2935. name: "required after bad",
  2936. tlsConfig: &tls.Config{
  2937. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2938. },
  2939. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2940. },
  2941. {
  2942. name: "bad after required",
  2943. tlsConfig: &tls.Config{
  2944. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2945. },
  2946. },
  2947. }
  2948. for _, tt := range tests {
  2949. srv := &http.Server{TLSConfig: tt.tlsConfig}
  2950. err := ConfigureServer(srv, nil)
  2951. if (err != nil) != (tt.wantErr != "") {
  2952. if tt.wantErr != "" {
  2953. t.Errorf("%s: success, but want error", tt.name)
  2954. } else {
  2955. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2956. }
  2957. }
  2958. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2959. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2960. }
  2961. if err == nil && !srv.TLSConfig.PreferServerCipherSuites {
  2962. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2963. }
  2964. }
  2965. }
  2966. func TestServerRejectHeadWithBody(t *testing.T) {
  2967. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2968. // No response body.
  2969. })
  2970. defer st.Close()
  2971. st.greet()
  2972. st.writeHeaders(HeadersFrameParam{
  2973. StreamID: 1, // clients send odd numbers
  2974. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2975. EndStream: false, // what we're testing, a bogus HEAD request with body
  2976. EndHeaders: true,
  2977. })
  2978. st.wantRSTStream(1, ErrCodeProtocol)
  2979. }
  2980. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2981. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2982. // No response body. (or smaller than one frame)
  2983. })
  2984. defer st.Close()
  2985. st.greet()
  2986. st.writeHeaders(HeadersFrameParam{
  2987. StreamID: 1, // clients send odd numbers
  2988. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2989. EndStream: true,
  2990. EndHeaders: true,
  2991. })
  2992. h := st.wantHeaders()
  2993. headers := st.decodeHeader(h.HeaderBlockFragment())
  2994. want := [][2]string{
  2995. {":status", "200"},
  2996. }
  2997. if !reflect.DeepEqual(headers, want) {
  2998. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2999. }
  3000. }
  3001. // golang.org/issue/13495
  3002. func TestServerNoDuplicateContentType(t *testing.T) {
  3003. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3004. w.Header()["Content-Type"] = []string{""}
  3005. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  3006. })
  3007. defer st.Close()
  3008. st.greet()
  3009. st.writeHeaders(HeadersFrameParam{
  3010. StreamID: 1,
  3011. BlockFragment: st.encodeHeader(),
  3012. EndStream: true,
  3013. EndHeaders: true,
  3014. })
  3015. h := st.wantHeaders()
  3016. headers := st.decodeHeader(h.HeaderBlockFragment())
  3017. want := [][2]string{
  3018. {":status", "200"},
  3019. {"content-type", ""},
  3020. {"content-length", "41"},
  3021. }
  3022. if !reflect.DeepEqual(headers, want) {
  3023. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  3024. }
  3025. }
  3026. func disableGoroutineTracking() (restore func()) {
  3027. old := DebugGoroutines
  3028. DebugGoroutines = false
  3029. return func() { DebugGoroutines = old }
  3030. }
  3031. func BenchmarkServer_GetRequest(b *testing.B) {
  3032. defer disableGoroutineTracking()()
  3033. b.ReportAllocs()
  3034. const msg = "Hello, world."
  3035. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3036. n, err := io.Copy(ioutil.Discard, r.Body)
  3037. if err != nil || n > 0 {
  3038. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3039. }
  3040. io.WriteString(w, msg)
  3041. })
  3042. defer st.Close()
  3043. st.greet()
  3044. // Give the server quota to reply. (plus it has the 64KB)
  3045. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3046. b.Fatal(err)
  3047. }
  3048. hbf := st.encodeHeader(":method", "GET")
  3049. for i := 0; i < b.N; i++ {
  3050. streamID := uint32(1 + 2*i)
  3051. st.writeHeaders(HeadersFrameParam{
  3052. StreamID: streamID,
  3053. BlockFragment: hbf,
  3054. EndStream: true,
  3055. EndHeaders: true,
  3056. })
  3057. st.wantHeaders()
  3058. st.wantData()
  3059. }
  3060. }
  3061. func BenchmarkServer_PostRequest(b *testing.B) {
  3062. defer disableGoroutineTracking()()
  3063. b.ReportAllocs()
  3064. const msg = "Hello, world."
  3065. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3066. n, err := io.Copy(ioutil.Discard, r.Body)
  3067. if err != nil || n > 0 {
  3068. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3069. }
  3070. io.WriteString(w, msg)
  3071. })
  3072. defer st.Close()
  3073. st.greet()
  3074. // Give the server quota to reply. (plus it has the 64KB)
  3075. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3076. b.Fatal(err)
  3077. }
  3078. hbf := st.encodeHeader(":method", "POST")
  3079. for i := 0; i < b.N; i++ {
  3080. streamID := uint32(1 + 2*i)
  3081. st.writeHeaders(HeadersFrameParam{
  3082. StreamID: streamID,
  3083. BlockFragment: hbf,
  3084. EndStream: false,
  3085. EndHeaders: true,
  3086. })
  3087. st.writeData(streamID, true, nil)
  3088. st.wantHeaders()
  3089. st.wantData()
  3090. }
  3091. }
  3092. type connStateConn struct {
  3093. net.Conn
  3094. cs tls.ConnectionState
  3095. }
  3096. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  3097. // golang.org/issue/12737 -- handle any net.Conn, not just
  3098. // *tls.Conn.
  3099. func TestServerHandleCustomConn(t *testing.T) {
  3100. var s Server
  3101. c1, c2 := net.Pipe()
  3102. clientDone := make(chan struct{})
  3103. handlerDone := make(chan struct{})
  3104. var req *http.Request
  3105. go func() {
  3106. defer close(clientDone)
  3107. defer c2.Close()
  3108. fr := NewFramer(c2, c2)
  3109. io.WriteString(c2, ClientPreface)
  3110. fr.WriteSettings()
  3111. fr.WriteSettingsAck()
  3112. f, err := fr.ReadFrame()
  3113. if err != nil {
  3114. t.Error(err)
  3115. return
  3116. }
  3117. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  3118. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  3119. return
  3120. }
  3121. f, err = fr.ReadFrame()
  3122. if err != nil {
  3123. t.Error(err)
  3124. return
  3125. }
  3126. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  3127. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  3128. return
  3129. }
  3130. var henc hpackEncoder
  3131. fr.WriteHeaders(HeadersFrameParam{
  3132. StreamID: 1,
  3133. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  3134. EndStream: true,
  3135. EndHeaders: true,
  3136. })
  3137. go io.Copy(ioutil.Discard, c2)
  3138. <-handlerDone
  3139. }()
  3140. const testString = "my custom ConnectionState"
  3141. fakeConnState := tls.ConnectionState{
  3142. ServerName: testString,
  3143. Version: tls.VersionTLS12,
  3144. CipherSuite: cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
  3145. }
  3146. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  3147. BaseConfig: &http.Server{
  3148. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  3149. defer close(handlerDone)
  3150. req = r
  3151. }),
  3152. }})
  3153. select {
  3154. case <-clientDone:
  3155. case <-time.After(5 * time.Second):
  3156. t.Fatal("timeout waiting for handler")
  3157. }
  3158. if req.TLS == nil {
  3159. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  3160. }
  3161. if req.TLS.ServerName != testString {
  3162. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  3163. }
  3164. }
  3165. // golang.org/issue/14214
  3166. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  3167. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3168. t.Error("should not get to Handler")
  3169. })
  3170. defer st.Close()
  3171. st.greet()
  3172. st.bodylessReq1("connection", "foo")
  3173. hf := st.wantHeaders()
  3174. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3175. wanth := [][2]string{
  3176. {":status", "400"},
  3177. {"content-type", "text/plain; charset=utf-8"},
  3178. {"x-content-type-options", "nosniff"},
  3179. {"content-length", "51"},
  3180. }
  3181. if !reflect.DeepEqual(goth, wanth) {
  3182. t.Errorf("Got headers %v; want %v", goth, wanth)
  3183. }
  3184. }
  3185. type hpackEncoder struct {
  3186. enc *hpack.Encoder
  3187. buf bytes.Buffer
  3188. }
  3189. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  3190. if len(headers)%2 == 1 {
  3191. panic("odd number of kv args")
  3192. }
  3193. he.buf.Reset()
  3194. if he.enc == nil {
  3195. he.enc = hpack.NewEncoder(&he.buf)
  3196. }
  3197. for len(headers) > 0 {
  3198. k, v := headers[0], headers[1]
  3199. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  3200. if err != nil {
  3201. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  3202. }
  3203. headers = headers[2:]
  3204. }
  3205. return he.buf.Bytes()
  3206. }
  3207. func TestCheckValidHTTP2Request(t *testing.T) {
  3208. tests := []struct {
  3209. h http.Header
  3210. want error
  3211. }{
  3212. {
  3213. h: http.Header{"Te": {"trailers"}},
  3214. want: nil,
  3215. },
  3216. {
  3217. h: http.Header{"Te": {"trailers", "bogus"}},
  3218. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3219. },
  3220. {
  3221. h: http.Header{"Foo": {""}},
  3222. want: nil,
  3223. },
  3224. {
  3225. h: http.Header{"Connection": {""}},
  3226. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3227. },
  3228. {
  3229. h: http.Header{"Proxy-Connection": {""}},
  3230. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3231. },
  3232. {
  3233. h: http.Header{"Keep-Alive": {""}},
  3234. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3235. },
  3236. {
  3237. h: http.Header{"Upgrade": {""}},
  3238. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3239. },
  3240. }
  3241. for i, tt := range tests {
  3242. got := checkValidHTTP2RequestHeaders(tt.h)
  3243. if !equalError(got, tt.want) {
  3244. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3245. }
  3246. }
  3247. }
  3248. // golang.org/issue/14030
  3249. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3250. const msg = "Hello"
  3251. const msg2 = "World"
  3252. doRead := make(chan bool, 1)
  3253. defer close(doRead) // fallback cleanup
  3254. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3255. io.WriteString(w, msg)
  3256. w.(http.Flusher).Flush()
  3257. // Do a read, which might force a 100-continue status to be sent.
  3258. <-doRead
  3259. r.Body.Read(make([]byte, 10))
  3260. io.WriteString(w, msg2)
  3261. }, optOnlyServer)
  3262. defer st.Close()
  3263. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3264. defer tr.CloseIdleConnections()
  3265. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3266. req.Header.Set("Expect", "100-continue")
  3267. res, err := tr.RoundTrip(req)
  3268. if err != nil {
  3269. t.Fatal(err)
  3270. }
  3271. defer res.Body.Close()
  3272. buf := make([]byte, len(msg))
  3273. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3274. t.Fatal(err)
  3275. }
  3276. if string(buf) != msg {
  3277. t.Fatalf("msg = %q; want %q", buf, msg)
  3278. }
  3279. doRead <- true
  3280. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3281. t.Fatal(err)
  3282. }
  3283. if string(buf) != msg2 {
  3284. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3285. }
  3286. }
  3287. type funcReader func([]byte) (n int, err error)
  3288. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3289. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3290. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3291. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3292. unblock := make(chan bool, 1)
  3293. defer close(unblock)
  3294. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3295. // Don't read the 16KB request body. Wait until the client's
  3296. // done sending it and then return. This should cause the Server
  3297. // to then return those 16KB of flow control to the client.
  3298. <-unblock
  3299. }, optOnlyServer)
  3300. defer st.Close()
  3301. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3302. defer tr.CloseIdleConnections()
  3303. // This previously hung on the 4th iteration.
  3304. for i := 0; i < 6; i++ {
  3305. body := io.MultiReader(
  3306. io.LimitReader(neverEnding('A'), 16<<10),
  3307. funcReader(func([]byte) (n int, err error) {
  3308. unblock <- true
  3309. return 0, io.EOF
  3310. }),
  3311. )
  3312. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3313. res, err := tr.RoundTrip(req)
  3314. if err != nil {
  3315. t.Fatal(err)
  3316. }
  3317. res.Body.Close()
  3318. }
  3319. }
  3320. func TestServerIdleTimeout(t *testing.T) {
  3321. if testing.Short() {
  3322. t.Skip("skipping in short mode")
  3323. }
  3324. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3325. }, func(h2s *Server) {
  3326. h2s.IdleTimeout = 500 * time.Millisecond
  3327. })
  3328. defer st.Close()
  3329. st.greet()
  3330. ga := st.wantGoAway()
  3331. if ga.ErrCode != ErrCodeNo {
  3332. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3333. }
  3334. }
  3335. func TestServerIdleTimeout_AfterRequest(t *testing.T) {
  3336. if testing.Short() {
  3337. t.Skip("skipping in short mode")
  3338. }
  3339. const timeout = 250 * time.Millisecond
  3340. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3341. time.Sleep(timeout * 2)
  3342. }, func(h2s *Server) {
  3343. h2s.IdleTimeout = timeout
  3344. })
  3345. defer st.Close()
  3346. st.greet()
  3347. // Send a request which takes twice the timeout. Verifies the
  3348. // idle timeout doesn't fire while we're in a request:
  3349. st.bodylessReq1()
  3350. st.wantHeaders()
  3351. // But the idle timeout should be rearmed after the request
  3352. // is done:
  3353. ga := st.wantGoAway()
  3354. if ga.ErrCode != ErrCodeNo {
  3355. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3356. }
  3357. }
  3358. // grpc-go closes the Request.Body currently with a Read.
  3359. // Verify that it doesn't race.
  3360. // See https://github.com/grpc/grpc-go/pull/938
  3361. func TestRequestBodyReadCloseRace(t *testing.T) {
  3362. for i := 0; i < 100; i++ {
  3363. body := &requestBody{
  3364. pipe: &pipe{
  3365. b: new(bytes.Buffer),
  3366. },
  3367. }
  3368. body.pipe.CloseWithError(io.EOF)
  3369. done := make(chan bool, 1)
  3370. buf := make([]byte, 10)
  3371. go func() {
  3372. time.Sleep(1 * time.Millisecond)
  3373. body.Close()
  3374. done <- true
  3375. }()
  3376. body.Read(buf)
  3377. <-done
  3378. }
  3379. }
  3380. func TestIssue20704Race(t *testing.T) {
  3381. if testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
  3382. t.Skip("skipping in short mode")
  3383. }
  3384. const (
  3385. itemSize = 1 << 10
  3386. itemCount = 100
  3387. )
  3388. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3389. for i := 0; i < itemCount; i++ {
  3390. _, err := w.Write(make([]byte, itemSize))
  3391. if err != nil {
  3392. return
  3393. }
  3394. }
  3395. }, optOnlyServer)
  3396. defer st.Close()
  3397. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3398. defer tr.CloseIdleConnections()
  3399. cl := &http.Client{Transport: tr}
  3400. for i := 0; i < 1000; i++ {
  3401. resp, err := cl.Get(st.ts.URL)
  3402. if err != nil {
  3403. t.Fatal(err)
  3404. }
  3405. // Force a RST stream to the server by closing without
  3406. // reading the body:
  3407. resp.Body.Close()
  3408. }
  3409. }
  3410. func TestServer_Rejects_TooSmall(t *testing.T) {
  3411. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  3412. ioutil.ReadAll(r.Body)
  3413. return nil
  3414. }, func(st *serverTester) {
  3415. st.writeHeaders(HeadersFrameParam{
  3416. StreamID: 1, // clients send odd numbers
  3417. BlockFragment: st.encodeHeader(
  3418. ":method", "POST",
  3419. "content-length", "4",
  3420. ),
  3421. EndStream: false, // to say DATA frames are coming
  3422. EndHeaders: true,
  3423. })
  3424. st.writeData(1, true, []byte("12345"))
  3425. st.wantRSTStream(1, ErrCodeProtocol)
  3426. })
  3427. }
  3428. // Tests that a handler setting "Connection: close" results in a GOAWAY being sent,
  3429. // and the connection still completing.
  3430. func TestServerHandlerConnectionClose(t *testing.T) {
  3431. unblockHandler := make(chan bool, 1)
  3432. defer close(unblockHandler) // backup; in case of errors
  3433. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  3434. w.Header().Set("Connection", "close")
  3435. w.Header().Set("Foo", "bar")
  3436. w.(http.Flusher).Flush()
  3437. <-unblockHandler
  3438. return nil
  3439. }, func(st *serverTester) {
  3440. st.writeHeaders(HeadersFrameParam{
  3441. StreamID: 1,
  3442. BlockFragment: st.encodeHeader(),
  3443. EndStream: true,
  3444. EndHeaders: true,
  3445. })
  3446. var sawGoAway bool
  3447. var sawRes bool
  3448. for {
  3449. f, err := st.readFrame()
  3450. if err == io.EOF {
  3451. break
  3452. }
  3453. if err != nil {
  3454. t.Fatal(err)
  3455. }
  3456. switch f := f.(type) {
  3457. case *GoAwayFrame:
  3458. sawGoAway = true
  3459. unblockHandler <- true
  3460. if f.LastStreamID != 1 || f.ErrCode != ErrCodeNo {
  3461. t.Errorf("unexpected GOAWAY frame: %v", summarizeFrame(f))
  3462. }
  3463. case *HeadersFrame:
  3464. goth := st.decodeHeader(f.HeaderBlockFragment())
  3465. wanth := [][2]string{
  3466. {":status", "200"},
  3467. {"foo", "bar"},
  3468. }
  3469. if !reflect.DeepEqual(goth, wanth) {
  3470. t.Errorf("got headers %v; want %v", goth, wanth)
  3471. }
  3472. sawRes = true
  3473. case *DataFrame:
  3474. if f.StreamID != 1 || !f.StreamEnded() || len(f.Data()) != 0 {
  3475. t.Errorf("unexpected DATA frame: %v", summarizeFrame(f))
  3476. }
  3477. default:
  3478. t.Logf("unexpected frame: %v", summarizeFrame(f))
  3479. }
  3480. }
  3481. if !sawGoAway {
  3482. t.Errorf("didn't see GOAWAY")
  3483. }
  3484. if !sawRes {
  3485. t.Errorf("didn't see response")
  3486. }
  3487. })
  3488. }
  3489. func TestServer_Headers_HalfCloseRemote(t *testing.T) {
  3490. var st *serverTester
  3491. writeData := make(chan bool)
  3492. writeHeaders := make(chan bool)
  3493. leaveHandler := make(chan bool)
  3494. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3495. if st.stream(1) == nil {
  3496. t.Errorf("nil stream 1 in handler")
  3497. }
  3498. if got, want := st.streamState(1), stateOpen; got != want {
  3499. t.Errorf("in handler, state is %v; want %v", got, want)
  3500. }
  3501. writeData <- true
  3502. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  3503. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  3504. }
  3505. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  3506. t.Errorf("in handler, state is %v; want %v", got, want)
  3507. }
  3508. writeHeaders <- true
  3509. <-leaveHandler
  3510. })
  3511. st.greet()
  3512. st.writeHeaders(HeadersFrameParam{
  3513. StreamID: 1,
  3514. BlockFragment: st.encodeHeader(),
  3515. EndStream: false, // keep it open
  3516. EndHeaders: true,
  3517. })
  3518. <-writeData
  3519. st.writeData(1, true, nil)
  3520. <-writeHeaders
  3521. st.writeHeaders(HeadersFrameParam{
  3522. StreamID: 1,
  3523. BlockFragment: st.encodeHeader(),
  3524. EndStream: false, // keep it open
  3525. EndHeaders: true,
  3526. })
  3527. defer close(leaveHandler)
  3528. st.wantRSTStream(1, ErrCodeStreamClosed)
  3529. }
  3530. func TestServerGracefulShutdown(t *testing.T) {
  3531. var st *serverTester
  3532. handlerDone := make(chan struct{})
  3533. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3534. defer close(handlerDone)
  3535. go st.ts.Config.Shutdown(context.Background())
  3536. ga := st.wantGoAway()
  3537. if ga.ErrCode != ErrCodeNo {
  3538. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3539. }
  3540. if ga.LastStreamID != 1 {
  3541. t.Errorf("GOAWAY LastStreamID = %v; want 1", ga.LastStreamID)
  3542. }
  3543. w.Header().Set("x-foo", "bar")
  3544. })
  3545. defer st.Close()
  3546. st.greet()
  3547. st.bodylessReq1()
  3548. select {
  3549. case <-handlerDone:
  3550. case <-time.After(5 * time.Second):
  3551. t.Fatalf("server did not shutdown?")
  3552. }
  3553. hf := st.wantHeaders()
  3554. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3555. wanth := [][2]string{
  3556. {":status", "200"},
  3557. {"x-foo", "bar"},
  3558. {"content-length", "0"},
  3559. }
  3560. if !reflect.DeepEqual(goth, wanth) {
  3561. t.Errorf("Got headers %v; want %v", goth, wanth)
  3562. }
  3563. n, err := st.cc.Read([]byte{0})
  3564. if n != 0 || err == nil {
  3565. t.Errorf("Read = %v, %v; want 0, non-nil", n, err)
  3566. }
  3567. }