You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 

3732 lines
102 KiB

  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. serverLogBuf bytes.Buffer // logger for httptest.Server
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // If http2debug!=2, then we capture Frame debug logs that will be written
  48. // to t.Log after a test fails. The read and write logs use separate locks
  49. // and buffers so we don't accidentally introduce synchronization between
  50. // the read and write goroutines, which may hide data races.
  51. frameReadLogMu sync.Mutex
  52. frameReadLogBuf bytes.Buffer
  53. frameWriteLogMu sync.Mutex
  54. frameWriteLogBuf bytes.Buffer
  55. // writing headers:
  56. headerBuf bytes.Buffer
  57. hpackEnc *hpack.Encoder
  58. }
  59. func init() {
  60. testHookOnPanicMu = new(sync.Mutex)
  61. }
  62. func resetHooks() {
  63. testHookOnPanicMu.Lock()
  64. testHookOnPanic = nil
  65. testHookOnPanicMu.Unlock()
  66. }
  67. type serverTesterOpt string
  68. var optOnlyServer = serverTesterOpt("only_server")
  69. var optQuiet = serverTesterOpt("quiet_logging")
  70. var optFramerReuseFrames = serverTesterOpt("frame_reuse_frames")
  71. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  72. resetHooks()
  73. ts := httptest.NewUnstartedServer(handler)
  74. tlsConfig := &tls.Config{
  75. InsecureSkipVerify: true,
  76. NextProtos: []string{NextProtoTLS},
  77. }
  78. var onlyServer, quiet, framerReuseFrames bool
  79. h2server := new(Server)
  80. for _, opt := range opts {
  81. switch v := opt.(type) {
  82. case func(*tls.Config):
  83. v(tlsConfig)
  84. case func(*httptest.Server):
  85. v(ts)
  86. case func(*Server):
  87. v(h2server)
  88. case serverTesterOpt:
  89. switch v {
  90. case optOnlyServer:
  91. onlyServer = true
  92. case optQuiet:
  93. quiet = true
  94. case optFramerReuseFrames:
  95. framerReuseFrames = true
  96. }
  97. case func(net.Conn, http.ConnState):
  98. ts.Config.ConnState = v
  99. default:
  100. t.Fatalf("unknown newServerTester option type %T", v)
  101. }
  102. }
  103. ConfigureServer(ts.Config, h2server)
  104. st := &serverTester{
  105. t: t,
  106. ts: ts,
  107. }
  108. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  109. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  110. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  111. if quiet {
  112. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  113. } else {
  114. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, &st.serverLogBuf), "", log.LstdFlags)
  115. }
  116. ts.StartTLS()
  117. if VerboseLogs {
  118. t.Logf("Running test server at: %s", ts.URL)
  119. }
  120. testHookGetServerConn = func(v *serverConn) {
  121. st.scMu.Lock()
  122. defer st.scMu.Unlock()
  123. st.sc = v
  124. st.sc.testHookCh = make(chan func(int))
  125. }
  126. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  127. if !onlyServer {
  128. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  129. if err != nil {
  130. t.Fatal(err)
  131. }
  132. st.cc = cc
  133. st.fr = NewFramer(cc, cc)
  134. if framerReuseFrames {
  135. st.fr.SetReuseFrames()
  136. }
  137. if !logFrameReads && !logFrameWrites {
  138. st.fr.debugReadLoggerf = func(m string, v ...interface{}) {
  139. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  140. st.frameReadLogMu.Lock()
  141. fmt.Fprintf(&st.frameReadLogBuf, m, v...)
  142. st.frameReadLogMu.Unlock()
  143. }
  144. st.fr.debugWriteLoggerf = func(m string, v ...interface{}) {
  145. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  146. st.frameWriteLogMu.Lock()
  147. fmt.Fprintf(&st.frameWriteLogBuf, m, v...)
  148. st.frameWriteLogMu.Unlock()
  149. }
  150. st.fr.logReads = true
  151. st.fr.logWrites = true
  152. }
  153. }
  154. return st
  155. }
  156. func (st *serverTester) closeConn() {
  157. st.scMu.Lock()
  158. defer st.scMu.Unlock()
  159. st.sc.conn.Close()
  160. }
  161. func (st *serverTester) addLogFilter(phrase string) {
  162. st.logFilter = append(st.logFilter, phrase)
  163. }
  164. func (st *serverTester) stream(id uint32) *stream {
  165. ch := make(chan *stream, 1)
  166. st.sc.testHookCh <- func(int) {
  167. ch <- st.sc.streams[id]
  168. }
  169. return <-ch
  170. }
  171. func (st *serverTester) streamState(id uint32) streamState {
  172. ch := make(chan streamState, 1)
  173. st.sc.testHookCh <- func(int) {
  174. state, _ := st.sc.state(id)
  175. ch <- state
  176. }
  177. return <-ch
  178. }
  179. // loopNum reports how many times this conn's select loop has gone around.
  180. func (st *serverTester) loopNum() int {
  181. lastc := make(chan int, 1)
  182. st.sc.testHookCh <- func(loopNum int) {
  183. lastc <- loopNum
  184. }
  185. return <-lastc
  186. }
  187. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  188. // The heuristic is that the server connection's serve loop must schedule
  189. // 50 times in a row without any channel sends or receives occurring.
  190. func (st *serverTester) awaitIdle() {
  191. remain := 50
  192. last := st.loopNum()
  193. for remain > 0 {
  194. n := st.loopNum()
  195. if n == last+1 {
  196. remain--
  197. } else {
  198. remain = 50
  199. }
  200. last = n
  201. }
  202. }
  203. func (st *serverTester) Close() {
  204. if st.t.Failed() {
  205. st.frameReadLogMu.Lock()
  206. if st.frameReadLogBuf.Len() > 0 {
  207. st.t.Logf("Framer read log:\n%s", st.frameReadLogBuf.String())
  208. }
  209. st.frameReadLogMu.Unlock()
  210. st.frameWriteLogMu.Lock()
  211. if st.frameWriteLogBuf.Len() > 0 {
  212. st.t.Logf("Framer write log:\n%s", st.frameWriteLogBuf.String())
  213. }
  214. st.frameWriteLogMu.Unlock()
  215. // If we failed already (and are likely in a Fatal,
  216. // unwindowing), force close the connection, so the
  217. // httptest.Server doesn't wait forever for the conn
  218. // to close.
  219. if st.cc != nil {
  220. st.cc.Close()
  221. }
  222. }
  223. st.ts.Close()
  224. if st.cc != nil {
  225. st.cc.Close()
  226. }
  227. log.SetOutput(os.Stderr)
  228. }
  229. // greet initiates the client's HTTP/2 connection into a state where
  230. // frames may be sent.
  231. func (st *serverTester) greet() {
  232. st.greetAndCheckSettings(func(Setting) error { return nil })
  233. }
  234. func (st *serverTester) greetAndCheckSettings(checkSetting func(s Setting) error) {
  235. st.writePreface()
  236. st.writeInitialSettings()
  237. st.wantSettings().ForeachSetting(checkSetting)
  238. st.writeSettingsAck()
  239. // The initial WINDOW_UPDATE and SETTINGS ACK can come in any order.
  240. var gotSettingsAck bool
  241. var gotWindowUpdate bool
  242. for i := 0; i < 2; i++ {
  243. f, err := st.readFrame()
  244. if err != nil {
  245. st.t.Fatal(err)
  246. }
  247. switch f := f.(type) {
  248. case *SettingsFrame:
  249. if !f.Header().Flags.Has(FlagSettingsAck) {
  250. st.t.Fatal("Settings Frame didn't have ACK set")
  251. }
  252. gotSettingsAck = true
  253. case *WindowUpdateFrame:
  254. if f.FrameHeader.StreamID != 0 {
  255. st.t.Fatalf("WindowUpdate StreamID = %d; want 0", f.FrameHeader.StreamID, 0)
  256. }
  257. incr := uint32((&Server{}).initialConnRecvWindowSize() - initialWindowSize)
  258. if f.Increment != incr {
  259. st.t.Fatalf("WindowUpdate increment = %d; want %d", f.Increment, incr)
  260. }
  261. gotWindowUpdate = true
  262. default:
  263. st.t.Fatalf("Wanting a settings ACK or window update, received a %T", f)
  264. }
  265. }
  266. if !gotSettingsAck {
  267. st.t.Fatalf("Didn't get a settings ACK")
  268. }
  269. if !gotWindowUpdate {
  270. st.t.Fatalf("Didn't get a window update")
  271. }
  272. }
  273. func (st *serverTester) writePreface() {
  274. n, err := st.cc.Write(clientPreface)
  275. if err != nil {
  276. st.t.Fatalf("Error writing client preface: %v", err)
  277. }
  278. if n != len(clientPreface) {
  279. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  280. }
  281. }
  282. func (st *serverTester) writeInitialSettings() {
  283. if err := st.fr.WriteSettings(); err != nil {
  284. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  285. }
  286. }
  287. func (st *serverTester) writeSettingsAck() {
  288. if err := st.fr.WriteSettingsAck(); err != nil {
  289. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  290. }
  291. }
  292. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  293. if err := st.fr.WriteHeaders(p); err != nil {
  294. st.t.Fatalf("Error writing HEADERS: %v", err)
  295. }
  296. }
  297. func (st *serverTester) writePriority(id uint32, p PriorityParam) {
  298. if err := st.fr.WritePriority(id, p); err != nil {
  299. st.t.Fatalf("Error writing PRIORITY: %v", err)
  300. }
  301. }
  302. func (st *serverTester) encodeHeaderField(k, v string) {
  303. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  304. if err != nil {
  305. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  306. }
  307. }
  308. // encodeHeaderRaw is the magic-free version of encodeHeader.
  309. // It takes 0 or more (k, v) pairs and encodes them.
  310. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  311. if len(headers)%2 == 1 {
  312. panic("odd number of kv args")
  313. }
  314. st.headerBuf.Reset()
  315. for len(headers) > 0 {
  316. k, v := headers[0], headers[1]
  317. st.encodeHeaderField(k, v)
  318. headers = headers[2:]
  319. }
  320. return st.headerBuf.Bytes()
  321. }
  322. // encodeHeader encodes headers and returns their HPACK bytes. headers
  323. // must contain an even number of key/value pairs. There may be
  324. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  325. // :scheme headers default to GET, / and https. The :authority header
  326. // defaults to st.ts.Listener.Addr().
  327. func (st *serverTester) encodeHeader(headers ...string) []byte {
  328. if len(headers)%2 == 1 {
  329. panic("odd number of kv args")
  330. }
  331. st.headerBuf.Reset()
  332. defaultAuthority := st.ts.Listener.Addr().String()
  333. if len(headers) == 0 {
  334. // Fast path, mostly for benchmarks, so test code doesn't pollute
  335. // profiles when we're looking to improve server allocations.
  336. st.encodeHeaderField(":method", "GET")
  337. st.encodeHeaderField(":scheme", "https")
  338. st.encodeHeaderField(":authority", defaultAuthority)
  339. st.encodeHeaderField(":path", "/")
  340. return st.headerBuf.Bytes()
  341. }
  342. if len(headers) == 2 && headers[0] == ":method" {
  343. // Another fast path for benchmarks.
  344. st.encodeHeaderField(":method", headers[1])
  345. st.encodeHeaderField(":scheme", "https")
  346. st.encodeHeaderField(":authority", defaultAuthority)
  347. st.encodeHeaderField(":path", "/")
  348. return st.headerBuf.Bytes()
  349. }
  350. pseudoCount := map[string]int{}
  351. keys := []string{":method", ":scheme", ":authority", ":path"}
  352. vals := map[string][]string{
  353. ":method": {"GET"},
  354. ":scheme": {"https"},
  355. ":authority": {defaultAuthority},
  356. ":path": {"/"},
  357. }
  358. for len(headers) > 0 {
  359. k, v := headers[0], headers[1]
  360. headers = headers[2:]
  361. if _, ok := vals[k]; !ok {
  362. keys = append(keys, k)
  363. }
  364. if strings.HasPrefix(k, ":") {
  365. pseudoCount[k]++
  366. if pseudoCount[k] == 1 {
  367. vals[k] = []string{v}
  368. } else {
  369. // Allows testing of invalid headers w/ dup pseudo fields.
  370. vals[k] = append(vals[k], v)
  371. }
  372. } else {
  373. vals[k] = append(vals[k], v)
  374. }
  375. }
  376. for _, k := range keys {
  377. for _, v := range vals[k] {
  378. st.encodeHeaderField(k, v)
  379. }
  380. }
  381. return st.headerBuf.Bytes()
  382. }
  383. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  384. func (st *serverTester) bodylessReq1(headers ...string) {
  385. st.writeHeaders(HeadersFrameParam{
  386. StreamID: 1, // clients send odd numbers
  387. BlockFragment: st.encodeHeader(headers...),
  388. EndStream: true,
  389. EndHeaders: true,
  390. })
  391. }
  392. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  393. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  394. st.t.Fatalf("Error writing DATA: %v", err)
  395. }
  396. }
  397. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  398. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  399. st.t.Fatalf("Error writing DATA: %v", err)
  400. }
  401. }
  402. func readFrameTimeout(fr *Framer, wait time.Duration) (Frame, error) {
  403. ch := make(chan interface{}, 1)
  404. go func() {
  405. fr, err := fr.ReadFrame()
  406. if err != nil {
  407. ch <- err
  408. } else {
  409. ch <- fr
  410. }
  411. }()
  412. t := time.NewTimer(wait)
  413. select {
  414. case v := <-ch:
  415. t.Stop()
  416. if fr, ok := v.(Frame); ok {
  417. return fr, nil
  418. }
  419. return nil, v.(error)
  420. case <-t.C:
  421. return nil, errors.New("timeout waiting for frame")
  422. }
  423. }
  424. func (st *serverTester) readFrame() (Frame, error) {
  425. return readFrameTimeout(st.fr, 2*time.Second)
  426. }
  427. func (st *serverTester) wantHeaders() *HeadersFrame {
  428. f, err := st.readFrame()
  429. if err != nil {
  430. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  431. }
  432. hf, ok := f.(*HeadersFrame)
  433. if !ok {
  434. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  435. }
  436. return hf
  437. }
  438. func (st *serverTester) wantContinuation() *ContinuationFrame {
  439. f, err := st.readFrame()
  440. if err != nil {
  441. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  442. }
  443. cf, ok := f.(*ContinuationFrame)
  444. if !ok {
  445. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  446. }
  447. return cf
  448. }
  449. func (st *serverTester) wantData() *DataFrame {
  450. f, err := st.readFrame()
  451. if err != nil {
  452. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  453. }
  454. df, ok := f.(*DataFrame)
  455. if !ok {
  456. st.t.Fatalf("got a %T; want *DataFrame", f)
  457. }
  458. return df
  459. }
  460. func (st *serverTester) wantSettings() *SettingsFrame {
  461. f, err := st.readFrame()
  462. if err != nil {
  463. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  464. }
  465. sf, ok := f.(*SettingsFrame)
  466. if !ok {
  467. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  468. }
  469. return sf
  470. }
  471. func (st *serverTester) wantPing() *PingFrame {
  472. f, err := st.readFrame()
  473. if err != nil {
  474. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  475. }
  476. pf, ok := f.(*PingFrame)
  477. if !ok {
  478. st.t.Fatalf("got a %T; want *PingFrame", f)
  479. }
  480. return pf
  481. }
  482. func (st *serverTester) wantGoAway() *GoAwayFrame {
  483. f, err := st.readFrame()
  484. if err != nil {
  485. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  486. }
  487. gf, ok := f.(*GoAwayFrame)
  488. if !ok {
  489. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  490. }
  491. return gf
  492. }
  493. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  494. f, err := st.readFrame()
  495. if err != nil {
  496. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  497. }
  498. rs, ok := f.(*RSTStreamFrame)
  499. if !ok {
  500. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  501. }
  502. if rs.FrameHeader.StreamID != streamID {
  503. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  504. }
  505. if rs.ErrCode != errCode {
  506. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  507. }
  508. }
  509. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  510. f, err := st.readFrame()
  511. if err != nil {
  512. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  513. }
  514. wu, ok := f.(*WindowUpdateFrame)
  515. if !ok {
  516. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  517. }
  518. if wu.FrameHeader.StreamID != streamID {
  519. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  520. }
  521. if wu.Increment != incr {
  522. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  523. }
  524. }
  525. func (st *serverTester) wantSettingsAck() {
  526. f, err := st.readFrame()
  527. if err != nil {
  528. st.t.Fatal(err)
  529. }
  530. sf, ok := f.(*SettingsFrame)
  531. if !ok {
  532. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  533. }
  534. if !sf.Header().Flags.Has(FlagSettingsAck) {
  535. st.t.Fatal("Settings Frame didn't have ACK set")
  536. }
  537. }
  538. func (st *serverTester) wantPushPromise() *PushPromiseFrame {
  539. f, err := st.readFrame()
  540. if err != nil {
  541. st.t.Fatal(err)
  542. }
  543. ppf, ok := f.(*PushPromiseFrame)
  544. if !ok {
  545. st.t.Fatalf("Wanted PushPromise, received %T", ppf)
  546. }
  547. return ppf
  548. }
  549. func TestServer(t *testing.T) {
  550. gotReq := make(chan bool, 1)
  551. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  552. w.Header().Set("Foo", "Bar")
  553. gotReq <- true
  554. })
  555. defer st.Close()
  556. covers("3.5", `
  557. The server connection preface consists of a potentially empty
  558. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  559. server sends in the HTTP/2 connection.
  560. `)
  561. st.greet()
  562. st.writeHeaders(HeadersFrameParam{
  563. StreamID: 1, // clients send odd numbers
  564. BlockFragment: st.encodeHeader(),
  565. EndStream: true, // no DATA frames
  566. EndHeaders: true,
  567. })
  568. select {
  569. case <-gotReq:
  570. case <-time.After(2 * time.Second):
  571. t.Error("timeout waiting for request")
  572. }
  573. }
  574. func TestServer_Request_Get(t *testing.T) {
  575. testServerRequest(t, func(st *serverTester) {
  576. st.writeHeaders(HeadersFrameParam{
  577. StreamID: 1, // clients send odd numbers
  578. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  579. EndStream: true, // no DATA frames
  580. EndHeaders: true,
  581. })
  582. }, func(r *http.Request) {
  583. if r.Method != "GET" {
  584. t.Errorf("Method = %q; want GET", r.Method)
  585. }
  586. if r.URL.Path != "/" {
  587. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  588. }
  589. if r.ContentLength != 0 {
  590. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  591. }
  592. if r.Close {
  593. t.Error("Close = true; want false")
  594. }
  595. if !strings.Contains(r.RemoteAddr, ":") {
  596. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  597. }
  598. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  599. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  600. }
  601. wantHeader := http.Header{
  602. "Foo-Bar": []string{"some-value"},
  603. }
  604. if !reflect.DeepEqual(r.Header, wantHeader) {
  605. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  606. }
  607. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  608. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  609. }
  610. })
  611. }
  612. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  613. testServerRequest(t, func(st *serverTester) {
  614. st.writeHeaders(HeadersFrameParam{
  615. StreamID: 1, // clients send odd numbers
  616. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  617. EndStream: true, // no DATA frames
  618. EndHeaders: true,
  619. })
  620. }, func(r *http.Request) {
  621. if r.RequestURI != "/%2f/" {
  622. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  623. }
  624. if r.URL.Path != "///" {
  625. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  626. }
  627. })
  628. }
  629. // TODO: add a test with EndStream=true on the HEADERS but setting a
  630. // Content-Length anyway. Should we just omit it and force it to
  631. // zero?
  632. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  633. testServerRequest(t, func(st *serverTester) {
  634. st.writeHeaders(HeadersFrameParam{
  635. StreamID: 1, // clients send odd numbers
  636. BlockFragment: st.encodeHeader(":method", "POST"),
  637. EndStream: true,
  638. EndHeaders: true,
  639. })
  640. }, func(r *http.Request) {
  641. if r.Method != "POST" {
  642. t.Errorf("Method = %q; want POST", r.Method)
  643. }
  644. if r.ContentLength != 0 {
  645. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  646. }
  647. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  648. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  649. }
  650. })
  651. }
  652. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  653. testBodyContents(t, -1, "", func(st *serverTester) {
  654. st.writeHeaders(HeadersFrameParam{
  655. StreamID: 1, // clients send odd numbers
  656. BlockFragment: st.encodeHeader(":method", "POST"),
  657. EndStream: false, // to say DATA frames are coming
  658. EndHeaders: true,
  659. })
  660. st.writeData(1, true, nil) // just kidding. empty body.
  661. })
  662. }
  663. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  664. const content = "Some content"
  665. testBodyContents(t, -1, content, func(st *serverTester) {
  666. st.writeHeaders(HeadersFrameParam{
  667. StreamID: 1, // clients send odd numbers
  668. BlockFragment: st.encodeHeader(":method", "POST"),
  669. EndStream: false, // to say DATA frames are coming
  670. EndHeaders: true,
  671. })
  672. st.writeData(1, true, []byte(content))
  673. })
  674. }
  675. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  676. const content = "Some content"
  677. testBodyContents(t, -1, content, func(st *serverTester) {
  678. st.writeHeaders(HeadersFrameParam{
  679. StreamID: 1, // clients send odd numbers
  680. BlockFragment: st.encodeHeader(":method", "POST"),
  681. EndStream: false, // to say DATA frames are coming
  682. EndHeaders: true,
  683. })
  684. st.writeData(1, false, []byte(content[:5]))
  685. st.writeData(1, true, []byte(content[5:]))
  686. })
  687. }
  688. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  689. const content = "Some content"
  690. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  691. st.writeHeaders(HeadersFrameParam{
  692. StreamID: 1, // clients send odd numbers
  693. BlockFragment: st.encodeHeader(
  694. ":method", "POST",
  695. "content-length", strconv.Itoa(len(content)),
  696. ),
  697. EndStream: false, // to say DATA frames are coming
  698. EndHeaders: true,
  699. })
  700. st.writeData(1, true, []byte(content))
  701. })
  702. }
  703. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  704. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  705. func(st *serverTester) {
  706. st.writeHeaders(HeadersFrameParam{
  707. StreamID: 1, // clients send odd numbers
  708. BlockFragment: st.encodeHeader(
  709. ":method", "POST",
  710. "content-length", "3",
  711. ),
  712. EndStream: false, // to say DATA frames are coming
  713. EndHeaders: true,
  714. })
  715. st.writeData(1, true, []byte("12"))
  716. })
  717. }
  718. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  719. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  720. func(st *serverTester) {
  721. st.writeHeaders(HeadersFrameParam{
  722. StreamID: 1, // clients send odd numbers
  723. BlockFragment: st.encodeHeader(
  724. ":method", "POST",
  725. "content-length", "4",
  726. ),
  727. EndStream: false, // to say DATA frames are coming
  728. EndHeaders: true,
  729. })
  730. st.writeData(1, true, []byte("12345"))
  731. })
  732. }
  733. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  734. testServerRequest(t, write, func(r *http.Request) {
  735. if r.Method != "POST" {
  736. t.Errorf("Method = %q; want POST", r.Method)
  737. }
  738. if r.ContentLength != wantContentLength {
  739. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  740. }
  741. all, err := ioutil.ReadAll(r.Body)
  742. if err != nil {
  743. t.Fatal(err)
  744. }
  745. if string(all) != wantBody {
  746. t.Errorf("Read = %q; want %q", all, wantBody)
  747. }
  748. if err := r.Body.Close(); err != nil {
  749. t.Fatalf("Close: %v", err)
  750. }
  751. })
  752. }
  753. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  754. testServerRequest(t, write, func(r *http.Request) {
  755. if r.Method != "POST" {
  756. t.Errorf("Method = %q; want POST", r.Method)
  757. }
  758. if r.ContentLength != wantContentLength {
  759. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  760. }
  761. all, err := ioutil.ReadAll(r.Body)
  762. if err == nil {
  763. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  764. wantReadError, all)
  765. }
  766. if !strings.Contains(err.Error(), wantReadError) {
  767. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  768. }
  769. if err := r.Body.Close(); err != nil {
  770. t.Fatalf("Close: %v", err)
  771. }
  772. })
  773. }
  774. // Using a Host header, instead of :authority
  775. func TestServer_Request_Get_Host(t *testing.T) {
  776. const host = "example.com"
  777. testServerRequest(t, func(st *serverTester) {
  778. st.writeHeaders(HeadersFrameParam{
  779. StreamID: 1, // clients send odd numbers
  780. BlockFragment: st.encodeHeader(":authority", "", "host", host),
  781. EndStream: true,
  782. EndHeaders: true,
  783. })
  784. }, func(r *http.Request) {
  785. if r.Host != host {
  786. t.Errorf("Host = %q; want %q", r.Host, host)
  787. }
  788. })
  789. }
  790. // Using an :authority pseudo-header, instead of Host
  791. func TestServer_Request_Get_Authority(t *testing.T) {
  792. const host = "example.com"
  793. testServerRequest(t, func(st *serverTester) {
  794. st.writeHeaders(HeadersFrameParam{
  795. StreamID: 1, // clients send odd numbers
  796. BlockFragment: st.encodeHeader(":authority", host),
  797. EndStream: true,
  798. EndHeaders: true,
  799. })
  800. }, func(r *http.Request) {
  801. if r.Host != host {
  802. t.Errorf("Host = %q; want %q", r.Host, host)
  803. }
  804. })
  805. }
  806. func TestServer_Request_WithContinuation(t *testing.T) {
  807. wantHeader := http.Header{
  808. "Foo-One": []string{"value-one"},
  809. "Foo-Two": []string{"value-two"},
  810. "Foo-Three": []string{"value-three"},
  811. }
  812. testServerRequest(t, func(st *serverTester) {
  813. fullHeaders := st.encodeHeader(
  814. "foo-one", "value-one",
  815. "foo-two", "value-two",
  816. "foo-three", "value-three",
  817. )
  818. remain := fullHeaders
  819. chunks := 0
  820. for len(remain) > 0 {
  821. const maxChunkSize = 5
  822. chunk := remain
  823. if len(chunk) > maxChunkSize {
  824. chunk = chunk[:maxChunkSize]
  825. }
  826. remain = remain[len(chunk):]
  827. if chunks == 0 {
  828. st.writeHeaders(HeadersFrameParam{
  829. StreamID: 1, // clients send odd numbers
  830. BlockFragment: chunk,
  831. EndStream: true, // no DATA frames
  832. EndHeaders: false, // we'll have continuation frames
  833. })
  834. } else {
  835. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  836. if err != nil {
  837. t.Fatal(err)
  838. }
  839. }
  840. chunks++
  841. }
  842. if chunks < 2 {
  843. t.Fatal("too few chunks")
  844. }
  845. }, func(r *http.Request) {
  846. if !reflect.DeepEqual(r.Header, wantHeader) {
  847. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  848. }
  849. })
  850. }
  851. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  852. func TestServer_Request_CookieConcat(t *testing.T) {
  853. const host = "example.com"
  854. testServerRequest(t, func(st *serverTester) {
  855. st.bodylessReq1(
  856. ":authority", host,
  857. "cookie", "a=b",
  858. "cookie", "c=d",
  859. "cookie", "e=f",
  860. )
  861. }, func(r *http.Request) {
  862. const want = "a=b; c=d; e=f"
  863. if got := r.Header.Get("Cookie"); got != want {
  864. t.Errorf("Cookie = %q; want %q", got, want)
  865. }
  866. })
  867. }
  868. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  869. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  870. }
  871. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  872. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  873. }
  874. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  875. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  876. }
  877. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  878. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  879. }
  880. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  881. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  882. }
  883. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  884. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  885. }
  886. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  887. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  888. }
  889. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  890. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  891. }
  892. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  893. // 8.1.2.3 Request Pseudo-Header Fields
  894. // "All HTTP/2 requests MUST include exactly one valid value" ...
  895. testRejectRequest(t, func(st *serverTester) {
  896. st.addLogFilter("duplicate pseudo-header")
  897. st.bodylessReq1(":method", "GET", ":method", "POST")
  898. })
  899. }
  900. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  901. // 8.1.2.3 Request Pseudo-Header Fields
  902. // "All pseudo-header fields MUST appear in the header block
  903. // before regular header fields. Any request or response that
  904. // contains a pseudo-header field that appears in a header
  905. // block after a regular header field MUST be treated as
  906. // malformed (Section 8.1.2.6)."
  907. testRejectRequest(t, func(st *serverTester) {
  908. st.addLogFilter("pseudo-header after regular header")
  909. var buf bytes.Buffer
  910. enc := hpack.NewEncoder(&buf)
  911. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  912. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  913. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  914. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  915. st.writeHeaders(HeadersFrameParam{
  916. StreamID: 1, // clients send odd numbers
  917. BlockFragment: buf.Bytes(),
  918. EndStream: true,
  919. EndHeaders: true,
  920. })
  921. })
  922. }
  923. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  924. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  925. }
  926. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  927. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  928. }
  929. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  930. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  931. }
  932. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  933. testRejectRequest(t, func(st *serverTester) {
  934. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  935. st.bodylessReq1(":unknown_thing", "")
  936. })
  937. }
  938. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  939. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  940. t.Error("server request made it to handler; should've been rejected")
  941. })
  942. defer st.Close()
  943. st.greet()
  944. send(st)
  945. st.wantRSTStream(1, ErrCodeProtocol)
  946. }
  947. func testRejectRequestWithProtocolError(t *testing.T, send func(*serverTester)) {
  948. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  949. t.Error("server request made it to handler; should've been rejected")
  950. }, optQuiet)
  951. defer st.Close()
  952. st.greet()
  953. send(st)
  954. gf := st.wantGoAway()
  955. if gf.ErrCode != ErrCodeProtocol {
  956. t.Errorf("err code = %v; want %v", gf.ErrCode, ErrCodeProtocol)
  957. }
  958. }
  959. // Section 5.1, on idle connections: "Receiving any frame other than
  960. // HEADERS or PRIORITY on a stream in this state MUST be treated as a
  961. // connection error (Section 5.4.1) of type PROTOCOL_ERROR."
  962. func TestRejectFrameOnIdle_WindowUpdate(t *testing.T) {
  963. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  964. st.fr.WriteWindowUpdate(123, 456)
  965. })
  966. }
  967. func TestRejectFrameOnIdle_Data(t *testing.T) {
  968. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  969. st.fr.WriteData(123, true, nil)
  970. })
  971. }
  972. func TestRejectFrameOnIdle_RSTStream(t *testing.T) {
  973. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  974. st.fr.WriteRSTStream(123, ErrCodeCancel)
  975. })
  976. }
  977. func TestServer_Request_Connect(t *testing.T) {
  978. testServerRequest(t, func(st *serverTester) {
  979. st.writeHeaders(HeadersFrameParam{
  980. StreamID: 1,
  981. BlockFragment: st.encodeHeaderRaw(
  982. ":method", "CONNECT",
  983. ":authority", "example.com:123",
  984. ),
  985. EndStream: true,
  986. EndHeaders: true,
  987. })
  988. }, func(r *http.Request) {
  989. if g, w := r.Method, "CONNECT"; g != w {
  990. t.Errorf("Method = %q; want %q", g, w)
  991. }
  992. if g, w := r.RequestURI, "example.com:123"; g != w {
  993. t.Errorf("RequestURI = %q; want %q", g, w)
  994. }
  995. if g, w := r.URL.Host, "example.com:123"; g != w {
  996. t.Errorf("URL.Host = %q; want %q", g, w)
  997. }
  998. })
  999. }
  1000. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  1001. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1002. st.writeHeaders(HeadersFrameParam{
  1003. StreamID: 1,
  1004. BlockFragment: st.encodeHeaderRaw(
  1005. ":method", "CONNECT",
  1006. ":authority", "example.com:123",
  1007. ":path", "/bogus",
  1008. ),
  1009. EndStream: true,
  1010. EndHeaders: true,
  1011. })
  1012. })
  1013. }
  1014. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  1015. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1016. st.writeHeaders(HeadersFrameParam{
  1017. StreamID: 1,
  1018. BlockFragment: st.encodeHeaderRaw(
  1019. ":method", "CONNECT",
  1020. ":authority", "example.com:123",
  1021. ":scheme", "https",
  1022. ),
  1023. EndStream: true,
  1024. EndHeaders: true,
  1025. })
  1026. })
  1027. }
  1028. func TestServer_Ping(t *testing.T) {
  1029. st := newServerTester(t, nil)
  1030. defer st.Close()
  1031. st.greet()
  1032. // Server should ignore this one, since it has ACK set.
  1033. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  1034. if err := st.fr.WritePing(true, ackPingData); err != nil {
  1035. t.Fatal(err)
  1036. }
  1037. // But the server should reply to this one, since ACK is false.
  1038. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  1039. if err := st.fr.WritePing(false, pingData); err != nil {
  1040. t.Fatal(err)
  1041. }
  1042. pf := st.wantPing()
  1043. if !pf.Flags.Has(FlagPingAck) {
  1044. t.Error("response ping doesn't have ACK set")
  1045. }
  1046. if pf.Data != pingData {
  1047. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  1048. }
  1049. }
  1050. func TestServer_RejectsLargeFrames(t *testing.T) {
  1051. if runtime.GOOS == "windows" {
  1052. t.Skip("see golang.org/issue/13434")
  1053. }
  1054. st := newServerTester(t, nil)
  1055. defer st.Close()
  1056. st.greet()
  1057. // Write too large of a frame (too large by one byte)
  1058. // We ignore the return value because it's expected that the server
  1059. // will only read the first 9 bytes (the headre) and then disconnect.
  1060. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  1061. gf := st.wantGoAway()
  1062. if gf.ErrCode != ErrCodeFrameSize {
  1063. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  1064. }
  1065. if st.serverLogBuf.Len() != 0 {
  1066. // Previously we spun here for a bit until the GOAWAY disconnect
  1067. // timer fired, logging while we fired.
  1068. t.Errorf("unexpected server output: %.500s\n", st.serverLogBuf.Bytes())
  1069. }
  1070. }
  1071. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  1072. puppet := newHandlerPuppet()
  1073. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1074. puppet.act(w, r)
  1075. })
  1076. defer st.Close()
  1077. defer puppet.done()
  1078. st.greet()
  1079. st.writeHeaders(HeadersFrameParam{
  1080. StreamID: 1, // clients send odd numbers
  1081. BlockFragment: st.encodeHeader(":method", "POST"),
  1082. EndStream: false, // data coming
  1083. EndHeaders: true,
  1084. })
  1085. st.writeData(1, false, []byte("abcdef"))
  1086. puppet.do(readBodyHandler(t, "abc"))
  1087. st.wantWindowUpdate(0, 3)
  1088. st.wantWindowUpdate(1, 3)
  1089. puppet.do(readBodyHandler(t, "def"))
  1090. st.wantWindowUpdate(0, 3)
  1091. st.wantWindowUpdate(1, 3)
  1092. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  1093. puppet.do(readBodyHandler(t, "ghi"))
  1094. puppet.do(readBodyHandler(t, "jkl"))
  1095. st.wantWindowUpdate(0, 3)
  1096. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  1097. }
  1098. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  1099. // See golang.org/issue/16556
  1100. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  1101. puppet := newHandlerPuppet()
  1102. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1103. puppet.act(w, r)
  1104. })
  1105. defer st.Close()
  1106. defer puppet.done()
  1107. st.greet()
  1108. st.writeHeaders(HeadersFrameParam{
  1109. StreamID: 1,
  1110. BlockFragment: st.encodeHeader(":method", "POST"),
  1111. EndStream: false,
  1112. EndHeaders: true,
  1113. })
  1114. st.writeDataPadded(1, false, []byte("abcdef"), []byte{0, 0, 0, 0})
  1115. // Expect to immediately get our 5 bytes of padding back for
  1116. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1117. st.wantWindowUpdate(0, 5)
  1118. st.wantWindowUpdate(1, 5)
  1119. puppet.do(readBodyHandler(t, "abc"))
  1120. st.wantWindowUpdate(0, 3)
  1121. st.wantWindowUpdate(1, 3)
  1122. puppet.do(readBodyHandler(t, "def"))
  1123. st.wantWindowUpdate(0, 3)
  1124. st.wantWindowUpdate(1, 3)
  1125. }
  1126. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1127. st := newServerTester(t, nil)
  1128. defer st.Close()
  1129. st.greet()
  1130. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1131. t.Fatal(err)
  1132. }
  1133. gf := st.wantGoAway()
  1134. if gf.ErrCode != ErrCodeFlowControl {
  1135. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1136. }
  1137. if gf.LastStreamID != 0 {
  1138. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1139. }
  1140. }
  1141. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1142. inHandler := make(chan bool)
  1143. blockHandler := make(chan bool)
  1144. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1145. inHandler <- true
  1146. <-blockHandler
  1147. })
  1148. defer st.Close()
  1149. defer close(blockHandler)
  1150. st.greet()
  1151. st.writeHeaders(HeadersFrameParam{
  1152. StreamID: 1,
  1153. BlockFragment: st.encodeHeader(":method", "POST"),
  1154. EndStream: false, // keep it open
  1155. EndHeaders: true,
  1156. })
  1157. <-inHandler
  1158. // Send a bogus window update:
  1159. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1160. t.Fatal(err)
  1161. }
  1162. st.wantRSTStream(1, ErrCodeFlowControl)
  1163. }
  1164. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1165. // then runs fn once in the handler, and verifies that the error returned from
  1166. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1167. func testServerPostUnblock(t *testing.T,
  1168. handler func(http.ResponseWriter, *http.Request) error,
  1169. fn func(*serverTester),
  1170. checkErr func(error),
  1171. otherHeaders ...string) {
  1172. inHandler := make(chan bool)
  1173. errc := make(chan error, 1)
  1174. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1175. inHandler <- true
  1176. errc <- handler(w, r)
  1177. })
  1178. defer st.Close()
  1179. st.greet()
  1180. st.writeHeaders(HeadersFrameParam{
  1181. StreamID: 1,
  1182. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1183. EndStream: false, // keep it open
  1184. EndHeaders: true,
  1185. })
  1186. <-inHandler
  1187. fn(st)
  1188. select {
  1189. case err := <-errc:
  1190. if checkErr != nil {
  1191. checkErr(err)
  1192. }
  1193. case <-time.After(5 * time.Second):
  1194. t.Fatal("timeout waiting for Handler to return")
  1195. }
  1196. }
  1197. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1198. testServerPostUnblock(t,
  1199. func(w http.ResponseWriter, r *http.Request) (err error) {
  1200. _, err = r.Body.Read(make([]byte, 1))
  1201. return
  1202. },
  1203. func(st *serverTester) {
  1204. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1205. t.Fatal(err)
  1206. }
  1207. },
  1208. func(err error) {
  1209. want := StreamError{StreamID: 0x1, Code: 0x8}
  1210. if !reflect.DeepEqual(err, want) {
  1211. t.Errorf("Read error = %v; want %v", err, want)
  1212. }
  1213. },
  1214. )
  1215. }
  1216. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1217. // Run this test a bunch, because it doesn't always
  1218. // deadlock. But with a bunch, it did.
  1219. n := 50
  1220. if testing.Short() {
  1221. n = 5
  1222. }
  1223. for i := 0; i < n; i++ {
  1224. testServer_RSTStream_Unblocks_Header_Write(t)
  1225. }
  1226. }
  1227. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1228. inHandler := make(chan bool, 1)
  1229. unblockHandler := make(chan bool, 1)
  1230. headerWritten := make(chan bool, 1)
  1231. wroteRST := make(chan bool, 1)
  1232. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1233. inHandler <- true
  1234. <-wroteRST
  1235. w.Header().Set("foo", "bar")
  1236. w.WriteHeader(200)
  1237. w.(http.Flusher).Flush()
  1238. headerWritten <- true
  1239. <-unblockHandler
  1240. })
  1241. defer st.Close()
  1242. st.greet()
  1243. st.writeHeaders(HeadersFrameParam{
  1244. StreamID: 1,
  1245. BlockFragment: st.encodeHeader(":method", "POST"),
  1246. EndStream: false, // keep it open
  1247. EndHeaders: true,
  1248. })
  1249. <-inHandler
  1250. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1251. t.Fatal(err)
  1252. }
  1253. wroteRST <- true
  1254. st.awaitIdle()
  1255. select {
  1256. case <-headerWritten:
  1257. case <-time.After(2 * time.Second):
  1258. t.Error("timeout waiting for header write")
  1259. }
  1260. unblockHandler <- true
  1261. }
  1262. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1263. testServerPostUnblock(t,
  1264. func(w http.ResponseWriter, r *http.Request) (err error) {
  1265. _, err = r.Body.Read(make([]byte, 1))
  1266. return
  1267. },
  1268. func(st *serverTester) { st.cc.Close() },
  1269. func(err error) {
  1270. if err == nil {
  1271. t.Error("unexpected nil error from Request.Body.Read")
  1272. }
  1273. },
  1274. )
  1275. }
  1276. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1277. <-w.(http.CloseNotifier).CloseNotify()
  1278. return nil
  1279. }
  1280. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1281. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1282. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1283. t.Fatal(err)
  1284. }
  1285. }, nil)
  1286. }
  1287. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1288. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1289. }
  1290. // that CloseNotify unblocks after a stream error due to the client's
  1291. // problem that's unrelated to them explicitly canceling it (which is
  1292. // TestServer_CloseNotify_After_RSTStream above)
  1293. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1294. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1295. // data longer than declared Content-Length => stream error
  1296. st.writeData(1, true, []byte("1234"))
  1297. }, nil, "content-length", "3")
  1298. }
  1299. func TestServer_StateTransitions(t *testing.T) {
  1300. var st *serverTester
  1301. inHandler := make(chan bool)
  1302. writeData := make(chan bool)
  1303. leaveHandler := make(chan bool)
  1304. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1305. inHandler <- true
  1306. if st.stream(1) == nil {
  1307. t.Errorf("nil stream 1 in handler")
  1308. }
  1309. if got, want := st.streamState(1), stateOpen; got != want {
  1310. t.Errorf("in handler, state is %v; want %v", got, want)
  1311. }
  1312. writeData <- true
  1313. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1314. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1315. }
  1316. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1317. t.Errorf("in handler, state is %v; want %v", got, want)
  1318. }
  1319. <-leaveHandler
  1320. })
  1321. st.greet()
  1322. if st.stream(1) != nil {
  1323. t.Fatal("stream 1 should be empty")
  1324. }
  1325. if got := st.streamState(1); got != stateIdle {
  1326. t.Fatalf("stream 1 should be idle; got %v", got)
  1327. }
  1328. st.writeHeaders(HeadersFrameParam{
  1329. StreamID: 1,
  1330. BlockFragment: st.encodeHeader(":method", "POST"),
  1331. EndStream: false, // keep it open
  1332. EndHeaders: true,
  1333. })
  1334. <-inHandler
  1335. <-writeData
  1336. st.writeData(1, true, nil)
  1337. leaveHandler <- true
  1338. hf := st.wantHeaders()
  1339. if !hf.StreamEnded() {
  1340. t.Fatal("expected END_STREAM flag")
  1341. }
  1342. if got, want := st.streamState(1), stateClosed; got != want {
  1343. t.Errorf("at end, state is %v; want %v", got, want)
  1344. }
  1345. if st.stream(1) != nil {
  1346. t.Fatal("at end, stream 1 should be gone")
  1347. }
  1348. }
  1349. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1350. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1351. testServerRejectsConn(t, func(st *serverTester) {
  1352. st.writeHeaders(HeadersFrameParam{
  1353. StreamID: 1,
  1354. BlockFragment: st.encodeHeader(),
  1355. EndStream: true,
  1356. EndHeaders: false,
  1357. })
  1358. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1359. StreamID: 3, // different stream.
  1360. BlockFragment: st.encodeHeader(),
  1361. EndStream: true,
  1362. EndHeaders: true,
  1363. })
  1364. })
  1365. }
  1366. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1367. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1368. testServerRejectsConn(t, func(st *serverTester) {
  1369. st.writeHeaders(HeadersFrameParam{
  1370. StreamID: 1,
  1371. BlockFragment: st.encodeHeader(),
  1372. EndStream: true,
  1373. EndHeaders: false,
  1374. })
  1375. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1376. t.Fatal(err)
  1377. }
  1378. })
  1379. }
  1380. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1381. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1382. testServerRejectsConn(t, func(st *serverTester) {
  1383. st.writeHeaders(HeadersFrameParam{
  1384. StreamID: 1,
  1385. BlockFragment: st.encodeHeader(),
  1386. EndStream: true,
  1387. EndHeaders: true,
  1388. })
  1389. st.wantHeaders()
  1390. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1391. t.Fatal(err)
  1392. }
  1393. })
  1394. }
  1395. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1396. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1397. testServerRejectsConn(t, func(st *serverTester) {
  1398. st.writeHeaders(HeadersFrameParam{
  1399. StreamID: 1,
  1400. BlockFragment: st.encodeHeader(),
  1401. EndStream: true,
  1402. EndHeaders: false,
  1403. })
  1404. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1405. t.Fatal(err)
  1406. }
  1407. })
  1408. }
  1409. // No HEADERS on stream 0.
  1410. func TestServer_Rejects_Headers0(t *testing.T) {
  1411. testServerRejectsConn(t, func(st *serverTester) {
  1412. st.fr.AllowIllegalWrites = true
  1413. st.writeHeaders(HeadersFrameParam{
  1414. StreamID: 0,
  1415. BlockFragment: st.encodeHeader(),
  1416. EndStream: true,
  1417. EndHeaders: true,
  1418. })
  1419. })
  1420. }
  1421. // No CONTINUATION on stream 0.
  1422. func TestServer_Rejects_Continuation0(t *testing.T) {
  1423. testServerRejectsConn(t, func(st *serverTester) {
  1424. st.fr.AllowIllegalWrites = true
  1425. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1426. t.Fatal(err)
  1427. }
  1428. })
  1429. }
  1430. // No PRIORITY on stream 0.
  1431. func TestServer_Rejects_Priority0(t *testing.T) {
  1432. testServerRejectsConn(t, func(st *serverTester) {
  1433. st.fr.AllowIllegalWrites = true
  1434. st.writePriority(0, PriorityParam{StreamDep: 1})
  1435. })
  1436. }
  1437. // No HEADERS frame with a self-dependence.
  1438. func TestServer_Rejects_HeadersSelfDependence(t *testing.T) {
  1439. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1440. st.fr.AllowIllegalWrites = true
  1441. st.writeHeaders(HeadersFrameParam{
  1442. StreamID: 1,
  1443. BlockFragment: st.encodeHeader(),
  1444. EndStream: true,
  1445. EndHeaders: true,
  1446. Priority: PriorityParam{StreamDep: 1},
  1447. })
  1448. })
  1449. }
  1450. // No PRIORTY frame with a self-dependence.
  1451. func TestServer_Rejects_PrioritySelfDependence(t *testing.T) {
  1452. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1453. st.fr.AllowIllegalWrites = true
  1454. st.writePriority(1, PriorityParam{StreamDep: 1})
  1455. })
  1456. }
  1457. func TestServer_Rejects_PushPromise(t *testing.T) {
  1458. testServerRejectsConn(t, func(st *serverTester) {
  1459. pp := PushPromiseParam{
  1460. StreamID: 1,
  1461. PromiseID: 3,
  1462. }
  1463. if err := st.fr.WritePushPromise(pp); err != nil {
  1464. t.Fatal(err)
  1465. }
  1466. })
  1467. }
  1468. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1469. // frame and a server close after the client does something
  1470. // deserving a CONNECTION_ERROR.
  1471. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1472. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1473. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1474. defer st.Close()
  1475. st.greet()
  1476. writeReq(st)
  1477. st.wantGoAway()
  1478. errc := make(chan error, 1)
  1479. go func() {
  1480. fr, err := st.fr.ReadFrame()
  1481. if err == nil {
  1482. err = fmt.Errorf("got frame of type %T", fr)
  1483. }
  1484. errc <- err
  1485. }()
  1486. select {
  1487. case err := <-errc:
  1488. if err != io.EOF {
  1489. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1490. }
  1491. case <-time.After(2 * time.Second):
  1492. t.Error("timeout waiting for disconnect")
  1493. }
  1494. }
  1495. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1496. // error code after a client sends a bogus request.
  1497. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1498. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1499. defer st.Close()
  1500. st.greet()
  1501. writeReq(st)
  1502. st.wantRSTStream(1, code)
  1503. }
  1504. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1505. // write a single request with writeReq, and then verify that the
  1506. // *http.Request is built correctly in checkReq.
  1507. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1508. gotReq := make(chan bool, 1)
  1509. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1510. if r.Body == nil {
  1511. t.Fatal("nil Body")
  1512. }
  1513. checkReq(r)
  1514. gotReq <- true
  1515. })
  1516. defer st.Close()
  1517. st.greet()
  1518. writeReq(st)
  1519. select {
  1520. case <-gotReq:
  1521. case <-time.After(2 * time.Second):
  1522. t.Error("timeout waiting for request")
  1523. }
  1524. }
  1525. func getSlash(st *serverTester) { st.bodylessReq1() }
  1526. func TestServer_Response_NoData(t *testing.T) {
  1527. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1528. // Nothing.
  1529. return nil
  1530. }, func(st *serverTester) {
  1531. getSlash(st)
  1532. hf := st.wantHeaders()
  1533. if !hf.StreamEnded() {
  1534. t.Fatal("want END_STREAM flag")
  1535. }
  1536. if !hf.HeadersEnded() {
  1537. t.Fatal("want END_HEADERS flag")
  1538. }
  1539. })
  1540. }
  1541. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1542. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1543. w.Header().Set("Foo-Bar", "some-value")
  1544. return nil
  1545. }, func(st *serverTester) {
  1546. getSlash(st)
  1547. hf := st.wantHeaders()
  1548. if !hf.StreamEnded() {
  1549. t.Fatal("want END_STREAM flag")
  1550. }
  1551. if !hf.HeadersEnded() {
  1552. t.Fatal("want END_HEADERS flag")
  1553. }
  1554. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1555. wanth := [][2]string{
  1556. {":status", "200"},
  1557. {"foo-bar", "some-value"},
  1558. {"content-type", "text/plain; charset=utf-8"},
  1559. {"content-length", "0"},
  1560. }
  1561. if !reflect.DeepEqual(goth, wanth) {
  1562. t.Errorf("Got headers %v; want %v", goth, wanth)
  1563. }
  1564. })
  1565. }
  1566. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1567. const msg = "<html>this is HTML."
  1568. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1569. w.Header().Set("Content-Type", "foo/bar")
  1570. io.WriteString(w, msg)
  1571. return nil
  1572. }, func(st *serverTester) {
  1573. getSlash(st)
  1574. hf := st.wantHeaders()
  1575. if hf.StreamEnded() {
  1576. t.Fatal("don't want END_STREAM, expecting data")
  1577. }
  1578. if !hf.HeadersEnded() {
  1579. t.Fatal("want END_HEADERS flag")
  1580. }
  1581. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1582. wanth := [][2]string{
  1583. {":status", "200"},
  1584. {"content-type", "foo/bar"},
  1585. {"content-length", strconv.Itoa(len(msg))},
  1586. }
  1587. if !reflect.DeepEqual(goth, wanth) {
  1588. t.Errorf("Got headers %v; want %v", goth, wanth)
  1589. }
  1590. df := st.wantData()
  1591. if !df.StreamEnded() {
  1592. t.Error("expected DATA to have END_STREAM flag")
  1593. }
  1594. if got := string(df.Data()); got != msg {
  1595. t.Errorf("got DATA %q; want %q", got, msg)
  1596. }
  1597. })
  1598. }
  1599. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1600. const msg = "hi"
  1601. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1602. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1603. io.WriteString(w, msg)
  1604. return nil
  1605. }, func(st *serverTester) {
  1606. getSlash(st)
  1607. hf := st.wantHeaders()
  1608. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1609. wanth := [][2]string{
  1610. {":status", "200"},
  1611. {"content-type", "text/plain; charset=utf-8"},
  1612. {"content-length", strconv.Itoa(len(msg))},
  1613. }
  1614. if !reflect.DeepEqual(goth, wanth) {
  1615. t.Errorf("Got headers %v; want %v", goth, wanth)
  1616. }
  1617. })
  1618. }
  1619. // Header accessed only after the initial write.
  1620. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1621. const msg = "<html>this is HTML."
  1622. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1623. io.WriteString(w, msg)
  1624. w.Header().Set("foo", "should be ignored")
  1625. return nil
  1626. }, func(st *serverTester) {
  1627. getSlash(st)
  1628. hf := st.wantHeaders()
  1629. if hf.StreamEnded() {
  1630. t.Fatal("unexpected END_STREAM")
  1631. }
  1632. if !hf.HeadersEnded() {
  1633. t.Fatal("want END_HEADERS flag")
  1634. }
  1635. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1636. wanth := [][2]string{
  1637. {":status", "200"},
  1638. {"content-type", "text/html; charset=utf-8"},
  1639. {"content-length", strconv.Itoa(len(msg))},
  1640. }
  1641. if !reflect.DeepEqual(goth, wanth) {
  1642. t.Errorf("Got headers %v; want %v", goth, wanth)
  1643. }
  1644. })
  1645. }
  1646. // Header accessed before the initial write and later mutated.
  1647. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1648. const msg = "<html>this is HTML."
  1649. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1650. w.Header().Set("foo", "proper value")
  1651. io.WriteString(w, msg)
  1652. w.Header().Set("foo", "should be ignored")
  1653. return nil
  1654. }, func(st *serverTester) {
  1655. getSlash(st)
  1656. hf := st.wantHeaders()
  1657. if hf.StreamEnded() {
  1658. t.Fatal("unexpected END_STREAM")
  1659. }
  1660. if !hf.HeadersEnded() {
  1661. t.Fatal("want END_HEADERS flag")
  1662. }
  1663. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1664. wanth := [][2]string{
  1665. {":status", "200"},
  1666. {"foo", "proper value"},
  1667. {"content-type", "text/html; charset=utf-8"},
  1668. {"content-length", strconv.Itoa(len(msg))},
  1669. }
  1670. if !reflect.DeepEqual(goth, wanth) {
  1671. t.Errorf("Got headers %v; want %v", goth, wanth)
  1672. }
  1673. })
  1674. }
  1675. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1676. const msg = "<html>this is HTML."
  1677. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1678. io.WriteString(w, msg)
  1679. return nil
  1680. }, func(st *serverTester) {
  1681. getSlash(st)
  1682. hf := st.wantHeaders()
  1683. if hf.StreamEnded() {
  1684. t.Fatal("don't want END_STREAM, expecting data")
  1685. }
  1686. if !hf.HeadersEnded() {
  1687. t.Fatal("want END_HEADERS flag")
  1688. }
  1689. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1690. wanth := [][2]string{
  1691. {":status", "200"},
  1692. {"content-type", "text/html; charset=utf-8"},
  1693. {"content-length", strconv.Itoa(len(msg))},
  1694. }
  1695. if !reflect.DeepEqual(goth, wanth) {
  1696. t.Errorf("Got headers %v; want %v", goth, wanth)
  1697. }
  1698. df := st.wantData()
  1699. if !df.StreamEnded() {
  1700. t.Error("expected DATA to have END_STREAM flag")
  1701. }
  1702. if got := string(df.Data()); got != msg {
  1703. t.Errorf("got DATA %q; want %q", got, msg)
  1704. }
  1705. })
  1706. }
  1707. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1708. const msg = "<html>this is HTML"
  1709. const msg2 = ", and this is the next chunk"
  1710. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1711. io.WriteString(w, msg)
  1712. w.(http.Flusher).Flush()
  1713. io.WriteString(w, msg2)
  1714. return nil
  1715. }, func(st *serverTester) {
  1716. getSlash(st)
  1717. hf := st.wantHeaders()
  1718. if hf.StreamEnded() {
  1719. t.Fatal("unexpected END_STREAM flag")
  1720. }
  1721. if !hf.HeadersEnded() {
  1722. t.Fatal("want END_HEADERS flag")
  1723. }
  1724. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1725. wanth := [][2]string{
  1726. {":status", "200"},
  1727. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1728. // and no content-length
  1729. }
  1730. if !reflect.DeepEqual(goth, wanth) {
  1731. t.Errorf("Got headers %v; want %v", goth, wanth)
  1732. }
  1733. {
  1734. df := st.wantData()
  1735. if df.StreamEnded() {
  1736. t.Error("unexpected END_STREAM flag")
  1737. }
  1738. if got := string(df.Data()); got != msg {
  1739. t.Errorf("got DATA %q; want %q", got, msg)
  1740. }
  1741. }
  1742. {
  1743. df := st.wantData()
  1744. if !df.StreamEnded() {
  1745. t.Error("wanted END_STREAM flag on last data chunk")
  1746. }
  1747. if got := string(df.Data()); got != msg2 {
  1748. t.Errorf("got DATA %q; want %q", got, msg2)
  1749. }
  1750. }
  1751. })
  1752. }
  1753. func TestServer_Response_LargeWrite(t *testing.T) {
  1754. const size = 1 << 20
  1755. const maxFrameSize = 16 << 10
  1756. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1757. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1758. if err != nil {
  1759. return fmt.Errorf("Write error: %v", err)
  1760. }
  1761. if n != size {
  1762. return fmt.Errorf("wrong size %d from Write", n)
  1763. }
  1764. return nil
  1765. }, func(st *serverTester) {
  1766. if err := st.fr.WriteSettings(
  1767. Setting{SettingInitialWindowSize, 0},
  1768. Setting{SettingMaxFrameSize, maxFrameSize},
  1769. ); err != nil {
  1770. t.Fatal(err)
  1771. }
  1772. st.wantSettingsAck()
  1773. getSlash(st) // make the single request
  1774. // Give the handler quota to write:
  1775. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1776. t.Fatal(err)
  1777. }
  1778. // Give the handler quota to write to connection-level
  1779. // window as well
  1780. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1781. t.Fatal(err)
  1782. }
  1783. hf := st.wantHeaders()
  1784. if hf.StreamEnded() {
  1785. t.Fatal("unexpected END_STREAM flag")
  1786. }
  1787. if !hf.HeadersEnded() {
  1788. t.Fatal("want END_HEADERS flag")
  1789. }
  1790. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1791. wanth := [][2]string{
  1792. {":status", "200"},
  1793. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1794. // and no content-length
  1795. }
  1796. if !reflect.DeepEqual(goth, wanth) {
  1797. t.Errorf("Got headers %v; want %v", goth, wanth)
  1798. }
  1799. var bytes, frames int
  1800. for {
  1801. df := st.wantData()
  1802. bytes += len(df.Data())
  1803. frames++
  1804. for _, b := range df.Data() {
  1805. if b != 'a' {
  1806. t.Fatal("non-'a' byte seen in DATA")
  1807. }
  1808. }
  1809. if df.StreamEnded() {
  1810. break
  1811. }
  1812. }
  1813. if bytes != size {
  1814. t.Errorf("Got %d bytes; want %d", bytes, size)
  1815. }
  1816. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1817. t.Errorf("Got %d frames; want %d", frames, size)
  1818. }
  1819. })
  1820. }
  1821. // Test that the handler can't write more than the client allows
  1822. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1823. // Make these reads. Before each read, the client adds exactly enough
  1824. // flow-control to satisfy the read. Numbers chosen arbitrarily.
  1825. reads := []int{123, 1, 13, 127}
  1826. size := 0
  1827. for _, n := range reads {
  1828. size += n
  1829. }
  1830. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1831. w.(http.Flusher).Flush()
  1832. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1833. if err != nil {
  1834. return fmt.Errorf("Write error: %v", err)
  1835. }
  1836. if n != size {
  1837. return fmt.Errorf("wrong size %d from Write", n)
  1838. }
  1839. return nil
  1840. }, func(st *serverTester) {
  1841. // Set the window size to something explicit for this test.
  1842. // It's also how much initial data we expect.
  1843. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, uint32(reads[0])}); err != nil {
  1844. t.Fatal(err)
  1845. }
  1846. st.wantSettingsAck()
  1847. getSlash(st) // make the single request
  1848. hf := st.wantHeaders()
  1849. if hf.StreamEnded() {
  1850. t.Fatal("unexpected END_STREAM flag")
  1851. }
  1852. if !hf.HeadersEnded() {
  1853. t.Fatal("want END_HEADERS flag")
  1854. }
  1855. df := st.wantData()
  1856. if got := len(df.Data()); got != reads[0] {
  1857. t.Fatalf("Initial window size = %d but got DATA with %d bytes", reads[0], got)
  1858. }
  1859. for _, quota := range reads[1:] {
  1860. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1861. t.Fatal(err)
  1862. }
  1863. df := st.wantData()
  1864. if int(quota) != len(df.Data()) {
  1865. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1866. }
  1867. }
  1868. })
  1869. }
  1870. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1871. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1872. const size = 1 << 20
  1873. const maxFrameSize = 16 << 10
  1874. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1875. w.(http.Flusher).Flush()
  1876. errc := make(chan error, 1)
  1877. go func() {
  1878. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1879. errc <- err
  1880. }()
  1881. select {
  1882. case err := <-errc:
  1883. if err == nil {
  1884. return errors.New("unexpected nil error from Write in handler")
  1885. }
  1886. return nil
  1887. case <-time.After(2 * time.Second):
  1888. return errors.New("timeout waiting for Write in handler")
  1889. }
  1890. }, func(st *serverTester) {
  1891. if err := st.fr.WriteSettings(
  1892. Setting{SettingInitialWindowSize, 0},
  1893. Setting{SettingMaxFrameSize, maxFrameSize},
  1894. ); err != nil {
  1895. t.Fatal(err)
  1896. }
  1897. st.wantSettingsAck()
  1898. getSlash(st) // make the single request
  1899. hf := st.wantHeaders()
  1900. if hf.StreamEnded() {
  1901. t.Fatal("unexpected END_STREAM flag")
  1902. }
  1903. if !hf.HeadersEnded() {
  1904. t.Fatal("want END_HEADERS flag")
  1905. }
  1906. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1907. t.Fatal(err)
  1908. }
  1909. })
  1910. }
  1911. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1912. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1913. w.(http.Flusher).Flush()
  1914. // Nothing; send empty DATA
  1915. return nil
  1916. }, func(st *serverTester) {
  1917. // Handler gets no data quota:
  1918. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1919. t.Fatal(err)
  1920. }
  1921. st.wantSettingsAck()
  1922. getSlash(st) // make the single request
  1923. hf := st.wantHeaders()
  1924. if hf.StreamEnded() {
  1925. t.Fatal("unexpected END_STREAM flag")
  1926. }
  1927. if !hf.HeadersEnded() {
  1928. t.Fatal("want END_HEADERS flag")
  1929. }
  1930. df := st.wantData()
  1931. if got := len(df.Data()); got != 0 {
  1932. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1933. }
  1934. if !df.StreamEnded() {
  1935. t.Fatal("DATA didn't have END_STREAM")
  1936. }
  1937. })
  1938. }
  1939. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1940. const msg = "foo"
  1941. const reply = "bar"
  1942. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1943. if v := r.Header.Get("Expect"); v != "" {
  1944. t.Errorf("Expect header = %q; want empty", v)
  1945. }
  1946. buf := make([]byte, len(msg))
  1947. // This read should trigger the 100-continue being sent.
  1948. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1949. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1950. }
  1951. _, err := io.WriteString(w, reply)
  1952. return err
  1953. }, func(st *serverTester) {
  1954. st.writeHeaders(HeadersFrameParam{
  1955. StreamID: 1, // clients send odd numbers
  1956. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1957. EndStream: false,
  1958. EndHeaders: true,
  1959. })
  1960. hf := st.wantHeaders()
  1961. if hf.StreamEnded() {
  1962. t.Fatal("unexpected END_STREAM flag")
  1963. }
  1964. if !hf.HeadersEnded() {
  1965. t.Fatal("want END_HEADERS flag")
  1966. }
  1967. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1968. wanth := [][2]string{
  1969. {":status", "100"},
  1970. }
  1971. if !reflect.DeepEqual(goth, wanth) {
  1972. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1973. }
  1974. // Okay, they sent status 100, so we can send our
  1975. // gigantic and/or sensitive "foo" payload now.
  1976. st.writeData(1, true, []byte(msg))
  1977. st.wantWindowUpdate(0, uint32(len(msg)))
  1978. hf = st.wantHeaders()
  1979. if hf.StreamEnded() {
  1980. t.Fatal("expected data to follow")
  1981. }
  1982. if !hf.HeadersEnded() {
  1983. t.Fatal("want END_HEADERS flag")
  1984. }
  1985. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1986. wanth = [][2]string{
  1987. {":status", "200"},
  1988. {"content-type", "text/plain; charset=utf-8"},
  1989. {"content-length", strconv.Itoa(len(reply))},
  1990. }
  1991. if !reflect.DeepEqual(goth, wanth) {
  1992. t.Errorf("Got headers %v; want %v", goth, wanth)
  1993. }
  1994. df := st.wantData()
  1995. if string(df.Data()) != reply {
  1996. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1997. }
  1998. if !df.StreamEnded() {
  1999. t.Errorf("expect data stream end")
  2000. }
  2001. })
  2002. }
  2003. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  2004. errc := make(chan error, 1)
  2005. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2006. p := []byte("some data.\n")
  2007. for {
  2008. _, err := w.Write(p)
  2009. if err != nil {
  2010. errc <- err
  2011. return nil
  2012. }
  2013. }
  2014. }, func(st *serverTester) {
  2015. st.writeHeaders(HeadersFrameParam{
  2016. StreamID: 1,
  2017. BlockFragment: st.encodeHeader(),
  2018. EndStream: false,
  2019. EndHeaders: true,
  2020. })
  2021. hf := st.wantHeaders()
  2022. if hf.StreamEnded() {
  2023. t.Fatal("unexpected END_STREAM flag")
  2024. }
  2025. if !hf.HeadersEnded() {
  2026. t.Fatal("want END_HEADERS flag")
  2027. }
  2028. // Close the connection and wait for the handler to (hopefully) notice.
  2029. st.cc.Close()
  2030. select {
  2031. case <-errc:
  2032. case <-time.After(5 * time.Second):
  2033. t.Error("timeout")
  2034. }
  2035. })
  2036. }
  2037. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  2038. const testPath = "/some/path"
  2039. inHandler := make(chan uint32)
  2040. leaveHandler := make(chan bool)
  2041. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2042. id := w.(*responseWriter).rws.stream.id
  2043. inHandler <- id
  2044. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  2045. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  2046. }
  2047. <-leaveHandler
  2048. })
  2049. defer st.Close()
  2050. st.greet()
  2051. nextStreamID := uint32(1)
  2052. streamID := func() uint32 {
  2053. defer func() { nextStreamID += 2 }()
  2054. return nextStreamID
  2055. }
  2056. sendReq := func(id uint32, headers ...string) {
  2057. st.writeHeaders(HeadersFrameParam{
  2058. StreamID: id,
  2059. BlockFragment: st.encodeHeader(headers...),
  2060. EndStream: true,
  2061. EndHeaders: true,
  2062. })
  2063. }
  2064. for i := 0; i < defaultMaxStreams; i++ {
  2065. sendReq(streamID())
  2066. <-inHandler
  2067. }
  2068. defer func() {
  2069. for i := 0; i < defaultMaxStreams; i++ {
  2070. leaveHandler <- true
  2071. }
  2072. }()
  2073. // And this one should cross the limit:
  2074. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  2075. // even if we're rejecting it)
  2076. rejectID := streamID()
  2077. headerBlock := st.encodeHeader(":path", testPath)
  2078. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  2079. st.writeHeaders(HeadersFrameParam{
  2080. StreamID: rejectID,
  2081. BlockFragment: frag1,
  2082. EndStream: true,
  2083. EndHeaders: false, // CONTINUATION coming
  2084. })
  2085. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  2086. t.Fatal(err)
  2087. }
  2088. st.wantRSTStream(rejectID, ErrCodeProtocol)
  2089. // But let a handler finish:
  2090. leaveHandler <- true
  2091. st.wantHeaders()
  2092. // And now another stream should be able to start:
  2093. goodID := streamID()
  2094. sendReq(goodID, ":path", testPath)
  2095. select {
  2096. case got := <-inHandler:
  2097. if got != goodID {
  2098. t.Errorf("Got stream %d; want %d", got, goodID)
  2099. }
  2100. case <-time.After(3 * time.Second):
  2101. t.Error("timeout waiting for handler")
  2102. }
  2103. }
  2104. // So many response headers that the server needs to use CONTINUATION frames:
  2105. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  2106. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2107. h := w.Header()
  2108. for i := 0; i < 5000; i++ {
  2109. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  2110. }
  2111. return nil
  2112. }, func(st *serverTester) {
  2113. getSlash(st)
  2114. hf := st.wantHeaders()
  2115. if hf.HeadersEnded() {
  2116. t.Fatal("got unwanted END_HEADERS flag")
  2117. }
  2118. n := 0
  2119. for {
  2120. n++
  2121. cf := st.wantContinuation()
  2122. if cf.HeadersEnded() {
  2123. break
  2124. }
  2125. }
  2126. if n < 5 {
  2127. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  2128. }
  2129. })
  2130. }
  2131. // This previously crashed (reported by Mathieu Lonjaret as observed
  2132. // while using Camlistore) because we got a DATA frame from the client
  2133. // after the handler exited and our logic at the time was wrong,
  2134. // keeping a stream in the map in stateClosed, which tickled an
  2135. // invariant check later when we tried to remove that stream (via
  2136. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  2137. // ended.
  2138. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2139. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2140. // nothing
  2141. return nil
  2142. }, func(st *serverTester) {
  2143. st.writeHeaders(HeadersFrameParam{
  2144. StreamID: 1,
  2145. BlockFragment: st.encodeHeader(),
  2146. EndStream: false, // DATA is coming
  2147. EndHeaders: true,
  2148. })
  2149. hf := st.wantHeaders()
  2150. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2151. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2152. }
  2153. // Sent when the a Handler closes while a client has
  2154. // indicated it's still sending DATA:
  2155. st.wantRSTStream(1, ErrCodeCancel)
  2156. // Now the handler has ended, so it's ended its
  2157. // stream, but the client hasn't closed its side
  2158. // (stateClosedLocal). So send more data and verify
  2159. // it doesn't crash with an internal invariant panic, like
  2160. // it did before.
  2161. st.writeData(1, true, []byte("foo"))
  2162. // Get our flow control bytes back, since the handler didn't get them.
  2163. st.wantWindowUpdate(0, uint32(len("foo")))
  2164. // Sent after a peer sends data anyway (admittedly the
  2165. // previous RST_STREAM might've still been in-flight),
  2166. // but they'll get the more friendly 'cancel' code
  2167. // first.
  2168. st.wantRSTStream(1, ErrCodeStreamClosed)
  2169. // Set up a bunch of machinery to record the panic we saw
  2170. // previously.
  2171. var (
  2172. panMu sync.Mutex
  2173. panicVal interface{}
  2174. )
  2175. testHookOnPanicMu.Lock()
  2176. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2177. panMu.Lock()
  2178. panicVal = pv
  2179. panMu.Unlock()
  2180. return true
  2181. }
  2182. testHookOnPanicMu.Unlock()
  2183. // Now force the serve loop to end, via closing the connection.
  2184. st.cc.Close()
  2185. select {
  2186. case <-st.sc.doneServing:
  2187. // Loop has exited.
  2188. panMu.Lock()
  2189. got := panicVal
  2190. panMu.Unlock()
  2191. if got != nil {
  2192. t.Errorf("Got panic: %v", got)
  2193. }
  2194. case <-time.After(5 * time.Second):
  2195. t.Error("timeout")
  2196. }
  2197. })
  2198. }
  2199. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2200. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2201. func testRejectTLS(t *testing.T, max uint16) {
  2202. st := newServerTester(t, nil, func(c *tls.Config) {
  2203. c.MaxVersion = max
  2204. })
  2205. defer st.Close()
  2206. gf := st.wantGoAway()
  2207. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2208. t.Errorf("Got error code %v; want %v", got, want)
  2209. }
  2210. }
  2211. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2212. st := newServerTester(t, nil, func(c *tls.Config) {
  2213. // Only list bad ones:
  2214. c.CipherSuites = []uint16{
  2215. tls.TLS_RSA_WITH_RC4_128_SHA,
  2216. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2217. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2218. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2219. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2220. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2221. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2222. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2223. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2224. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2225. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2226. }
  2227. })
  2228. defer st.Close()
  2229. gf := st.wantGoAway()
  2230. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2231. t.Errorf("Got error code %v; want %v", got, want)
  2232. }
  2233. }
  2234. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2235. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2236. st := newServerTester(t, nil, func(c *tls.Config) {
  2237. // Have the client only support the one required by the spec.
  2238. c.CipherSuites = []uint16{requiredSuite}
  2239. }, func(ts *httptest.Server) {
  2240. var srv *http.Server = ts.Config
  2241. // Have the server configured with no specific cipher suites.
  2242. // This tests that Go's defaults include the required one.
  2243. srv.TLSConfig = nil
  2244. })
  2245. defer st.Close()
  2246. st.greet()
  2247. }
  2248. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2249. if f.Name == "date" {
  2250. return
  2251. }
  2252. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2253. }
  2254. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2255. st.decodedHeaders = nil
  2256. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2257. st.t.Fatalf("hpack decoding error: %v", err)
  2258. }
  2259. if err := st.hpackDec.Close(); err != nil {
  2260. st.t.Fatalf("hpack decoding error: %v", err)
  2261. }
  2262. return st.decodedHeaders
  2263. }
  2264. // testServerResponse sets up an idle HTTP/2 connection. The client function should
  2265. // write a single request that must be handled by the handler. This waits up to 5s
  2266. // for client to return, then up to an additional 2s for the handler to return.
  2267. func testServerResponse(t testing.TB,
  2268. handler func(http.ResponseWriter, *http.Request) error,
  2269. client func(*serverTester),
  2270. ) {
  2271. errc := make(chan error, 1)
  2272. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2273. if r.Body == nil {
  2274. t.Fatal("nil Body")
  2275. }
  2276. errc <- handler(w, r)
  2277. })
  2278. defer st.Close()
  2279. donec := make(chan bool)
  2280. go func() {
  2281. defer close(donec)
  2282. st.greet()
  2283. client(st)
  2284. }()
  2285. select {
  2286. case <-donec:
  2287. case <-time.After(5 * time.Second):
  2288. t.Fatal("timeout in client")
  2289. }
  2290. select {
  2291. case err := <-errc:
  2292. if err != nil {
  2293. t.Fatalf("Error in handler: %v", err)
  2294. }
  2295. case <-time.After(2 * time.Second):
  2296. t.Fatal("timeout in handler")
  2297. }
  2298. }
  2299. // readBodyHandler returns an http Handler func that reads len(want)
  2300. // bytes from r.Body and fails t if the contents read were not
  2301. // the value of want.
  2302. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2303. return func(w http.ResponseWriter, r *http.Request) {
  2304. buf := make([]byte, len(want))
  2305. _, err := io.ReadFull(r.Body, buf)
  2306. if err != nil {
  2307. t.Error(err)
  2308. return
  2309. }
  2310. if string(buf) != want {
  2311. t.Errorf("read %q; want %q", buf, want)
  2312. }
  2313. }
  2314. }
  2315. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2316. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2317. // http://sourceforge.net/p/curl/bugs/1472/
  2318. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2319. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2320. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2321. if runtime.GOOS != "linux" {
  2322. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2323. }
  2324. if testing.Short() {
  2325. t.Skip("skipping curl test in short mode")
  2326. }
  2327. requireCurl(t)
  2328. var gotConn int32
  2329. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2330. const msg = "Hello from curl!\n"
  2331. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2332. w.Header().Set("Foo", "Bar")
  2333. w.Header().Set("Client-Proto", r.Proto)
  2334. io.WriteString(w, msg)
  2335. }))
  2336. ConfigureServer(ts.Config, &Server{
  2337. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2338. })
  2339. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2340. ts.StartTLS()
  2341. defer ts.Close()
  2342. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2343. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2344. defer kill(container)
  2345. resc := make(chan interface{}, 1)
  2346. go func() {
  2347. res, err := dockerLogs(container)
  2348. if err != nil {
  2349. resc <- err
  2350. } else {
  2351. resc <- res
  2352. }
  2353. }()
  2354. select {
  2355. case res := <-resc:
  2356. if err, ok := res.(error); ok {
  2357. t.Fatal(err)
  2358. }
  2359. body := string(res.([]byte))
  2360. // Search for both "key: value" and "key:value", since curl changed their format
  2361. // Our Dockerfile contains the latest version (no space), but just in case people
  2362. // didn't rebuild, check both.
  2363. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2364. t.Errorf("didn't see foo: Bar header")
  2365. t.Logf("Got: %s", body)
  2366. }
  2367. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2368. t.Errorf("didn't see client-proto: HTTP/2 header")
  2369. t.Logf("Got: %s", res)
  2370. }
  2371. if !strings.Contains(string(res.([]byte)), msg) {
  2372. t.Errorf("didn't see %q content", msg)
  2373. t.Logf("Got: %s", res)
  2374. }
  2375. case <-time.After(3 * time.Second):
  2376. t.Errorf("timeout waiting for curl")
  2377. }
  2378. if atomic.LoadInt32(&gotConn) == 0 {
  2379. t.Error("never saw an http2 connection")
  2380. }
  2381. }
  2382. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2383. func TestServerWithH2Load(t *testing.T) {
  2384. if !*doh2load {
  2385. t.Skip("Skipping without --h2load flag.")
  2386. }
  2387. if runtime.GOOS != "linux" {
  2388. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2389. }
  2390. requireH2load(t)
  2391. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2392. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2393. io.WriteString(w, msg)
  2394. w.(http.Flusher).Flush()
  2395. io.WriteString(w, msg)
  2396. }))
  2397. ts.StartTLS()
  2398. defer ts.Close()
  2399. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2400. "-n100000", "-c100", "-m100", ts.URL)
  2401. cmd.Stdout = os.Stdout
  2402. cmd.Stderr = os.Stderr
  2403. if err := cmd.Run(); err != nil {
  2404. t.Fatal(err)
  2405. }
  2406. }
  2407. // Issue 12843
  2408. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2409. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2410. defer st.Close()
  2411. // shake hands
  2412. frameSize := defaultMaxReadFrameSize
  2413. var advHeaderListSize *uint32
  2414. st.greetAndCheckSettings(func(s Setting) error {
  2415. switch s.ID {
  2416. case SettingMaxFrameSize:
  2417. if s.Val < minMaxFrameSize {
  2418. frameSize = minMaxFrameSize
  2419. } else if s.Val > maxFrameSize {
  2420. frameSize = maxFrameSize
  2421. } else {
  2422. frameSize = int(s.Val)
  2423. }
  2424. case SettingMaxHeaderListSize:
  2425. advHeaderListSize = &s.Val
  2426. }
  2427. return nil
  2428. })
  2429. if advHeaderListSize == nil {
  2430. t.Errorf("server didn't advertise a max header list size")
  2431. } else if *advHeaderListSize == 0 {
  2432. t.Errorf("server advertised a max header list size of 0")
  2433. }
  2434. st.encodeHeaderField(":method", "GET")
  2435. st.encodeHeaderField(":path", "/")
  2436. st.encodeHeaderField(":scheme", "https")
  2437. cookie := strings.Repeat("*", 4058)
  2438. st.encodeHeaderField("cookie", cookie)
  2439. st.writeHeaders(HeadersFrameParam{
  2440. StreamID: 1,
  2441. BlockFragment: st.headerBuf.Bytes(),
  2442. EndStream: true,
  2443. EndHeaders: false,
  2444. })
  2445. // Capture the short encoding of a duplicate ~4K cookie, now
  2446. // that we've already sent it once.
  2447. st.headerBuf.Reset()
  2448. st.encodeHeaderField("cookie", cookie)
  2449. // Now send 1MB of it.
  2450. const size = 1 << 20
  2451. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2452. for len(b) > 0 {
  2453. chunk := b
  2454. if len(chunk) > frameSize {
  2455. chunk = chunk[:frameSize]
  2456. }
  2457. b = b[len(chunk):]
  2458. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2459. }
  2460. h := st.wantHeaders()
  2461. if !h.HeadersEnded() {
  2462. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2463. }
  2464. headers := st.decodeHeader(h.HeaderBlockFragment())
  2465. want := [][2]string{
  2466. {":status", "431"},
  2467. {"content-type", "text/html; charset=utf-8"},
  2468. {"content-length", "63"},
  2469. }
  2470. if !reflect.DeepEqual(headers, want) {
  2471. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2472. }
  2473. }
  2474. func TestCompressionErrorOnWrite(t *testing.T) {
  2475. const maxStrLen = 8 << 10
  2476. var serverConfig *http.Server
  2477. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2478. // No response body.
  2479. }, func(ts *httptest.Server) {
  2480. serverConfig = ts.Config
  2481. serverConfig.MaxHeaderBytes = maxStrLen
  2482. })
  2483. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2484. defer st.Close()
  2485. st.greet()
  2486. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2487. // Crank this up, now that we have a conn connected with the
  2488. // hpack.Decoder's max string length set has been initialized
  2489. // from the earlier low ~8K value. We want this higher so don't
  2490. // hit the max header list size. We only want to test hitting
  2491. // the max string size.
  2492. serverConfig.MaxHeaderBytes = 1 << 20
  2493. // First a request with a header that's exactly the max allowed size
  2494. // for the hpack compression. It's still too long for the header list
  2495. // size, so we'll get the 431 error, but that keeps the compression
  2496. // context still valid.
  2497. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2498. st.writeHeaders(HeadersFrameParam{
  2499. StreamID: 1,
  2500. BlockFragment: hbf,
  2501. EndStream: true,
  2502. EndHeaders: true,
  2503. })
  2504. h := st.wantHeaders()
  2505. if !h.HeadersEnded() {
  2506. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2507. }
  2508. headers := st.decodeHeader(h.HeaderBlockFragment())
  2509. want := [][2]string{
  2510. {":status", "431"},
  2511. {"content-type", "text/html; charset=utf-8"},
  2512. {"content-length", "63"},
  2513. }
  2514. if !reflect.DeepEqual(headers, want) {
  2515. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2516. }
  2517. df := st.wantData()
  2518. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2519. t.Errorf("Unexpected data body: %q", df.Data())
  2520. }
  2521. if !df.StreamEnded() {
  2522. t.Fatalf("expect data stream end")
  2523. }
  2524. // And now send one that's just one byte too big.
  2525. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2526. st.writeHeaders(HeadersFrameParam{
  2527. StreamID: 3,
  2528. BlockFragment: hbf,
  2529. EndStream: true,
  2530. EndHeaders: true,
  2531. })
  2532. ga := st.wantGoAway()
  2533. if ga.ErrCode != ErrCodeCompression {
  2534. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2535. }
  2536. }
  2537. func TestCompressionErrorOnClose(t *testing.T) {
  2538. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2539. // No response body.
  2540. })
  2541. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2542. defer st.Close()
  2543. st.greet()
  2544. hbf := st.encodeHeader("foo", "bar")
  2545. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2546. st.writeHeaders(HeadersFrameParam{
  2547. StreamID: 1,
  2548. BlockFragment: hbf,
  2549. EndStream: true,
  2550. EndHeaders: true,
  2551. })
  2552. ga := st.wantGoAway()
  2553. if ga.ErrCode != ErrCodeCompression {
  2554. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2555. }
  2556. }
  2557. // test that a server handler can read trailers from a client
  2558. func TestServerReadsTrailers(t *testing.T) {
  2559. const testBody = "some test body"
  2560. writeReq := func(st *serverTester) {
  2561. st.writeHeaders(HeadersFrameParam{
  2562. StreamID: 1, // clients send odd numbers
  2563. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2564. EndStream: false,
  2565. EndHeaders: true,
  2566. })
  2567. st.writeData(1, false, []byte(testBody))
  2568. st.writeHeaders(HeadersFrameParam{
  2569. StreamID: 1, // clients send odd numbers
  2570. BlockFragment: st.encodeHeaderRaw(
  2571. "foo", "foov",
  2572. "bar", "barv",
  2573. "baz", "bazv",
  2574. "surprise", "wasn't declared; shouldn't show up",
  2575. ),
  2576. EndStream: true,
  2577. EndHeaders: true,
  2578. })
  2579. }
  2580. checkReq := func(r *http.Request) {
  2581. wantTrailer := http.Header{
  2582. "Foo": nil,
  2583. "Bar": nil,
  2584. "Baz": nil,
  2585. }
  2586. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2587. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2588. }
  2589. slurp, err := ioutil.ReadAll(r.Body)
  2590. if string(slurp) != testBody {
  2591. t.Errorf("read body %q; want %q", slurp, testBody)
  2592. }
  2593. if err != nil {
  2594. t.Fatalf("Body slurp: %v", err)
  2595. }
  2596. wantTrailerAfter := http.Header{
  2597. "Foo": {"foov"},
  2598. "Bar": {"barv"},
  2599. "Baz": {"bazv"},
  2600. }
  2601. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2602. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2603. }
  2604. }
  2605. testServerRequest(t, writeReq, checkReq)
  2606. }
  2607. // test that a server handler can send trailers
  2608. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2609. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2610. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2611. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2612. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2613. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2614. w.Header().Add("Trailer", "Server-Trailer-C")
  2615. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2616. // Regular headers:
  2617. w.Header().Set("Foo", "Bar")
  2618. w.Header().Set("Content-Length", "5") // len("Hello")
  2619. io.WriteString(w, "Hello")
  2620. if withFlush {
  2621. w.(http.Flusher).Flush()
  2622. }
  2623. w.Header().Set("Server-Trailer-A", "valuea")
  2624. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2625. // After a flush, random keys like Server-Surprise shouldn't show up:
  2626. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2627. // But we do permit promoting keys to trailers after a
  2628. // flush if they start with the magic
  2629. // otherwise-invalid "Trailer:" prefix:
  2630. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2631. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2632. w.Header().Set("Trailer:Range", "invalid")
  2633. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2634. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 2616 14.40")
  2635. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 2616 14.40")
  2636. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 2616 14.40")
  2637. return nil
  2638. }, func(st *serverTester) {
  2639. getSlash(st)
  2640. hf := st.wantHeaders()
  2641. if hf.StreamEnded() {
  2642. t.Fatal("response HEADERS had END_STREAM")
  2643. }
  2644. if !hf.HeadersEnded() {
  2645. t.Fatal("response HEADERS didn't have END_HEADERS")
  2646. }
  2647. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2648. wanth := [][2]string{
  2649. {":status", "200"},
  2650. {"foo", "Bar"},
  2651. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2652. {"trailer", "Server-Trailer-C"},
  2653. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2654. {"content-type", "text/plain; charset=utf-8"},
  2655. {"content-length", "5"},
  2656. }
  2657. if !reflect.DeepEqual(goth, wanth) {
  2658. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2659. }
  2660. df := st.wantData()
  2661. if string(df.Data()) != "Hello" {
  2662. t.Fatalf("Client read %q; want Hello", df.Data())
  2663. }
  2664. if df.StreamEnded() {
  2665. t.Fatalf("data frame had STREAM_ENDED")
  2666. }
  2667. tf := st.wantHeaders() // for the trailers
  2668. if !tf.StreamEnded() {
  2669. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2670. }
  2671. if !tf.HeadersEnded() {
  2672. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2673. }
  2674. wanth = [][2]string{
  2675. {"post-header-trailer", "hi1"},
  2676. {"post-header-trailer2", "hi2"},
  2677. {"server-trailer-a", "valuea"},
  2678. {"server-trailer-c", "valuec"},
  2679. }
  2680. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2681. if !reflect.DeepEqual(goth, wanth) {
  2682. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2683. }
  2684. })
  2685. }
  2686. // validate transmitted header field names & values
  2687. // golang.org/issue/14048
  2688. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2689. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2690. w.Header().Add("OK1", "x")
  2691. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2692. w.Header().Add("Bad1\x00", "x") // null in key
  2693. w.Header().Add("Bad2", "x\x00y") // null in value
  2694. return nil
  2695. }, func(st *serverTester) {
  2696. getSlash(st)
  2697. hf := st.wantHeaders()
  2698. if !hf.StreamEnded() {
  2699. t.Error("response HEADERS lacked END_STREAM")
  2700. }
  2701. if !hf.HeadersEnded() {
  2702. t.Fatal("response HEADERS didn't have END_HEADERS")
  2703. }
  2704. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2705. wanth := [][2]string{
  2706. {":status", "200"},
  2707. {"ok1", "x"},
  2708. {"content-type", "text/plain; charset=utf-8"},
  2709. {"content-length", "0"},
  2710. }
  2711. if !reflect.DeepEqual(goth, wanth) {
  2712. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2713. }
  2714. })
  2715. }
  2716. func BenchmarkServerGets(b *testing.B) {
  2717. defer disableGoroutineTracking()()
  2718. b.ReportAllocs()
  2719. const msg = "Hello, world"
  2720. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2721. io.WriteString(w, msg)
  2722. })
  2723. defer st.Close()
  2724. st.greet()
  2725. // Give the server quota to reply. (plus it has the the 64KB)
  2726. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2727. b.Fatal(err)
  2728. }
  2729. for i := 0; i < b.N; i++ {
  2730. id := 1 + uint32(i)*2
  2731. st.writeHeaders(HeadersFrameParam{
  2732. StreamID: id,
  2733. BlockFragment: st.encodeHeader(),
  2734. EndStream: true,
  2735. EndHeaders: true,
  2736. })
  2737. st.wantHeaders()
  2738. df := st.wantData()
  2739. if !df.StreamEnded() {
  2740. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2741. }
  2742. }
  2743. }
  2744. func BenchmarkServerPosts(b *testing.B) {
  2745. defer disableGoroutineTracking()()
  2746. b.ReportAllocs()
  2747. const msg = "Hello, world"
  2748. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2749. // Consume the (empty) body from th peer before replying, otherwise
  2750. // the server will sometimes (depending on scheduling) send the peer a
  2751. // a RST_STREAM with the CANCEL error code.
  2752. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2753. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2754. }
  2755. io.WriteString(w, msg)
  2756. })
  2757. defer st.Close()
  2758. st.greet()
  2759. // Give the server quota to reply. (plus it has the the 64KB)
  2760. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2761. b.Fatal(err)
  2762. }
  2763. for i := 0; i < b.N; i++ {
  2764. id := 1 + uint32(i)*2
  2765. st.writeHeaders(HeadersFrameParam{
  2766. StreamID: id,
  2767. BlockFragment: st.encodeHeader(":method", "POST"),
  2768. EndStream: false,
  2769. EndHeaders: true,
  2770. })
  2771. st.writeData(id, true, nil)
  2772. st.wantHeaders()
  2773. df := st.wantData()
  2774. if !df.StreamEnded() {
  2775. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2776. }
  2777. }
  2778. }
  2779. // Send a stream of messages from server to client in separate data frames.
  2780. // Brings up performance issues seen in long streams.
  2781. // Created to show problem in go issue #18502
  2782. func BenchmarkServerToClientStreamDefaultOptions(b *testing.B) {
  2783. benchmarkServerToClientStream(b)
  2784. }
  2785. // Justification for Change-Id: Iad93420ef6c3918f54249d867098f1dadfa324d8
  2786. // Expect to see memory/alloc reduction by opting in to Frame reuse with the Framer.
  2787. func BenchmarkServerToClientStreamReuseFrames(b *testing.B) {
  2788. benchmarkServerToClientStream(b, optFramerReuseFrames)
  2789. }
  2790. func benchmarkServerToClientStream(b *testing.B, newServerOpts ...interface{}) {
  2791. defer disableGoroutineTracking()()
  2792. b.ReportAllocs()
  2793. const msgLen = 1
  2794. // default window size
  2795. const windowSize = 1<<16 - 1
  2796. // next message to send from the server and for the client to expect
  2797. nextMsg := func(i int) []byte {
  2798. msg := make([]byte, msgLen)
  2799. msg[0] = byte(i)
  2800. if len(msg) != msgLen {
  2801. panic("invalid test setup msg length")
  2802. }
  2803. return msg
  2804. }
  2805. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2806. // Consume the (empty) body from th peer before replying, otherwise
  2807. // the server will sometimes (depending on scheduling) send the peer a
  2808. // a RST_STREAM with the CANCEL error code.
  2809. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2810. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2811. }
  2812. for i := 0; i < b.N; i += 1 {
  2813. w.Write(nextMsg(i))
  2814. w.(http.Flusher).Flush()
  2815. }
  2816. }, newServerOpts...)
  2817. defer st.Close()
  2818. st.greet()
  2819. const id = uint32(1)
  2820. st.writeHeaders(HeadersFrameParam{
  2821. StreamID: id,
  2822. BlockFragment: st.encodeHeader(":method", "POST"),
  2823. EndStream: false,
  2824. EndHeaders: true,
  2825. })
  2826. st.writeData(id, true, nil)
  2827. st.wantHeaders()
  2828. var pendingWindowUpdate = uint32(0)
  2829. for i := 0; i < b.N; i += 1 {
  2830. expected := nextMsg(i)
  2831. df := st.wantData()
  2832. if bytes.Compare(expected, df.data) != 0 {
  2833. b.Fatalf("Bad message received; want %v; got %v", expected, df.data)
  2834. }
  2835. // try to send infrequent but large window updates so they don't overwhelm the test
  2836. pendingWindowUpdate += uint32(len(df.data))
  2837. if pendingWindowUpdate >= windowSize/2 {
  2838. if err := st.fr.WriteWindowUpdate(0, pendingWindowUpdate); err != nil {
  2839. b.Fatal(err)
  2840. }
  2841. if err := st.fr.WriteWindowUpdate(id, pendingWindowUpdate); err != nil {
  2842. b.Fatal(err)
  2843. }
  2844. pendingWindowUpdate = 0
  2845. }
  2846. }
  2847. df := st.wantData()
  2848. if !df.StreamEnded() {
  2849. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2850. }
  2851. }
  2852. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2853. // Verify we don't hang.
  2854. func TestIssue53(t *testing.T) {
  2855. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2856. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2857. s := &http.Server{
  2858. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2859. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2860. w.Write([]byte("hello"))
  2861. }),
  2862. }
  2863. s2 := &Server{
  2864. MaxReadFrameSize: 1 << 16,
  2865. PermitProhibitedCipherSuites: true,
  2866. }
  2867. c := &issue53Conn{[]byte(data), false, false}
  2868. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2869. if !c.closed {
  2870. t.Fatal("connection is not closed")
  2871. }
  2872. }
  2873. type issue53Conn struct {
  2874. data []byte
  2875. closed bool
  2876. written bool
  2877. }
  2878. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2879. if len(c.data) == 0 {
  2880. return 0, io.EOF
  2881. }
  2882. n = copy(b, c.data)
  2883. c.data = c.data[n:]
  2884. return
  2885. }
  2886. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2887. c.written = true
  2888. return len(b), nil
  2889. }
  2890. func (c *issue53Conn) Close() error {
  2891. c.closed = true
  2892. return nil
  2893. }
  2894. func (c *issue53Conn) LocalAddr() net.Addr {
  2895. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2896. }
  2897. func (c *issue53Conn) RemoteAddr() net.Addr {
  2898. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2899. }
  2900. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2901. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2902. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2903. // golang.org/issue/12895
  2904. func TestConfigureServer(t *testing.T) {
  2905. tests := []struct {
  2906. name string
  2907. tlsConfig *tls.Config
  2908. wantErr string
  2909. }{
  2910. {
  2911. name: "empty server",
  2912. },
  2913. {
  2914. name: "just the required cipher suite",
  2915. tlsConfig: &tls.Config{
  2916. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2917. },
  2918. },
  2919. {
  2920. name: "missing required cipher suite",
  2921. tlsConfig: &tls.Config{
  2922. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2923. },
  2924. wantErr: "is missing HTTP/2-required TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
  2925. },
  2926. {
  2927. name: "required after bad",
  2928. tlsConfig: &tls.Config{
  2929. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2930. },
  2931. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2932. },
  2933. {
  2934. name: "bad after required",
  2935. tlsConfig: &tls.Config{
  2936. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2937. },
  2938. },
  2939. }
  2940. for _, tt := range tests {
  2941. srv := &http.Server{TLSConfig: tt.tlsConfig}
  2942. err := ConfigureServer(srv, nil)
  2943. if (err != nil) != (tt.wantErr != "") {
  2944. if tt.wantErr != "" {
  2945. t.Errorf("%s: success, but want error", tt.name)
  2946. } else {
  2947. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2948. }
  2949. }
  2950. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2951. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2952. }
  2953. if err == nil && !srv.TLSConfig.PreferServerCipherSuites {
  2954. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2955. }
  2956. }
  2957. }
  2958. func TestServerRejectHeadWithBody(t *testing.T) {
  2959. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2960. // No response body.
  2961. })
  2962. defer st.Close()
  2963. st.greet()
  2964. st.writeHeaders(HeadersFrameParam{
  2965. StreamID: 1, // clients send odd numbers
  2966. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2967. EndStream: false, // what we're testing, a bogus HEAD request with body
  2968. EndHeaders: true,
  2969. })
  2970. st.wantRSTStream(1, ErrCodeProtocol)
  2971. }
  2972. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2973. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2974. // No response body. (or smaller than one frame)
  2975. })
  2976. defer st.Close()
  2977. st.greet()
  2978. st.writeHeaders(HeadersFrameParam{
  2979. StreamID: 1, // clients send odd numbers
  2980. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2981. EndStream: true,
  2982. EndHeaders: true,
  2983. })
  2984. h := st.wantHeaders()
  2985. headers := st.decodeHeader(h.HeaderBlockFragment())
  2986. want := [][2]string{
  2987. {":status", "200"},
  2988. {"content-type", "text/plain; charset=utf-8"},
  2989. }
  2990. if !reflect.DeepEqual(headers, want) {
  2991. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2992. }
  2993. }
  2994. // golang.org/issue/13495
  2995. func TestServerNoDuplicateContentType(t *testing.T) {
  2996. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2997. w.Header()["Content-Type"] = []string{""}
  2998. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  2999. })
  3000. defer st.Close()
  3001. st.greet()
  3002. st.writeHeaders(HeadersFrameParam{
  3003. StreamID: 1,
  3004. BlockFragment: st.encodeHeader(),
  3005. EndStream: true,
  3006. EndHeaders: true,
  3007. })
  3008. h := st.wantHeaders()
  3009. headers := st.decodeHeader(h.HeaderBlockFragment())
  3010. want := [][2]string{
  3011. {":status", "200"},
  3012. {"content-type", ""},
  3013. {"content-length", "41"},
  3014. }
  3015. if !reflect.DeepEqual(headers, want) {
  3016. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  3017. }
  3018. }
  3019. func disableGoroutineTracking() (restore func()) {
  3020. old := DebugGoroutines
  3021. DebugGoroutines = false
  3022. return func() { DebugGoroutines = old }
  3023. }
  3024. func BenchmarkServer_GetRequest(b *testing.B) {
  3025. defer disableGoroutineTracking()()
  3026. b.ReportAllocs()
  3027. const msg = "Hello, world."
  3028. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3029. n, err := io.Copy(ioutil.Discard, r.Body)
  3030. if err != nil || n > 0 {
  3031. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3032. }
  3033. io.WriteString(w, msg)
  3034. })
  3035. defer st.Close()
  3036. st.greet()
  3037. // Give the server quota to reply. (plus it has the the 64KB)
  3038. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3039. b.Fatal(err)
  3040. }
  3041. hbf := st.encodeHeader(":method", "GET")
  3042. for i := 0; i < b.N; i++ {
  3043. streamID := uint32(1 + 2*i)
  3044. st.writeHeaders(HeadersFrameParam{
  3045. StreamID: streamID,
  3046. BlockFragment: hbf,
  3047. EndStream: true,
  3048. EndHeaders: true,
  3049. })
  3050. st.wantHeaders()
  3051. st.wantData()
  3052. }
  3053. }
  3054. func BenchmarkServer_PostRequest(b *testing.B) {
  3055. defer disableGoroutineTracking()()
  3056. b.ReportAllocs()
  3057. const msg = "Hello, world."
  3058. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3059. n, err := io.Copy(ioutil.Discard, r.Body)
  3060. if err != nil || n > 0 {
  3061. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3062. }
  3063. io.WriteString(w, msg)
  3064. })
  3065. defer st.Close()
  3066. st.greet()
  3067. // Give the server quota to reply. (plus it has the the 64KB)
  3068. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3069. b.Fatal(err)
  3070. }
  3071. hbf := st.encodeHeader(":method", "POST")
  3072. for i := 0; i < b.N; i++ {
  3073. streamID := uint32(1 + 2*i)
  3074. st.writeHeaders(HeadersFrameParam{
  3075. StreamID: streamID,
  3076. BlockFragment: hbf,
  3077. EndStream: false,
  3078. EndHeaders: true,
  3079. })
  3080. st.writeData(streamID, true, nil)
  3081. st.wantHeaders()
  3082. st.wantData()
  3083. }
  3084. }
  3085. type connStateConn struct {
  3086. net.Conn
  3087. cs tls.ConnectionState
  3088. }
  3089. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  3090. // golang.org/issue/12737 -- handle any net.Conn, not just
  3091. // *tls.Conn.
  3092. func TestServerHandleCustomConn(t *testing.T) {
  3093. var s Server
  3094. c1, c2 := net.Pipe()
  3095. clientDone := make(chan struct{})
  3096. handlerDone := make(chan struct{})
  3097. var req *http.Request
  3098. go func() {
  3099. defer close(clientDone)
  3100. defer c2.Close()
  3101. fr := NewFramer(c2, c2)
  3102. io.WriteString(c2, ClientPreface)
  3103. fr.WriteSettings()
  3104. fr.WriteSettingsAck()
  3105. f, err := fr.ReadFrame()
  3106. if err != nil {
  3107. t.Error(err)
  3108. return
  3109. }
  3110. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  3111. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  3112. return
  3113. }
  3114. f, err = fr.ReadFrame()
  3115. if err != nil {
  3116. t.Error(err)
  3117. return
  3118. }
  3119. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  3120. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  3121. return
  3122. }
  3123. var henc hpackEncoder
  3124. fr.WriteHeaders(HeadersFrameParam{
  3125. StreamID: 1,
  3126. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  3127. EndStream: true,
  3128. EndHeaders: true,
  3129. })
  3130. go io.Copy(ioutil.Discard, c2)
  3131. <-handlerDone
  3132. }()
  3133. const testString = "my custom ConnectionState"
  3134. fakeConnState := tls.ConnectionState{
  3135. ServerName: testString,
  3136. Version: tls.VersionTLS12,
  3137. }
  3138. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  3139. BaseConfig: &http.Server{
  3140. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  3141. defer close(handlerDone)
  3142. req = r
  3143. }),
  3144. }})
  3145. select {
  3146. case <-clientDone:
  3147. case <-time.After(5 * time.Second):
  3148. t.Fatal("timeout waiting for handler")
  3149. }
  3150. if req.TLS == nil {
  3151. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  3152. }
  3153. if req.TLS.ServerName != testString {
  3154. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  3155. }
  3156. }
  3157. // golang.org/issue/14214
  3158. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  3159. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3160. t.Error("should not get to Handler")
  3161. })
  3162. defer st.Close()
  3163. st.greet()
  3164. st.bodylessReq1("connection", "foo")
  3165. hf := st.wantHeaders()
  3166. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3167. wanth := [][2]string{
  3168. {":status", "400"},
  3169. {"content-type", "text/plain; charset=utf-8"},
  3170. {"x-content-type-options", "nosniff"},
  3171. {"content-length", "51"},
  3172. }
  3173. if !reflect.DeepEqual(goth, wanth) {
  3174. t.Errorf("Got headers %v; want %v", goth, wanth)
  3175. }
  3176. }
  3177. type hpackEncoder struct {
  3178. enc *hpack.Encoder
  3179. buf bytes.Buffer
  3180. }
  3181. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  3182. if len(headers)%2 == 1 {
  3183. panic("odd number of kv args")
  3184. }
  3185. he.buf.Reset()
  3186. if he.enc == nil {
  3187. he.enc = hpack.NewEncoder(&he.buf)
  3188. }
  3189. for len(headers) > 0 {
  3190. k, v := headers[0], headers[1]
  3191. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  3192. if err != nil {
  3193. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  3194. }
  3195. headers = headers[2:]
  3196. }
  3197. return he.buf.Bytes()
  3198. }
  3199. func TestCheckValidHTTP2Request(t *testing.T) {
  3200. tests := []struct {
  3201. h http.Header
  3202. want error
  3203. }{
  3204. {
  3205. h: http.Header{"Te": {"trailers"}},
  3206. want: nil,
  3207. },
  3208. {
  3209. h: http.Header{"Te": {"trailers", "bogus"}},
  3210. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3211. },
  3212. {
  3213. h: http.Header{"Foo": {""}},
  3214. want: nil,
  3215. },
  3216. {
  3217. h: http.Header{"Connection": {""}},
  3218. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3219. },
  3220. {
  3221. h: http.Header{"Proxy-Connection": {""}},
  3222. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3223. },
  3224. {
  3225. h: http.Header{"Keep-Alive": {""}},
  3226. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3227. },
  3228. {
  3229. h: http.Header{"Upgrade": {""}},
  3230. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3231. },
  3232. }
  3233. for i, tt := range tests {
  3234. got := checkValidHTTP2RequestHeaders(tt.h)
  3235. if !reflect.DeepEqual(got, tt.want) {
  3236. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3237. }
  3238. }
  3239. }
  3240. // golang.org/issue/14030
  3241. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3242. const msg = "Hello"
  3243. const msg2 = "World"
  3244. doRead := make(chan bool, 1)
  3245. defer close(doRead) // fallback cleanup
  3246. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3247. io.WriteString(w, msg)
  3248. w.(http.Flusher).Flush()
  3249. // Do a read, which might force a 100-continue status to be sent.
  3250. <-doRead
  3251. r.Body.Read(make([]byte, 10))
  3252. io.WriteString(w, msg2)
  3253. }, optOnlyServer)
  3254. defer st.Close()
  3255. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3256. defer tr.CloseIdleConnections()
  3257. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3258. req.Header.Set("Expect", "100-continue")
  3259. res, err := tr.RoundTrip(req)
  3260. if err != nil {
  3261. t.Fatal(err)
  3262. }
  3263. defer res.Body.Close()
  3264. buf := make([]byte, len(msg))
  3265. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3266. t.Fatal(err)
  3267. }
  3268. if string(buf) != msg {
  3269. t.Fatalf("msg = %q; want %q", buf, msg)
  3270. }
  3271. doRead <- true
  3272. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3273. t.Fatal(err)
  3274. }
  3275. if string(buf) != msg2 {
  3276. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3277. }
  3278. }
  3279. type funcReader func([]byte) (n int, err error)
  3280. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3281. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3282. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3283. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3284. unblock := make(chan bool, 1)
  3285. defer close(unblock)
  3286. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3287. // Don't read the 16KB request body. Wait until the client's
  3288. // done sending it and then return. This should cause the Server
  3289. // to then return those 16KB of flow control to the client.
  3290. <-unblock
  3291. }, optOnlyServer)
  3292. defer st.Close()
  3293. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3294. defer tr.CloseIdleConnections()
  3295. // This previously hung on the 4th iteration.
  3296. for i := 0; i < 6; i++ {
  3297. body := io.MultiReader(
  3298. io.LimitReader(neverEnding('A'), 16<<10),
  3299. funcReader(func([]byte) (n int, err error) {
  3300. unblock <- true
  3301. return 0, io.EOF
  3302. }),
  3303. )
  3304. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3305. res, err := tr.RoundTrip(req)
  3306. if err != nil {
  3307. t.Fatal(err)
  3308. }
  3309. res.Body.Close()
  3310. }
  3311. }
  3312. func TestServerIdleTimeout(t *testing.T) {
  3313. if testing.Short() {
  3314. t.Skip("skipping in short mode")
  3315. }
  3316. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3317. }, func(h2s *Server) {
  3318. h2s.IdleTimeout = 500 * time.Millisecond
  3319. })
  3320. defer st.Close()
  3321. st.greet()
  3322. ga := st.wantGoAway()
  3323. if ga.ErrCode != ErrCodeNo {
  3324. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3325. }
  3326. }
  3327. func TestServerIdleTimeout_AfterRequest(t *testing.T) {
  3328. if testing.Short() {
  3329. t.Skip("skipping in short mode")
  3330. }
  3331. const timeout = 250 * time.Millisecond
  3332. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3333. time.Sleep(timeout * 2)
  3334. }, func(h2s *Server) {
  3335. h2s.IdleTimeout = timeout
  3336. })
  3337. defer st.Close()
  3338. st.greet()
  3339. // Send a request which takes twice the timeout. Verifies the
  3340. // idle timeout doesn't fire while we're in a request:
  3341. st.bodylessReq1()
  3342. st.wantHeaders()
  3343. // But the idle timeout should be rearmed after the request
  3344. // is done:
  3345. ga := st.wantGoAway()
  3346. if ga.ErrCode != ErrCodeNo {
  3347. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3348. }
  3349. }
  3350. // grpc-go closes the Request.Body currently with a Read.
  3351. // Verify that it doesn't race.
  3352. // See https://github.com/grpc/grpc-go/pull/938
  3353. func TestRequestBodyReadCloseRace(t *testing.T) {
  3354. for i := 0; i < 100; i++ {
  3355. body := &requestBody{
  3356. pipe: &pipe{
  3357. b: new(bytes.Buffer),
  3358. },
  3359. }
  3360. body.pipe.CloseWithError(io.EOF)
  3361. done := make(chan bool, 1)
  3362. buf := make([]byte, 10)
  3363. go func() {
  3364. time.Sleep(1 * time.Millisecond)
  3365. body.Close()
  3366. done <- true
  3367. }()
  3368. body.Read(buf)
  3369. <-done
  3370. }
  3371. }
  3372. func TestServerGracefulShutdown(t *testing.T) {
  3373. shutdownCh := make(chan struct{})
  3374. defer func() { testh1ServerShutdownChan = nil }()
  3375. testh1ServerShutdownChan = func(*http.Server) <-chan struct{} { return shutdownCh }
  3376. var st *serverTester
  3377. handlerDone := make(chan struct{})
  3378. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3379. defer close(handlerDone)
  3380. close(shutdownCh)
  3381. ga := st.wantGoAway()
  3382. if ga.ErrCode != ErrCodeNo {
  3383. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3384. }
  3385. if ga.LastStreamID != 1 {
  3386. t.Errorf("GOAWAY LastStreamID = %v; want 1", ga.LastStreamID)
  3387. }
  3388. w.Header().Set("x-foo", "bar")
  3389. })
  3390. defer st.Close()
  3391. st.greet()
  3392. st.bodylessReq1()
  3393. <-handlerDone
  3394. hf := st.wantHeaders()
  3395. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3396. wanth := [][2]string{
  3397. {":status", "200"},
  3398. {"x-foo", "bar"},
  3399. {"content-type", "text/plain; charset=utf-8"},
  3400. {"content-length", "0"},
  3401. }
  3402. if !reflect.DeepEqual(goth, wanth) {
  3403. t.Errorf("Got headers %v; want %v", goth, wanth)
  3404. }
  3405. n, err := st.cc.Read([]byte{0})
  3406. if n != 0 || err == nil {
  3407. t.Errorf("Read = %v, %v; want 0, non-nil", n, err)
  3408. }
  3409. }